Skip to content

Commit eae6954

Browse files
committed
fix: build example phar fail on ci
1 parent e3ecd9b commit eae6954

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

.github/workflows/php.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,5 +60,5 @@ jobs:
6060
6161
- name: Test build PHAR
6262
run: |
63-
php -d phar.readonly=0 examples/app phar pack -o=myapp.phar
63+
php -d phar.readonly=0 examples/app phar pack --no-progress -o=myapp.phar
6464
php myapp.phar -h

phar.build.inc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ $compiler
2525
'composer.json',
2626
'README.md',
2727
'test/bootstrap.php',
28+
'examples/commands.php'
2829
])
2930
->setCliIndex('examples/app')
3031
// ->setWebIndex('web/index.php')

src/Component/PharCompiler.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ private static function checkEnv(): void
263263
* @throws BadMethodCallException
264264
* @throws RuntimeException
265265
*/
266-
public static function unpack(string $pharFile, string $extractTo, array|string $files = null, bool $overwrite = false): bool
266+
public static function unpack(string $pharFile, string $extractTo, array|string|null $files = null, bool $overwrite = false): bool
267267
{
268268
self::checkEnv();
269269

0 commit comments

Comments
 (0)