address reviews

Author: dylanlott

Cargo.toml

@@ -20,11 +20,11 @@ path = "bin/builder.rs"
 [dependencies]
 init4-bin-base = { version = "0.18.0-rc.0", features = ["perms", "aws"] }
 
-signet-constants = { version = "0.16.0-rc.1" }
-signet-sim = { version = "0.16.0-rc.1" }
-signet-tx-cache = { version = "0.16.0-rc.1" }
-signet-types = { version = "0.16.0-rc.1" }
-signet-zenith = { version = "0.16.0-rc.1" }
+signet-constants = { version = "0.16.0-rc.0" }
+signet-sim = { version = "0.16.0-rc.0" }
+signet-tx-cache = { version = "0.16.0-rc.0" }
+signet-types = { version = "0.16.0-rc.0" }
+signet-zenith = { version = "0.16.0-rc.0" }
 signet-block-processor = { git = "https://github.com/init4tech/node-components", tag = "v0.16.0-rc.2" }
 signet-genesis = { git = "https://github.com/init4tech/node-components", tag = "v0.16.0-rc.2" }
 
@@ -65,12 +65,12 @@ alloy-chains = "0.2"
 # comment / uncomment for local dev
 # [patch.crates-io]
 # signet-constants = { path = "../signet-sdk/crates/constants" }
-# signet-sim = { path = "../signet-sdk/crates/sim" }
-# signet-tx-cache = { path = "../signet-sdk/crates/tx-cache" }
 # signet-types = { path = "../signet-sdk/crates/types" }
 # signet-zenith = { path = "../signet-sdk/crates/zenith" }
-
+# signet-sim = { path = "../signet-sdk/crates/sim" }
 # signet-evm = { path = "../signet-sdk/crates/evm" }
 # signet-extract = { path = "../signet-sdk/crates/extract" }
 # signet-journal = { path = "../signet-sdk/crates/journal" }
+# signet-tx-cache = { path = "../signet-sdk/crates/tx-cache" }
 # signet-bundle = { path = "../signet-sdk/crates/bundle" }
+# init4-bin-base = { path = "../bin-base" }

src/config.rs

@@ -155,10 +155,10 @@ pub struct BuilderConfig {
     )]
     pub max_host_gas_coefficient: Option<u8>,
 
-    /// Number of seconds before the end of the slot to stop querying for new blocks
+    /// Number of milliseconds before the end of the slot to stop querying for new blocks and start the block signing and submission process.
     #[from_env(
         var = "BLOCK_QUERY_CUTOFF_BUFFER",
-        desc = "Number of milliseconds before the end of the slot to stop querying for new transactions and start the block signing and submission process",
+        desc = "Number of milliseconds before the end of the slot to stop querying for new transactions and start the block signing and submission process. Quincey will stop accepting signature requests 2000ms before the end of the slot, so this buffer should be no less than 2000ms to match.",
         default = 3000
     )]
     pub block_query_cutoff_buffer: u64,

src/tasks/block/sim.rs

@@ -230,7 +230,7 @@ impl SimulatorTask {
     /// # Returns
     ///
     /// An `Instant` representing the simulation deadline as calculated by determining
-    /// the milliseconds  left in the current slot and adding that to the current
+    /// the milliseconds left in the current slot and adding that to the current
     /// timestamp in UNIX seconds.
     pub fn calculate_deadline(&self) -> Instant {
         // Get the current number of milliseconds into the slot.