feat: TryFrom impl for known chains on relevant types (#97)

Author: prestwich

crates/constants/src/types/environment.rs

@@ -44,18 +44,25 @@ impl SignetEnvironmentConstants {
     }
 }
 
-impl FromStr for SignetEnvironmentConstants {
-    type Err = ParseChainError;
+impl TryFrom<KnownChains> for SignetEnvironmentConstants {
+    type Error = ParseChainError;
 
-    fn from_str(s: &str) -> Result<Self, Self::Err> {
-        let chain: KnownChains = s.parse()?;
+    fn try_from(chain: KnownChains) -> Result<Self, Self::Error> {
         match chain {
             #[cfg(any(test, feature = "test-utils"))]
             KnownChains::Test => Ok(Self::test()),
         }
     }
 }
 
+impl FromStr for SignetEnvironmentConstants {
+    type Err = ParseChainError;
+
+    fn from_str(s: &str) -> Result<Self, Self::Err> {
+        s.parse::<KnownChains>()?.try_into()
+    }
+}
+
 #[cfg(test)]
 mod test {
     use super::*;

crates/constants/src/types/mod.rs

@@ -216,18 +216,25 @@ impl SignetSystemConstants {
     }
 }
 
-impl FromStr for SignetSystemConstants {
-    type Err = ParseChainError;
+impl TryFrom<KnownChains> for SignetSystemConstants {
+    type Error = ParseChainError;
 
-    fn from_str(s: &str) -> Result<Self, Self::Err> {
-        let chain: KnownChains = s.parse()?;
+    fn try_from(chain: KnownChains) -> Result<Self, Self::Error> {
         match chain {
             #[cfg(any(test, feature = "test-utils"))]
             KnownChains::Test => Ok(Self::test()),
         }
     }
 }
 
+impl FromStr for SignetSystemConstants {
+    type Err = ParseChainError;
+
+    fn from_str(s: &str) -> Result<Self, Self::Err> {
+        s.parse::<KnownChains>()?.try_into()
+    }
+}
+
 /// All constants pertaining to the Signet system.
 #[derive(Debug, Clone, PartialEq, Eq)]
 pub struct SignetConstants {
@@ -273,14 +280,21 @@ impl SignetConstants {
     }
 }
 
-impl FromStr for SignetConstants {
-    type Err = ParseChainError;
+impl TryFrom<KnownChains> for SignetConstants {
+    type Error = ParseChainError;
 
-    fn from_str(s: &str) -> Result<Self, Self::Err> {
-        let chain: KnownChains = s.parse()?;
+    fn try_from(chain: KnownChains) -> Result<Self, Self::Error> {
         match chain {
             #[cfg(any(test, feature = "test-utils"))]
             KnownChains::Test => Ok(Self::test()),
         }
     }
 }
+
+impl FromStr for SignetConstants {
+    type Err = ParseChainError;
+
+    fn from_str(s: &str) -> Result<Self, Self::Err> {
+        s.parse::<KnownChains>()?.try_into()
+    }
+}

crates/constants/src/types/rollup.rs

@@ -102,14 +102,21 @@ impl RollupConstants {
     }
 }
 
-impl FromStr for RollupConstants {
-    type Err = ParseChainError;
+impl TryFrom<KnownChains> for RollupConstants {
+    type Error = ParseChainError;
 
-    fn from_str(s: &str) -> Result<Self, Self::Err> {
-        let chain: KnownChains = s.parse()?;
+    fn try_from(chain: KnownChains) -> Result<Self, Self::Error> {
         match chain {
             #[cfg(any(test, feature = "test-utils"))]
             KnownChains::Test => Ok(Self::test()),
         }
     }
 }
+
+impl FromStr for RollupConstants {
+    type Err = ParseChainError;
+
+    fn from_str(s: &str) -> Result<Self, Self::Err> {
+        s.parse::<KnownChains>()?.try_into()
+    }
+}

crates/test-utils/src/specs/host_spec.rs

@@ -406,17 +406,24 @@ impl HostBlockSpec {
     }
 }
 
-impl FromStr for HostBlockSpec {
-    type Err = ParseChainError;
+impl TryFrom<KnownChains> for HostBlockSpec {
+    type Error = ParseChainError;
 
-    fn from_str(s: &str) -> Result<Self, Self::Err> {
-        let chain: KnownChains = s.parse()?;
+    fn try_from(chain: KnownChains) -> Result<Self, Self::Error> {
         match chain {
             KnownChains::Test => Ok(Self::test()),
         }
     }
 }
 
+impl FromStr for HostBlockSpec {
+    type Err = ParseChainError;
+
+    fn from_str(s: &str) -> Result<Self, Self::Err> {
+        s.parse::<KnownChains>()?.try_into()
+    }
+}
+
 fn to_receipt<T>(address: Address, t: &T) -> ReceiptEnvelope
 where
     for<'a> &'a T: Into<LogData>,

crates/test-utils/src/specs/ru_spec.rs

@@ -141,13 +141,20 @@ impl RuBlockSpec {
     }
 }
 
-impl FromStr for RuBlockSpec {
-    type Err = ParseChainError;
+impl TryFrom<KnownChains> for RuBlockSpec {
+    type Error = ParseChainError;
 
-    fn from_str(s: &str) -> Result<Self, Self::Err> {
-        let chain: KnownChains = s.parse()?;
+    fn try_from(chain: KnownChains) -> Result<Self, Self::Error> {
         match chain {
             KnownChains::Test => Ok(Self::test()),
         }
     }
 }
+
+impl FromStr for RuBlockSpec {
+    type Err = ParseChainError;
+
+    fn from_str(s: &str) -> Result<Self, Self::Err> {
+        s.parse::<KnownChains>()?.try_into()
+    }
+}