fix: ownable constructor invocation

Author: prestwich

src/apps/Bridge.sol

@@ -22,12 +22,13 @@ abstract contract BridgeL2 is SignetL2, BurnMintERC20 {
 
     /// @notice Bridges assets into the rollup for a given recipient.
     function _bridgeIn(address recipient, uint256 amount, RollupOrders.Input[] memory inputs) internal virtual {
+        _mint(recipient, amount);
+
         RollupOrders.Output[] memory outputs = new RollupOrders.Output[](1);
         outputs[0] = makeHostOutput(HOST_ASSET, amount, HOST_BANK);
 
         ORDERS.initiate(block.timestamp, inputs, outputs);
 
-        _mint(recipient, amount);
     }
 
     /// @notice Bridges assets into the rollup for a given recipient.
@@ -41,12 +42,13 @@ abstract contract BridgeL2 is SignetL2, BurnMintERC20 {
     /// This transaction should be paired with some off-chain logic that fills
     /// orders from the L1 bank.
     function _bridgeOut(address recipient, uint256 amount, RollupOrders.Input[] memory inputs) internal virtual {
+        burnFrom(msg.sender, amount);
+
         RollupOrders.Output[] memory outputs = new RollupOrders.Output[](1);
         outputs[0] = makeHostOutput(HOST_ASSET, amount, recipient);
 
         ORDERS.initiate(block.timestamp, inputs, outputs);
 
-        _burn(msg.sender, amount);
     }
 
     /// @notice Burn asset on L2, and create an order to bridge out asset to

src/l2/SelfOwned.sol

@@ -6,7 +6,5 @@ import {Ownable} from "openzeppelin-contracts/contracts/access/Ownable.sol";
 import {SignetL2} from "./Signet.sol";
 
 abstract contract SelfOwned is SignetL2, Ownable {
-    constructor() {
-        Ownable(aliasedSelf());
-    }
+    constructor() Ownable(aliasedSelf()) {}
 }

test/SelfOwned.sol

@@ -4,9 +4,15 @@ pragma solidity ^0.8.13;
 import {SimpleERC20} from "simple-erc20/SimpleERC20.sol";
 
 import {PecorinoTest} from "./Base.sol";
+
 import {SignetL2} from "../src/l2/Signet.sol";
+import {SelfOwned} from "../src/l2/SelfOwned.sol";
 import {AddressAliasHelper} from "../src/vendor/AddressAliasHelper.sol";
 
+contract SelfOwnedNothing is SelfOwned {
+    constructor() {}
+}
+
 contract SelfOwnedToken is SignetL2, SimpleERC20 {
     constructor() SimpleERC20(aliasedSelf(), "My Token", "MTK", 18) {
         assert(HOST_WETH != address(0));
@@ -16,11 +22,18 @@ contract SelfOwnedToken is SignetL2, SimpleERC20 {
 contract TestSelfOwned is PecorinoTest {
     SelfOwnedToken token;
 
+    SelfOwnedNothing nothing;
+
     constructor() {
         token = new SelfOwnedToken();
+        nothing = new SelfOwnedNothing();
     }
 
-    function test_ownerIsSelfOnL1() public view {
+    function test_tokenOwnerIsSelfOnL1() public view {
         assertEq(token.owner(), AddressAliasHelper.applyL1ToL2Alias(address(token)));
     }
+
+    function test_nothingOwnerIsSelfOnL1() public view {
+        assertEq(nothing.owner(), AddressAliasHelper.applyL1ToL2Alias(address(nothing)));
+    }
 }