refactor: simplify service/ingress/deployment templates

Removes conditional logic based on `endpoints` vs `port`
for service, ingress, and deployment templates.

- Simplifies template logic by assuming all apps will
  define endpoints.
- Removes redundant `if` statements, making the templates
  easier to read and maintain.
- Improves consistency across application definitions.

Author: in-jun

chart/templates/app/deployment.yaml

@@ -48,20 +48,12 @@ spec:
               exec:
                 command: ["/bin/sh", "-c", "sleep 10"]
           ports:
-          {{- if $app.endpoints }}
           {{- range $service := $app.endpoints }}
             - containerPort: {{ $service.port }}
           {{- end }}
-          {{- else }}
-            - containerPort: {{ $app.port }}
-          {{- end }}
           readinessProbe:
             tcpSocket:
-            {{- if $app.endpoints }}
               port: {{ (index $app.endpoints 0).port }}
-            {{- else }}
-              port: {{ $app.port }}
-            {{- end }}
             initialDelaySeconds: 20
             periodSeconds: 10
             successThreshold: 3

chart/templates/app/ingress-route.yaml

@@ -1,6 +1,5 @@
 {{- range $app := .Values.applications }}
 {{- if $app.git.hash }}
-{{- if $app.endpoints }}
 {{- range $service := $app.endpoints }}
 {{- range $route := $service.routes }}
 {{- $domain := regexFind "^[^/]+" $route }}
@@ -27,38 +26,11 @@ spec:
       {{- end }}
 {{- end }}
 {{- end }}
-{{- else }}
-{{- range $route := $app.routes }}
-{{- $domain := regexFind "^[^/]+" $route }}
-{{- $path := regexFind "/.*" $route | default "" }}
----
-apiVersion: traefik.io/v1alpha1
-kind: IngressRoute
-metadata:
-  name: {{ $.Values.project }}-{{ $app.name }}-{{ $domain | replace "." "-" }}{{ if $path }}{{ $path | replace "/" "-" }}{{ end }}-route
-  namespace: {{ $.Values.project }}
-spec:
-  entryPoints:
-    - web
-    - websecure
-  routes:
-    - match: Host(`{{ $domain }}`){{ if $path }} && PathPrefix(`{{ $path }}`){{ end }}
-      kind: Rule
-      services:
-        - name: {{ $app.name }}
-          port: {{ $app.port }}
-      {{- if $path }}
-      middlewares:
-        - name: {{ $.Values.project }}-{{ $app.name }}-{{ $path | replace "/" "-" | trimPrefix "-" }}-strip-prefix
-      {{- end }}
-{{- end }}
-{{- end }}
 {{- end }}
 {{- end }}
 
 {{- range $app := .Values.applications }}
 {{- if $app.git.hash }}
-{{- if $app.endpoints }}
 {{- range $service := $app.endpoints }}
 {{- range $route := $service.routes }}
 {{- $path := regexFind "/.*" $route | default "" }}
@@ -76,22 +48,5 @@ spec:
 {{- end }}
 {{- end }}
 {{- end }}
-{{- else }}
-{{- range $route := $app.routes }}
-{{- $path := regexFind "/.*" $route | default "" }}
-{{- if $path }}
----
-apiVersion: traefik.io/v1alpha1
-kind: Middleware
-metadata:
-  name: {{ $.Values.project }}-{{ $app.name }}-{{ $path | replace "/" "-" | trimPrefix "-" }}-strip-prefix
-  namespace: {{ $.Values.project }}
-spec:
-  stripPrefix:
-    prefixes:
-      - {{ $path }}
-{{- end }}
-{{- end }}
-{{- end }}
 {{- end }}
 {{- end }}

chart/templates/app/service.yaml

@@ -8,15 +8,11 @@ metadata:
   namespace: {{ $.Values.project }}
 spec:
   ports:
-  {{- if $app.endpoints }}
-  {{- range $service := $app.endpoints }}
-  - port: {{ $service.port }}
+  {{- range $index, $service := $app.endpoints }}
+  - name: {{ if $service.name }}{{ $service.name }}{{ else }}port-{{ $service.port }}{{ end }}
+    port: {{ $service.port }}
     targetPort: {{ $service.port }}
   {{- end }}
-  {{- else }}
-  - port: {{ $app.port }}
-    targetPort: {{ $app.port }}
-  {{- end }}
   selector:
     app: {{ $app.name }}-app
 {{- end }}