fixing nango dependency resolution

Author: amikofalvy

packages/agents-core/package.json

@@ -60,6 +60,8 @@
     "@better-auth/sso": "^1.4.0",
     "@hono/node-server": "^1.14.3",
     "@modelcontextprotocol/sdk": "^1.17.2",
+    "@nangohq/node": "^0.69.5",
+    "@nangohq/types": "^0.69.5",
     "@openrouter/ai-sdk-provider": "^1.2.0",
     "@opentelemetry/api": "^1.9.0",
     "ai": "6.0.0-beta.124",
@@ -86,8 +88,6 @@
     "zod": "^4.1.11"
   },
   "optionalDependencies": {
-    "@nangohq/node": "^0.69.5",
-    "@nangohq/types": "^0.69.5",
     "@opentelemetry/auto-instrumentations-node": "^0.62.0",
     "@opentelemetry/baggage-span-processor": "^0.4.0",
     "@opentelemetry/exporter-jaeger": "^2.0.1",

packages/agents-core/src/credential-stores/defaults.ts

@@ -2,7 +2,7 @@ import type { CredentialStore } from '../types/server';
 import { DEFAULT_NANGO_STORE_ID } from './default-constants';
 import { createKeyChainStore } from './keychain-store';
 import { InMemoryCredentialStore } from './memory-store';
-import { createNangoCredentialStore, isNangoAvailable } from './nango-store';
+import { createNangoCredentialStore } from './nango-store';
 
 /**
  * Create default credential stores based on environment variables
@@ -13,18 +13,14 @@ export function createDefaultCredentialStores(): CredentialStore[] {
   // Always include in-memory store
   stores.push(new InMemoryCredentialStore('memory-default'));
 
-  // Include Nango store if NANGO_SECRET_KEY is set AND Nango is installed
-  if (process.env.NANGO_SECRET_KEY && isNangoAvailable()) {
-    try {
-      stores.push(
-        createNangoCredentialStore(DEFAULT_NANGO_STORE_ID, {
-          apiUrl: process.env.NANGO_SERVER_URL || 'https://api.nango.dev',
-          secretKey: process.env.NANGO_SECRET_KEY,
-        })
-      );
-    } catch (error) {
-      console.warn('Failed to create Nango store:', error instanceof Error ? error.message : error);
-    }
+  // Include Nango store if NANGO_SECRET_KEY is set
+  if (process.env.NANGO_SECRET_KEY) {
+    stores.push(
+      createNangoCredentialStore(DEFAULT_NANGO_STORE_ID, {
+        apiUrl: process.env.NANGO_SERVER_URL || 'https://api.nango.dev',
+        secretKey: process.env.NANGO_SECRET_KEY,
+      })
+    );
   }
 
   try {

packages/agents-core/src/credential-stores/index.ts

@@ -2,8 +2,4 @@ export { CredentialStoreRegistry } from './CredentialStoreRegistry';
 export { createDefaultCredentialStores } from './defaults';
 export { createKeyChainStore, KeyChainStore } from './keychain-store';
 export { InMemoryCredentialStore } from './memory-store';
-export {
-  createNangoCredentialStore,
-  isNangoAvailable,
-  NangoCredentialStore,
-} from './nango-store';
+export { createNangoCredentialStore, NangoCredentialStore } from './nango-store';

packages/agents-core/src/credential-stores/nango-store.ts

@@ -1,50 +1,12 @@
 import { z } from '@hono/zod-openapi';
+import { type AllAuthCredentials, type AuthModeType, Nango } from '@nangohq/node';
+import type { ApiKeyCredentials, ApiPublicIntegration } from '@nangohq/types';
 import { CredentialStoreType } from '../types';
 import type { CredentialStore } from '../types/server';
 import { getLogger } from '../utils/logger';
 
 const logger = getLogger('nango-credential-store');
 
-// Dynamic import types - these are loaded at runtime if Nango is installed
-type NangoType = import('@nangohq/node').Nango;
-type AllAuthCredentials = import('@nangohq/node').AllAuthCredentials;
-type AuthModeType = import('@nangohq/node').AuthModeType;
-type ApiKeyCredentials = import('@nangohq/types').ApiKeyCredentials;
-type ApiPublicIntegration = import('@nangohq/types').ApiPublicIntegration;
-
-// Lazy-loaded Nango module
-let nangoModule: typeof import('@nangohq/node') | null = null;
-
-/**
- * Check if Nango is available
- */
-export function isNangoAvailable(): boolean {
-  try {
-    require.resolve('@nangohq/node');
-    return true;
-  } catch {
-    return false;
-  }
-}
-
-/**
- * Dynamically load Nango module
- */
-async function loadNangoModule(): Promise<typeof import('@nangohq/node')> {
-  if (nangoModule) {
-    return nangoModule;
-  }
-
-  try {
-    nangoModule = await import('@nangohq/node');
-    return nangoModule;
-  } catch {
-    throw new Error(
-      'Nango is not installed. To use Nango credential store, install it with: npm install @nangohq/node @nangohq/types'
-    );
-  }
-}
-
 const CredentialKeySchema = z.object({
   connectionId: z.string().min(1, 'connectionId must be a non-empty string'),
   providerConfigKey: z.string().min(1, 'providerConfigKey must be a non-empty string'),
@@ -114,35 +76,20 @@ function isSupportedAuthMode(mode: unknown): mode is SupportedAuthMode {
 /**
  * Nango-based CredentialStore that fetches OAuth credentials from Nango API
  * Uses connectionId and providerConfigKey from metadata to fetch live credentials
- *
- * Note: This store requires the @nangohq/node and @nangohq/types packages to be installed.
- * If Nango is not installed, the store will throw helpful error messages.
  */
 export class NangoCredentialStore implements CredentialStore {
   public readonly id: string;
   public readonly type = CredentialStoreType.nango;
   private nangoConfig: NangoConfig;
-  private nangoClient: NangoType | null = null;
+  private nangoClient: Nango;
 
   constructor(id: string, config: NangoConfig) {
     this.id = id;
     this.nangoConfig = config;
-  }
-
-  /**
-   * Initialize Nango client lazily
-   */
-  private async getNangoClient(): Promise<NangoType> {
-    if (this.nangoClient) {
-      return this.nangoClient;
-    }
-
-    const { Nango } = await loadNangoModule();
     this.nangoClient = new Nango({
       secretKey: this.nangoConfig.secretKey,
       host: this.nangoConfig.apiUrl,
     });
-    return this.nangoClient;
   }
 
   private getAccessToken(credentials: AllAuthCredentials): Record<string, any> | null {
@@ -239,8 +186,7 @@ export class NangoCredentialStore implements CredentialStore {
     uniqueKey: string
   ): Promise<(ApiPublicIntegration & { areCredentialsSet: boolean }) | null> {
     try {
-      const nangoClient = await this.getNangoClient();
-      const response = await nangoClient.getIntegration(
+      const response = await this.nangoClient.getIntegration(
         { uniqueKey },
         { include: ['credentials'] }
       );
@@ -316,8 +262,7 @@ export class NangoCredentialStore implements CredentialStore {
        * where true race conditions could occur.
        */
       try {
-        const nangoClient = await this.getNangoClient();
-        const response = await nangoClient.createIntegration({
+        const response = await this.nangoClient.createIntegration({
           provider,
           unique_key: uniqueKey,
           display_name: displayName,
@@ -394,8 +339,7 @@ export class NangoCredentialStore implements CredentialStore {
     providerConfigKey: string;
   }): Promise<NangoCredentialData | null> {
     try {
-      const nangoClient = await this.getNangoClient();
-      const nangoConnection = await nangoClient.getConnection(providerConfigKey, connectionId);
+      const nangoConnection = await this.nangoClient.getConnection(providerConfigKey, connectionId);
 
       const tokenAndCredentials = this.getAccessToken(nangoConnection.credentials) ?? {};
 
@@ -507,8 +451,7 @@ export class NangoCredentialStore implements CredentialStore {
 
       const { connectionId, providerConfigKey } = parsedKey;
 
-      const nangoClient = await this.getNangoClient();
-      await nangoClient.deleteConnection(providerConfigKey, connectionId);
+      await this.nangoClient.deleteConnection(providerConfigKey, connectionId);
       return true;
     } catch (error) {
       logger.error(
@@ -527,14 +470,6 @@ export class NangoCredentialStore implements CredentialStore {
    * Check if the credential store is available and functional
    */
   async checkAvailability(): Promise<{ available: boolean; reason?: string }> {
-    // First check if Nango is installed
-    if (!isNangoAvailable()) {
-      return {
-        available: false,
-        reason: 'Nango is not installed. Install with: npm install @nangohq/node @nangohq/types',
-      };
-    }
-
     if (!this.nangoConfig.secretKey) {
       return {
         available: false,
@@ -561,21 +496,11 @@ export class NangoCredentialStore implements CredentialStore {
 /**
  * Factory function to create NangoCredentialStore
  * Automatically reads NANGO_SECRET_KEY from environment and validates it
- *
- * Note: This function requires the @nangohq/node and @nangohq/types packages to be installed.
- * If Nango is not installed, this will throw a helpful error message.
  */
 export function createNangoCredentialStore(
   id: string,
   config?: Partial<NangoConfig>
 ): NangoCredentialStore {
-  // Check if Nango is available
-  if (!isNangoAvailable()) {
-    throw new Error(
-      'Nango is not installed. To use Nango credential store, install it with: npm install @nangohq/node @nangohq/types'
-    );
-  }
-
   const nangoSecretKey = config?.secretKey || process.env.NANGO_SECRET_KEY;
 
   if (