Merge pull request #38 from inloop/update_dependencies

Update dependencies, deprecate

Author: Daniel Novak

CHANGELOG.md

@@ -1,4 +1,8 @@
-## 1.3.3(2017-11-02)
+## 1.3.5(2018-03-07)
+
+- Updated dependencies (Support library, build tools, Gradle).
+
+## 1.3.4(2017-11-02)
 
 - Update Gradle plugin. Fix Nullable annotation in getBinding().
 

README.md

@@ -1,6 +1,12 @@
 AndroidViewModel
 ================
 
+<b>Important notice: Deprecated</b>
+--------
+<b>This library served it's purpose for over 3 years. We believe that Google's Android [Architecture Components](https://developer.android.com/topic/libraries/architecture/index.html) are the preferred setup now for new projects. </b>
+<b>[INLOOPX](http://www.inloopx.com) is dedicated to continue maintaining this library (no deadline on support end). So rest assured that your existing projects don't need be migrated from AndroidViewModel because of this deprecation. We are only stopping new feature development and don't recommend using it for new projects.</b>
+
+
 Separating data and state handling from Fragments or Activities without lots of boilerplate-code. Reducing them to simple <i>dumb views</i>.
 
 <b>Basic idea behind this library</b>.
@@ -87,7 +93,7 @@ Data binding is supported - extend [ViewModelBaseBindingFragment.java](library/s
    ``` java
    @Override
    public ViewModelBindingConfig getViewModelBindingConfig() {
-      return new ViewModelBindingConfig(R.layout.fragment_sample_binding, getActivity());
+      return new ViewModelBindingConfig(R.layout.fragment_sample_binding, requireActivity());
    }
    ```
 
@@ -112,7 +118,7 @@ Download
 --------
 
 ```groovy
-compile 'eu.inloop:androidviewmodel:1.3.4'
+compile 'eu.inloop:androidviewmodel:1.3.5'
 ```
 
 ## Android Studio Template

build.gradle

@@ -4,7 +4,7 @@ buildscript {
         google()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.0.0'
+        classpath 'com.android.tools.build:gradle:3.0.1'
     }
 }
 

gradle.properties

@@ -17,4 +17,4 @@
 # http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
 # org.gradle.parallel=true
 
-VERSION_NAME=1.3.4
+VERSION_NAME=1.3.5

library/build.gradle

@@ -2,20 +2,20 @@ apply plugin: 'com.android.library'
 apply plugin: 'maven'
 
 android {
-    compileSdkVersion 26
-    buildToolsVersion '26.0.2'
+    compileSdkVersion 27
+    buildToolsVersion '27.0.3'
 
     defaultConfig {
         minSdkVersion 15
-        targetSdkVersion 26
+        targetSdkVersion 27
         versionCode 1
         versionName VERSION_NAME
         consumerProguardFiles 'proguard-rules.pro'
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
     }
     compileOptions {
-        sourceCompatibility JavaVersion.VERSION_1_7
-        targetCompatibility JavaVersion.VERSION_1_7
+        sourceCompatibility JavaVersion.VERSION_1_8
+        targetCompatibility JavaVersion.VERSION_1_8
     }
     buildTypes {
     }
@@ -26,8 +26,9 @@ android {
 }
 
 dependencies {
-    implementation 'com.android.support:support-fragment:26.1.0'
-    implementation 'com.android.support:appcompat-v7:26.1.0'
+    implementation 'com.android.support:support-fragment:27.1.0'
+    implementation 'com.android.support:appcompat-v7:27.1.0'
+    implementation 'com.android.support:support-v4:27.1.0'
 
     androidTestImplementation 'junit:junit:4.12'
     androidTestImplementation 'com.android.support.test:runner:1.0.1'

library/src/androidTest/java/eu/inloop/viewmodel/fixture/fragment/VMTestFragment.java

@@ -1,6 +1,7 @@
 package eu.inloop.viewmodel.fixture.fragment;
 
 import android.os.Bundle;
+import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
 import android.view.LayoutInflater;
 import android.view.View;
@@ -15,19 +16,19 @@ public class VMTestFragment extends ViewModelBaseFragment<IVMTestFragmentView, V
 
     @Nullable
     @Override
-    public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
+    public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
         return new LinearLayout(getContext());
     }
 
     @Override
-    public void onViewCreated(View view, @Nullable Bundle savedInstanceState) {
+    public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
         super.onViewCreated(view, savedInstanceState);
         setModelView(this);
     }
 
     @Override
     public void onLoadData(boolean loaded) {
-        getActivity().setResult(VMTestActivity.RESULT_CODE_OK);
-        getActivity().finish();
+        requireActivity().setResult(VMTestActivity.RESULT_CODE_OK);
+        requireActivity().finish();
     }
 }

library/src/main/java/eu/inloop/viewmodel/ProxyViewHelper.java

@@ -48,11 +48,6 @@ public static Class<?> getGenericType(@NonNull Class<?> in, @NonNull Class<?> wh
         return null;
     }
 
-    private static final InvocationHandler sInvocationHandler = new InvocationHandler() {
-        @Override
-        public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
-            return null;
-        }
-    };
+    private static final InvocationHandler sInvocationHandler = (proxy, method, args) -> null;
 
 }

library/src/main/java/eu/inloop/viewmodel/ViewModelHelper.java

@@ -162,15 +162,15 @@ public void onDestroy(@NonNull final Fragment fragment) {
             //no viewmodel for this fragment
             return;
         }
-        if (fragment.getActivity().isFinishing()) {
-            removeViewModel(fragment.getActivity());
+        if (fragment.requireActivity().isFinishing()) {
+            removeViewModel(fragment.requireActivity());
         } else if (fragment.isRemoving() && !mOnSaveInstanceCalled) {
             // The fragment can be still in backstack even if isRemoving() is true.
             // We check mOnSaveInstanceCalled - if this was not called then the fragment is totally removed.
             if (BuildConfig.DEBUG) {
                 Log.d("mode", "Removing viewmodel - fragment replaced"); //NON-NLS
             }
-            removeViewModel(fragment.getActivity());
+            removeViewModel(fragment.requireActivity());
         }
         mBinding = null;
     }

library/src/main/java/eu/inloop/viewmodel/base/ViewModelBaseFragment.java

@@ -29,7 +29,7 @@ public void onCreate(@Nullable final Bundle savedInstanceState) {
             //noinspection unchecked
             viewModelClass = (Class<? extends AbstractViewModel<T>>) ProxyViewHelper.getGenericType(getClass(), AbstractViewModel.class);
         }
-        getViewModelHelper().onCreate(getActivity(), savedInstanceState, viewModelClass, getArguments());
+        getViewModelHelper().onCreate(requireActivity(), savedInstanceState, viewModelClass, getArguments());
     }
 
     @CallSuper
@@ -94,7 +94,7 @@ public ViewModelHelper<T, R> getViewModelHelper() {
 
     @Override
     public void removeViewModel() {
-        mViewModelHelper.removeViewModel(getActivity());
+        mViewModelHelper.removeViewModel(requireActivity());
     }
 
     /**

library/src/main/java/eu/inloop/viewmodel/binding/ViewModelBaseBindingFragment.java

@@ -25,7 +25,7 @@ public void onCreate(@Nullable Bundle savedInstanceState) {
 
     @Nullable
     @Override
-    public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
+    public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
         getViewModelHelper().performBinding(this);
         final ViewDataBinding binding = getViewModelHelper().getBinding();
         if (binding != null) {