Skip to content

Commit df76875

Browse files
authored
Merge pull request #18 from inloop/swift5
Swift 5 update
2 parents 5d4907f + 320548b commit df76875

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
# * https://www.objc.io/issues/6-build-tools/travis-ci/
33
# * https://github.com/supermarin/xcpretty#usage
44

5-
osx_image: xcode10.1
5+
osx_image: xcode10.2
66
language: swift
77
cache: cocoapods
88
script:
99
- pod lib lint
10-
- set -o pipefail && xcodebuild -project UIViewController-DisplayChild.xcodeproj -scheme UIViewController-DisplayChild -sdk iphonesimulator12.1 ONLY_ACTIVE_ARCH=NO | xcpretty
10+
- set -o pipefail && xcodebuild -project UIViewController-DisplayChild.xcodeproj -scheme UIViewController-DisplayChild -sdk iphonesimulator12.2 ONLY_ACTIVE_ARCH=NO | xcpretty

UIViewController-DisplayChild.podspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = 'UIViewController-DisplayChild'
3-
s.version = '2.1.0'
3+
s.version = '2.2.0'
44
s.summary = 'UIViewController containment made easy'
55
s.description = <<-DESC
66
The problem: sometimes you need to embed a controller, but it might be embedded already. E.g. you have an empty view, and you do refresh only to get empty view again. If you do not check for its existence, you might end up creating a new instance unneccessarily. This can also have bad side effects when there is some heavier work in viewDidLoad for example.
@@ -13,7 +13,7 @@ The solution: transition to type, instead of an instance. If the instance does n
1313
s.author = { 'INLOOPX' => '[email protected]' }
1414
s.source = { :git => 'https://github.com/inloop/UIViewController-DisplayChild.git', :tag => s.version.to_s }
1515
s.ios.deployment_target = '10.0'
16-
s.swift_version = '4.2'
16+
s.swift_version = '5'
1717
s.source_files = 'UIViewController-DisplayChild/**/*'
1818
s.exclude_files = 'UIViewController-DisplayChild/Info.plist'
1919
end

UIViewController-DisplayChild.xcodeproj/project.pbxproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@
104104
TargetAttributes = {
105105
3B0791D82088D3DE00A39104 = {
106106
CreatedOnToolsVersion = 9.3;
107-
LastSwiftMigration = 0930;
107+
LastSwiftMigration = 1020;
108108
};
109109
};
110110
};
@@ -291,7 +291,7 @@
291291
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
292292
SKIP_INSTALL = YES;
293293
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
294-
SWIFT_VERSION = 4.2;
294+
SWIFT_VERSION = 5.0;
295295
TARGETED_DEVICE_FAMILY = "1,2";
296296
};
297297
name = Debug;
@@ -319,7 +319,7 @@
319319
PRODUCT_BUNDLE_IDENTIFIER = com.inloopx.Vito;
320320
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
321321
SKIP_INSTALL = YES;
322-
SWIFT_VERSION = 4.2;
322+
SWIFT_VERSION = 5.0;
323323
TARGETED_DEVICE_FAMILY = "1,2";
324324
};
325325
name = Release;

UIViewController-DisplayChild/UIViewController+DisplayChild.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ public protocol Instantiable {
88
}
99

1010
public extension UIViewController {
11-
public typealias VoidClosure = () -> Void
11+
typealias VoidClosure = () -> Void
1212

1313
static let embedTransitionAnimationDuration = 0.25
1414

0 commit comments

Comments
 (0)