Skip to content

Commit e2fc0d1

Browse files
author
Erik McClure
committed
Fix windows setup artifacts
1 parent 9823d8f commit e2fc0d1

File tree

3 files changed

+18
-11
lines changed

3 files changed

+18
-11
lines changed

innative-runtime-setup/Product.wxs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<?error Unknown value for Platform variable ?>
1111
<?endif ?>
1212

13-
<?define Version="0.1.1" ?>
13+
<?define Version="0.1.3" ?>
1414
<Product
1515
Id="6A27F179-BADF-4580-821D-2892F229F335"
1616
Name="inNative Runtime v$(var.Version)"

innative-sdk-setup/Product.wxs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<?error Unknown value for Platform variable ?>
1111
<?endif ?>
1212

13-
<?define Version="0.1.1" ?>
13+
<?define Version="0.1.3" ?>
1414
<Product
1515
Id="25A4AE98-4F30-4735-B29B-37B6EDC5A9E9"
1616
Name="inNative SDK v$(var.Version)"
@@ -62,7 +62,7 @@
6262
<File Id="innative.cmd.d.exe" Name="innative-cmd-d.exe" Source="$(var.innative.TargetDir)innative-cmd-d.exe" Checksum="yes"/>
6363
<File Id="innative.loader.exe" Name="innative-loader.exe" Source="$(var.innative.TargetDir)innative-loader.exe" Checksum="yes"/>
6464
<File Id="innative.loader.d.exe" Name="innative-loader-d.exe" Source="$(var.innative.TargetDir)innative-loader-d.exe" Checksum="yes"/>
65-
<File Id="innative.test.s.exe" Name="innative-test-s.exe" Source="$(var.innative.TargetDir)innative-test-s.exe" Checksum="yes"/>
65+
<File Id="innative.test.exe" Name="innative-test.exe" Source="$(var.innative.TargetDir)innative-test.exe" Checksum="yes"/>
6666
<File Id="innative.d.dll" Name="innative-d.dll" Source="$(var.innative.TargetDir)innative-d.dll"/>
6767
<File Id="innative.d.exp" Name="innative-d.exp" Source="$(var.innative.TargetDir)innative-d.exp"/>
6868
<File Id="innative.d.lib" Name="innative-d.lib" Source="$(var.innative.TargetDir)innative-d.lib"/>
@@ -71,6 +71,8 @@
7171
<File Id="innative.env.d.pdb" Name="innative-env-d.pdb" Source="$(var.innative.TargetDir)innative-env-d.pdb"/>
7272
<File Id="innative.env.lib" Name="innative-env.lib" Source="$(var.innative.TargetDir)innative-env.lib"/>
7373
<File Id="innative.env.pdb" Name="innative-env.pdb" Source="$(var.innative.TargetDir)innative-env.pdb"/>
74+
<File Id="innative.test.embedding.lib" Name="innative-test-embedding.lib" Source="$(var.innative.TargetDir)innative-test-embedding.lib"/>
75+
<File Id="innative.test.embedding.d.lib" Name="innative-test-embedding-d.lib" Source="$(var.innative.TargetDir)innative-test-embedding-d.lib"/>
7476
<File Id="innative.s.d.lib" Name="innative-s-d.lib" Source="$(var.innative.TargetDir)innative-s-d.lib"/>
7577
<File Id="innative.s.d.pdb" Name="innative-s-d.pdb" Source="$(var.innative.TargetDir)innative-s-d.pdb"/>
7678
<File Id="innative.s.lib" Name="innative-s.lib" Source="$(var.innative.TargetDir)innative-s.lib"/>

innative-test/test_embedding.cpp

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ void TestHarness::test_embedding()
1717
auto fn = [this](const char* embed, size_t sz) {
1818
constexpr int i = 4;
1919
constexpr int j = 2;
20-
constexpr const char dll_path[] = "embedded.dll";
20+
path dll_path = temp_directory_path() / "embedded" IN_LIBRARY_EXTENSION;
2121
constexpr const char wasm_path[] = "../scripts/embedded.wat";
2222

2323
Environment* env = (*_exports.CreateEnvironment)(1, 0, 0);
@@ -37,19 +37,24 @@ void TestHarness::test_embedding()
3737
err = (*_exports.FinalizeEnvironment)(env);
3838
TEST(!err);
3939

40-
err = (*_exports.Compile)(env, dll_path);
40+
err = (*_exports.Compile)(env, dll_path.u8string().c_str());
4141
TEST(!err);
4242

4343
(*_exports.DestroyEnvironment)(env);
4444

45-
void* assembly = (*_exports.LoadAssembly)(dll_path);
46-
int (*test)(int, int) = (int (*)(int, int))(*_exports.LoadFunction)(assembly, "embedded", "test");
47-
TEST(test != nullptr);
45+
void* assembly = (*_exports.LoadAssembly)(dll_path.u8string().c_str());
46+
if(assembly)
47+
{
48+
int (*test)(int, int) = (int (*)(int, int))(*_exports.LoadFunction)(assembly, "embedded", "test");
49+
TEST(test != nullptr);
4850

49-
if(test)
50-
TEST((*test)(i, j) == 26);
51+
if(test)
52+
TEST((*test)(i, j) == 26);
5153

52-
(*_exports.FreeAssembly)(assembly);
54+
(*_exports.FreeAssembly)(assembly);
55+
}
56+
57+
remove(dll_path);
5358
};
5459

5560
fn(TEST_EMBEDDING, 0);

0 commit comments

Comments
 (0)