Add equals and hascode to DimensionKeyPair as well

Once again this is needed for proper testing

Author: Michael Kunze

build.gradle.kts

@@ -12,7 +12,7 @@ plugins {
 }
 
 group = "de.inoxio"
-version = "1.0.1"
+version = "1.0.2"
 description = "A java-spring library to push metrics to cloudwatch"
 
 apply {

src/main/java/de/inoxio/spring/cloudwatchmetrics/DimensionKeyPair.java

@@ -1,11 +1,13 @@
 package de.inoxio.spring.cloudwatchmetrics;
 
-public class DimensionKeyPair {
+import java.util.Objects;
+
+public final class DimensionKeyPair {
 
     private final String name;
     private final String value;
 
-    public DimensionKeyPair(final String name, final String value) {
+    private DimensionKeyPair(final String name, final String value) {
         this.name = name;
         this.value = value;
     }
@@ -18,6 +20,30 @@ public String getValue() {
         return value;
     }
 
+    @Override
+    public boolean equals(final Object o) {
+        if (this == o) {
+            return true;
+        }
+        if (o == null || getClass() != o.getClass()) {
+            return false;
+        }
+
+        final var that = (DimensionKeyPair) o;
+
+        return Objects.equals(name, that.name) && Objects.equals(value, that.value);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(name, value);
+    }
+
+    @Override
+    public String toString() {
+        return "DimensionKeyPair{" + "name='" + name + '\'' + ", value='" + value + '\'' + '}';
+    }
+
     public static final class DimensionKeyPairBuilder {
 
         private String name;

src/main/java/de/inoxio/spring/cloudwatchmetrics/MetricKeyPair.java

@@ -7,7 +7,7 @@ public final class MetricKeyPair {
     private final String name;
     private final double value;
 
-    public MetricKeyPair(final String name, final double value) {
+    private MetricKeyPair(final String name, final double value) {
         this.name = name;
         this.value = value;
     }

src/test/java/de/inoxio/spring/cloudwatchmetrics/DimensionKeyPairTest.java

@@ -0,0 +1,32 @@
+package de.inoxio.spring.cloudwatchmetrics;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.is;
+
+import static de.inoxio.spring.cloudwatchmetrics.DimensionKeyPair.DimensionKeyPairBuilder.dimensionKeyPairBuilder;
+
+import org.junit.Test;
+
+import nl.jqno.equalsverifier.EqualsVerifier;
+
+public class DimensionKeyPairTest {
+
+    @Test
+    public void shouldTestEqualsAndHashcode() {
+        EqualsVerifier.forClass(DimensionKeyPair.class).verify();
+    }
+
+    @Test
+    public void shouldConvertObjectToString() {
+
+        // given
+        final var dimensionKeyPair = dimensionKeyPairBuilder().name("name").value("value").build();
+
+        // when
+        final var toString = dimensionKeyPair.toString();
+
+        // then
+        assertThat(toString, is("DimensionKeyPair{name='name', value='value'}"));
+    }
+
+}