Review comments and fixes

Author: ChrisPaprocki

modules/peer_network_interface/config.default.toml

@@ -42,3 +42,5 @@ peer-sharing-timeout-secs = 10
 connect-timeout-secs = 15
 # Accept IPv6 peer addresses from peer-sharing (set true on dual-stack hosts)
 ipv6-enabled = false
+# Accept loopback/private/link-local peer addresses from peer-sharing (useful for local testnets)
+allow-non-public-peer-addrs = true

modules/peer_network_interface/src/block_flow_consensus_scenarios_tests.rs

@@ -115,6 +115,7 @@ async fn make_harness() -> TestHarness {
         peer_sharing_timeout_secs: 10,
         connect_timeout_secs: 15,
         ipv6_enabled: false,
+        allow_non_public_peer_addrs: true,
     };
 
     let flow = BlockFlowHandler::new(

modules/peer_network_interface/src/configuration.rs

@@ -42,6 +42,8 @@ pub struct InterfaceConfig {
     pub connect_timeout_secs: u64,
     #[serde(default = "default_ipv6_enabled")]
     pub ipv6_enabled: bool,
+    #[serde(default = "default_allow_non_public_peer_addrs")]
+    pub allow_non_public_peer_addrs: bool,
 }
 
 fn default_consensus_topic() -> String {
@@ -80,6 +82,10 @@ fn default_ipv6_enabled() -> bool {
     false
 }
 
+fn default_allow_non_public_peer_addrs() -> bool {
+    true
+}
+
 impl InterfaceConfig {
     pub fn try_load(config: &Config) -> Result<Self> {
         let full_config = Config::builder()