fix: add not active slot in overlay error

Author: golddydev

common/src/validation.rs

@@ -63,6 +63,10 @@ pub enum VrfValidationError {
     /// The pool lost the slot lottery
     #[error("VRF Leader Value Too Big")]
     VrfLeaderValueTooBig(#[from] VrfLeaderValueTooBigError),
+    /// **Cause:** This slot is in the overlay schedule but marked as non-active.
+    /// It's an intentional gap slot where no blocks should be produced.
+    #[error("Not Active slot in overlay schedule: {slot}")]
+    NotActiveSlotInOverlaySchedule { slot: Slot },
     /// **Cause:** Some data has incorrect bytes
     #[error("TryFromSlice: {0}")]
     TryFromSlice(String),

modules/block_vrf_validator/src/ouroboros/tpraos.rs

@@ -152,7 +152,11 @@ pub fn validate_vrf_tpraos<'a>(
         }
         Some(OBftSlot::NonActiveSlot) => {
             // This is a non-active slot; nobody may produce a block
-            Ok(vec![])
+            Ok(vec![Box::new(|| {
+                Err(VrfValidationError::NotActiveSlotInOverlaySchedule {
+                    slot: block_info.slot,
+                })
+            })])
         }
     }
 }