fix: add pool id to InvalidSignatureOcert error

Author: golddydev

common/src/validation.rs

@@ -295,8 +295,8 @@ pub enum OperationalCertificateError {
     MalformedSignatureOcert { reason: String },
     /// **Cause:** The cold key signature on the operational certificate is invalid.
     /// The OCert was not properly signed by the pool's cold key.
-    #[error("Invalid Signature OCert: Issuer={}", hex::encode(issuer))]
-    InvalidSignatureOcert { issuer: Vec<u8> },
+    #[error("Invalid Signature OCert: Issuer={}, Pool ID={}", hex::encode(issuer), hex::encode(pool_id))]
+    InvalidSignatureOcert { issuer: Vec<u8>, pool_id: PoolId, },
     /// **Cause:** The operational certificate counter in the header is not greater
     /// than the last counter used by this pool.
     #[error(

modules/block_kes_validator/src/ouroboros/kes_validation.rs

@@ -62,6 +62,7 @@ pub fn validate_kes_signature(
 
 pub fn validate_operational_certificate<'a>(
     certificate: OperationalCertificate<'a>,
+    pool_id: &PoolId,
     issuer: &ed25519::PublicKey,
     latest_sequence_number: u64,
     is_praos: bool,
@@ -103,6 +104,7 @@ pub fn validate_operational_certificate<'a>(
     if !issuer.verify(&message, &signature) {
         return Err(OperationalCertificateError::InvalidSignatureOcert {
             issuer: issuer.as_ref().to_vec(),
+            pool_id: *pool_id,
         });
     }
 
@@ -175,7 +177,13 @@ pub fn validate_block_kes<'a>(
                 Ok(())
             }),
             Box::new(move || {
-                validate_operational_certificate(cert, &issuer, latest_sequence_number, is_praos)?;
+                validate_operational_certificate(
+                    cert,
+                    &pool_id,
+                    &issuer,
+                    latest_sequence_number,
+                    is_praos,
+                )?;
                 Ok(())
             }),
         ],