Fix link_secret from/to value methods (#3)

Author: FabioPinheiro

src/data_types/link_secret.rs

@@ -83,6 +83,18 @@ impl TryFrom<&str> for LinkSecret {
 mod link_secret_tests {
     use super::*;
 
+    #[test]
+    fn should_serialize_and_deserialize_into_the_same_value() {
+        let link_secret = LinkSecret::new().expect("Error creating link secret");
+        let link_secret_srt: String = link_secret.try_into().expect("Error creating link secret");
+        println!("{}", link_secret_srt);
+        let link_secret2 =
+            LinkSecret::try_from(link_secret_srt.as_str()).expect("Error creating link secret");
+        let link_secret_srt2: String = link_secret2.try_into().expect("Error creating link secret");
+        // println!("{}", link_secret_srt2);
+        assert_eq!(link_secret_srt, link_secret_srt2);
+    }
+
     #[test]
     fn should_create_new_link_secret() {
         let link_secret = LinkSecret::new();

uniffi/src/anoncreds.udl

@@ -36,11 +36,11 @@ enum RegistryType {
 
 interface LinkSecret {
     constructor();
-    [Throws=AnoncredsError, Name=new_from_json]
-    constructor(string json_string);
+    [Throws=AnoncredsError, Name=new_from_value]
+    constructor(string value_string);
     string get_big_number();
     [Throws=AnoncredsError]
-    string get_json();
+    string get_value();
 };
 
 interface Nonce {

uniffi/src/types/link_secret.rs

@@ -1,5 +1,5 @@
 use crate::types::error::AnoncredsError;
-use anoncreds_core::data_types::link_secret::{LinkSecret as AnoncredsLinkSecret};
+use anoncreds_core::data_types::link_secret::LinkSecret as AnoncredsLinkSecret;
 use std::convert::TryFrom;
 use std::convert::TryInto;
 use std::sync::Arc;
@@ -14,54 +14,88 @@ impl LinkSecret {
         LinkSecret { secret: secret }
     }
 
-    pub fn new_from_json(json_string: String) -> Result<Self, AnoncredsError> {
-        let core_def = AnoncredsLinkSecret::try_from(json_string.as_str()).map_err(|_| AnoncredsError::ConversionError)?;
-        return Ok(LinkSecret { secret: core_def })
+    pub fn new_from_value(value_string: String) -> Result<Self, AnoncredsError> {
+        let core_def = AnoncredsLinkSecret::try_from(value_string.as_str())
+            .map_err(|_| AnoncredsError::ConversionError)?;
+        return Ok(LinkSecret { secret: core_def });
     }
 
     pub fn get_big_number(&self) -> String {
         let clone = self.clone();
         clone.into()
     }
 
-    pub fn get_json(&self) -> Result<String, AnoncredsError> {
+    pub fn get_value(&self) -> Result<String, AnoncredsError> {
         let clone = self.clone();
-        return Ok(clone.into())
+        return Ok(clone.into());
     }
 }
 
 impl From<AnoncredsLinkSecret> for LinkSecret {
-
     fn from(acr: AnoncredsLinkSecret) -> Self {
-        return LinkSecret { secret: acr }
+        return LinkSecret { secret: acr };
     }
 }
 
 impl TryFrom<&str> for LinkSecret {
     type Error = AnoncredsError;
 
     fn try_from(string: &str) -> Result<Self, Self::Error> {
-        let acr = AnoncredsLinkSecret::try_from(string).map_err(|_| AnoncredsError::ConversionError)?;
-        return Ok(LinkSecret { secret: acr })
+        let acr =
+            AnoncredsLinkSecret::try_from(string).map_err(|_| AnoncredsError::ConversionError)?;
+        return Ok(LinkSecret { secret: acr });
     }
 }
 
 impl TryFrom<&LinkSecret> for AnoncredsLinkSecret {
     type Error = AnoncredsError;
 
     fn try_from(acr: &LinkSecret) -> Result<Self, Self::Error> {
-        acr.secret.try_clone().map_err(|_| AnoncredsError::ConversionError)
-    } 
+        acr.secret
+            .try_clone()
+            .map_err(|_| AnoncredsError::ConversionError)
+    }
 }
 
 impl Into<String> for LinkSecret {
     fn into(self) -> String {
-        self.secret.0.to_hex().unwrap()
-    } 
+        self.secret.0.to_dec().unwrap()
+    }
 }
 
 impl Clone for LinkSecret {
     fn clone(&self) -> Self {
-        LinkSecret { secret: self.secret.try_clone().unwrap() }
+        LinkSecret {
+            secret: self.secret.try_clone().unwrap(),
+        }
+    }
+}
+
+#[cfg(test)]
+mod warp_link_secret_tests {
+    use super::*;
+
+    #[test]
+    fn should_serialize_and_deserialize_AnoncredsLinkSecret_into_the_same_value() {
+        let link_secret = AnoncredsLinkSecret::new().expect("Error creating link secret");
+        let link_secret_srt: String = link_secret.try_into().expect("Error creating link secret");
+        // println!("{}", link_secret_srt);
+        let link_secret2 = AnoncredsLinkSecret::try_from(link_secret_srt.as_str())
+            .expect("Error creating link secret");
+        let link_secret_srt2: String = link_secret2.try_into().expect("Error creating link secret");
+        // println!("{}", link_secret_srt2);
+        assert_eq!(link_secret_srt, link_secret_srt2);
     }
-}
+
+    #[test]
+    fn should_serialize_and_deserialize_LinkSecret_into_the_same_value() {
+        let link_secret = LinkSecret::new();
+        let link_secret_srt: String = link_secret.try_into().expect("Error creating link secret");
+        println!("{}", link_secret_srt);
+        let link_secret2 =
+            LinkSecret::try_from(link_secret_srt.as_str()).expect("Error creating link secret");
+        let link_secret_srt2: String = link_secret2.try_into().expect("Error creating link secret");
+        println!("{}", link_secret_srt2);
+        assert_eq!(link_secret_srt, link_secret_srt2);
+    }
+}