Review feedback

Author: Jimbo4350

docs/ADR-10-cardano-api-script-witness-api.md

@@ -73,15 +73,6 @@ data Witnessable thing era where
     => Voter -> Witnessable Voter era
   WitProposal :: L.ConwayEraScript era => Proposal -> Witnessable Proposal era
 
-instance Ord (Witnessable thing era) where
-  compare a b =
-    case (a, b) of
-      (WitTxIn txinA, WitTxIn txinB) -> compare txinA txinB
-      (WitTxCert{}, WitTxCert{}) -> LT -- Certificates in the ledger are in an `OSet` therefore we preserve the order.
-      (WitMint mintA, WitMint mintB) -> compare mintA mintB
-      (WitWithdrawal (stakeAddrA, _), WitWithdrawal (stakeAddrB, _)) -> compare stakeAddrA stakeAddrB
-      (WitVote voterA, WitVote voterB) -> compare voterA voterB
-      (WitProposal propA, WitProposal propB) -> compare propA propB
 
 type Mint = (PolicyId, AssetName, Quantity)
 
@@ -174,7 +165,18 @@ createIndexedPlutusScriptWitnesses witnessableThings =
   | (index, (thing, AnyPlutusScriptWitness sWit)) <- zip [0 ..] $ enforceOrdering witnessableThings
   ]
  where
-  enforceOrdering = List.sortBy (compare `on` fst)
+  enforceOrdering = List.sortBy (compareWitnesses `on` fst)
+
+compareWitnesses :: Witnessable thing era -> Witnessable thing era -> Ordering
+compareWitnesses a b =
+  case (a, b) of
+    (WitTxIn txinA, WitTxIn txinB) -> compare txinA txinB
+    (WitTxCert{}, WitTxCert{}) -> LT -- Certificates in the ledger are in an `OSet` therefore we preserve the order.
+    (WitMint mintA, WitMint mintB) -> compare mintA mintB
+    (WitWithdrawal (stakeAddrA, _), WitWithdrawal (stakeAddrB, _)) -> compare stakeAddrA stakeAddrB
+    (WitVote voterA, WitVote voterB) -> compare voterA voterB
+    (WitProposal propA, WitProposal propB) -> compare propA propB
+
 ```
 
 ## New `PlutusScriptInEra` type