Skip to content

Commit 947af90

Browse files
authored
Merge pull request #80 from input-output-hk/mgalazyn/reject-adr06
Reject ADR-006: we will keep using optparse-applicative-fork
2 parents 57dc5b7 + 52263d6 commit 947af90

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

docs/ADR-006-Using-optparse-applicative-main-repository.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
# Status
22

3-
📜 Proposed 2024-09-19
3+
❌ Rejected 2025-11-06
44

55
# Context
66

77
In 2021, we (the API and CLI team) wanted to improve the pretty printing of `optparse-applicative`,
88
so that it aligns most flags vertically. E.g. we wanted this behavior:
99

1010
```
11-
Usage: cardano-cli transaction build-raw
11+
Usage: cardano-cli transaction build-raw
1212
[ --byron-era
1313
| --shelley-era
1414
| --allegra-era
@@ -54,9 +54,14 @@ We want to get rid of our fork of `optparse-applicative`. Luckily, ideas from ou
5454

5555
We did [a PR](https://github.com/pcapriotti/optparse-applicative/pull/494) to `optparse-applicative` with the tweak we need. This PR is way smaller than our PR from 2021 and so we are hopeful it will be accepted.
5656

57+
## Update 2025-11-05
58+
59+
After [our PR to `optparse-applicative`](https://github.com/pcapriotti/optparse-applicative/pull/494) got merged, [`cardano-cli`'s PR](https://github.com/IntersectMBO/cardano-cli/pull/899) got revisited.
60+
The changes in the rendered help are still detrimental to the help text readability, therefore the PR was closed, and the attempt to abandon the fork postponed.
61+
5762
# Consequences
5863

59-
We have `cardano-cli` depend on [pcapriotti/optparse-applicative](https://github.com/pcapriotti/optparse-applicative) instead of [input-output-hk/optparse-applicative](https://github.com/input-output-hk/optparse-applicative), when [our PR](https://github.com/pcapriotti/optparse-applicative/pull/494) to `optparse-applicative` is merged and released.
64+
~~We have `cardano-cli` depend on [pcapriotti/optparse-applicative](https://github.com/pcapriotti/optparse-applicative) instead of [input-output-hk/optparse-applicative](https://github.com/input-output-hk/optparse-applicative), when [our PR](https://github.com/pcapriotti/optparse-applicative/pull/494) to `optparse-applicative` is merged and released.~~
6065

6166
# References
6267

0 commit comments

Comments
 (0)