addressing review remarks

Author: dkijania

src/vit-testing/mainnet-lib/src/cardano_node/in_memory.rs

@@ -91,7 +91,11 @@ impl InMemoryNode {
         let handle = tokio::spawn(async move {
             loop {
                 tokio::time::sleep(Duration::from_secs(u64::from(slot_duration))).await;
-                let block = ledger.write().unwrap().mint_block();
+                let block = ledger
+                    .write()
+                    .unwrap()
+                    .mint_block()
+                    .expect("leadership event failed");
                 block_notifier.notify(block).await.unwrap();
             }
         });

src/vit-testing/mainnet-lib/src/cardano_node/ledger.rs

@@ -45,14 +45,24 @@ impl Ledger {
     }
 
     /// Mint new block
-    pub fn mint_block(&mut self) -> Block {
-        let last_block = self
-            .blocks
-            .last()
-            .expect("internal error no block0 in blockchain");
+    ///
+    /// # Errors
+    ///
+    /// On blockchain inconsistency
+    pub fn mint_block(&mut self) -> Result<Block, Error> {
+        let last_block = self.blocks.last().ok_or(Error::MissingBlock0)?;
         let next_block = BlockBuilder::next_block(Some(last_block), &self.mempool);
         self.blocks.push(next_block.clone());
         self.mempool.clear();
-        next_block
+        Ok(next_block)
     }
 }
+
+#[derive(thiserror::Error, Debug, Clone)]
+pub enum Error {
+    #[error("no block0 in blockchain")]
+    MissingBlock0,
+}
+
+unsafe impl Send for Error {}
+unsafe impl Send for Ledger {}

src/vit-testing/mainnet-lib/src/cardano_node/settings.rs

@@ -1,3 +1,4 @@
+use crate::CARDANO_MAINNET_SLOTS_PER_EPOCH;
 use chain_impl_mockchain::testing::TestGen;
 use std::time::SystemTime;
 
@@ -11,7 +12,7 @@ pub struct Settings {
     /// slot duration
     pub slot_duration: u32,
     /// slots per epoch
-    pub slots_per_epoch: u32,
+    pub slots_per_epoch: u64,
 }
 
 impl Default for Settings {
@@ -20,7 +21,7 @@ impl Default for Settings {
             block0_hash: TestGen::hash().to_string(),
             block0_time: SystemTime::now(),
             slot_duration: 1,
-            slots_per_epoch: 43200,
+            slots_per_epoch: CARDANO_MAINNET_SLOTS_PER_EPOCH,
         }
     }
 }

src/vit-testing/mainnet-lib/src/db_sync/in_memory.rs

@@ -1,4 +1,4 @@
-use crate::{Block0, InMemoryNode};
+use crate::{Block0, InMemoryNode, CARDANO_MAINNET_SLOTS_PER_EPOCH};
 use cardano_serialization_lib::metadata::GeneralTransactionMetadata;
 use cardano_serialization_lib::utils::BigNum;
 use cardano_serialization_lib::{Block, Transaction, TransactionWitnessSet};
@@ -15,8 +15,6 @@ use std::path::Path;
 use std::sync::{Arc, RwLock};
 use tokio::task::JoinHandle;
 
-const CARDANO_MAINNET_SLOTS_PER_EPOCH: u64 = 43200;
-
 pub type BlockNo = u32;
 pub type Address = String;
 
@@ -52,7 +50,6 @@ impl Debug for InMemoryDbSync {
 }
 
 impl InMemoryDbSync {
-
     /// Creates new instance out of block0
     #[must_use]
     pub fn from_block0(block0: &Block0) -> Self {
@@ -135,16 +132,15 @@ impl InMemoryDbSync {
 
     /// Query transaction by it's hash representation
     #[must_use]
-    pub fn transaction_by_hash(&self, hash: &str) -> Vec<(&Block, &Transaction)> {
+    pub fn transaction_by_hash(&self, hash: &str) -> Vec<(Option<&Block>, &Transaction)> {
         self.transactions
             .iter()
             .filter_map(|(block, txs)| {
                 if let Some(tx) = txs.iter().find(|tx| tx.to_hex() == hash) {
                     let block = self
                         .blocks
                         .iter()
-                        .find(|x| x.header().header_body().block_number() == *block)
-                        .expect("data inconsitency. cannot find block with block no from tx");
+                        .find(|x| x.header().header_body().block_number() == *block);
 
                     return Some((block, tx));
                 }

src/vit-testing/mainnet-lib/src/lib.rs

@@ -20,6 +20,9 @@ mod db_sync;
 mod network;
 mod wallet;
 
+/// Const defining caradno mainnet slot per epoch setting
+pub const CARDANO_MAINNET_SLOTS_PER_EPOCH: u64 = 43200;
+
 pub use exports::*;
 mod exports {
     pub use crate::blockfrost::{CatalystBlockFrostApi, Error as CatalystBlockFrostApiError};

src/vit-testing/mainnet-lib/src/network/mod.rs

@@ -71,7 +71,7 @@ impl MainnetNetworkBuilder {
     pub fn build_shared(self) -> (SharedInMemoryDbSync, InMemoryNode, HashSet<Identifier>) {
         let (db_sync, ledger, reps) = self.build();
         let mut node = InMemoryNode::start_from_ledger(ledger);
-        (db_sync.connect_to_node(&mut node),node, reps)
+        (db_sync.connect_to_node(&mut node), node, reps)
     }
 }