fix build

Author: oldGreg5

src/catalyst-toolbox/catalyst-toolbox/src/rewards/veterans.rs

@@ -233,7 +233,7 @@ mod tests {
                 .zip(REPUTATION_DISAGREEMENT_MODIFIERS)
                 .collect(),
         );
-        assert!(results.get(VCA_1).is_none());
+        assert!(!results.contains_key(VCA_1));
         let res = results.get(VCA_2).unwrap();
         assert_eq!(res.reputation, 2);
         assert_eq!(res.rewards, total_rewards);

src/catalyst-toolbox/catalyst-toolbox/src/rewards/voters.rs

@@ -291,7 +291,7 @@ mod tests {
 
         for (_, voting_key) in inactive_voters_keys {
             for contrib in snapshot.contributions_for_voting_key(voting_key.clone()) {
-                assert!(all_rewards.get(&contrib.reward_address).is_none());
+                assert!(!all_rewards.contains_key(&contrib.reward_address));
             }
         }
     }

src/chain-libs/cardano-legacy-address/src/base58.rs

@@ -105,7 +105,6 @@ fn base_decode(alphabet_s: &str, input: &[u8]) -> Result<Vec<u8>> {
 //pub fn decode_bytes(input: &[u8]) -> Result<Vec<u8>> {
 //    base_decode(ALPHABET, input)
 //}
-
 #[cfg(test)]
 mod tests {
     fn encode(input: &[u8], expected: &str) {

src/chain-libs/chain-impl-mockchain/src/accounting/account/last_rewards.rs

@@ -100,11 +100,11 @@ mod tests {
     #[test]
     #[should_panic]
     pub fn add_for_value_overflow() {
-        let value_to_add = Value(std::u64::MAX);
+        let value_to_add = Value(u64::MAX);
         let epoch = 0;
         let mut last_rewards = LastRewards {
             epoch: 0,
-            reward: Value(std::u64::MAX),
+            reward: Value(u64::MAX),
         };
         last_rewards.add_for(epoch, value_to_add);
     }

src/chain-libs/chain-impl-mockchain/src/lib.rs

@@ -1,4 +1,3 @@
-#![warn(clippy::all)]
 #![allow(clippy::derive_partial_eq_without_eq)]
 #![allow(clippy::result_large_err)]
 

src/chain-libs/chain-impl-mockchain/src/multisig/witness.rs

@@ -143,7 +143,6 @@ impl WitnessBuilder {
 }
 
 /// Verify that the declaration and the witnesses in parameters fulfill the requirements:
-///
 /// * The threshold is met: there's at least T or more witnesses available
 /// * the witnesses and declaration together can re-create
 pub fn verify_identifier_threshold(

src/chain-libs/chain-impl-mockchain/src/rewards.rs

@@ -150,7 +150,7 @@ impl Parameters {
             initial_value: 0,
             compounding_ratio: Ratio::zero(),
             compounding_type: CompoundingType::Linear,
-            epoch_rate: NonZeroU32::new(u32::max_value()).unwrap(),
+            epoch_rate: NonZeroU32::new(u32::MAX).unwrap(),
             epoch_start: 0,
             reward_drawing_limit_max: Limit::None,
             pool_participation_capping: None,

src/chain-libs/chain-impl-mockchain/src/transaction/witness.rs

@@ -143,7 +143,6 @@ impl AsRef<[u8]> for WitnessMultisigData {
 
 impl Witness {
     /// Creates new `Witness` value.
-
     pub fn new_utxo_data(
         block0: &HeaderId,
         sign_data_hash: &TransactionSignDataHash,

src/chain-libs/chain-impl-mockchain/src/value.rs

@@ -27,11 +27,11 @@ impl Value {
         Value(0)
     }
 
-    pub fn sum<I>(values: I) -> Result<Self, ValueError>
+    pub fn sum<I>(mut values: I) -> Result<Self, ValueError>
     where
         I: Iterator<Item = Self>,
     {
-        values.fold(Ok(Value::zero()), |acc, v| acc? + v)
+        values.try_fold(Value::zero(), |acc, v| acc + v)
     }
 
     #[inline]

src/chain-libs/chain-impl-mockchain/src/vote/manager.rs

@@ -1290,7 +1290,6 @@ mod tests {
 
     #[test]
     #[cfg(not(feature = "audit"))]
-
     pub fn vote_plan_manager_tally_invalid_date_private() {
         let (
             members,