pr comments

Author: cong-or

src/jormungandr/jormungandr/src/settings/start/mod.rs

@@ -287,8 +287,6 @@ fn generate_network(
         .transpose()?
         .unwrap_or_default();
 
-    // TODO: do we want to check that we end up with a valid address?
-    // Is it possible for a node to specify no public address?
     let config_addr = p2p.connection.public_address;
     let public_address = command_arguments
         .public_address

src/jormungandr/testing/jormungandr-integration-tests/src/networking/p2p/public_traffic.rs

@@ -121,8 +121,6 @@ pub fn test_public_node_cannot_publish() {
         .build()
         .unwrap();
 
-    //
-    //
     // Get addresses of nodes for whitelisting
     let internal_node_addr = network_controller
         .node_config(INTERNAL_NODE)
@@ -149,8 +147,6 @@ pub fn test_public_node_cannot_publish() {
 
     println!("whitelist {:?}", whitelist);
 
-    //
-    //
     // add whitelists to nodes config
     let mut internal_node_config = network_controller.node_config(INTERNAL_NODE).unwrap();
 
@@ -168,8 +164,6 @@ pub fn test_public_node_cannot_publish() {
 
     public_node_config.p2p.connection.whitelist = Some(whitelist.clone());
 
-    //
-    //
     // spin up internal nodes
     let params = SpawnParams::new(INTERNAL_NODE)
         .gossip_interval(Duration::new(1, 0))
@@ -189,8 +183,6 @@ pub fn test_public_node_cannot_publish() {
 
     let _client_internal_2 = network_controller.spawn(params).unwrap();
 
-    //
-    //
     // node from internal network exposed to public
 
     let params = SpawnParams::new(GATEWAY)
@@ -202,8 +194,6 @@ pub fn test_public_node_cannot_publish() {
 
     let _gateway = network_controller.spawn(params).unwrap();
 
-    //
-    //
     // simulate node in the wild
     let address: Multiaddr = "/ip4/80.9.12.3/tcp/0".parse().unwrap();
 
@@ -217,8 +207,6 @@ pub fn test_public_node_cannot_publish() {
 
     let _client_public = network_controller.spawn(params).unwrap();
 
-    //
-    //
     // public node sends fragments to network
     // it should fail as they public node is not whitelisted
     let mut alice = network_controller.controlled_wallet(ALICE).unwrap();
@@ -268,8 +256,6 @@ pub fn test_public_node_synced_with_internal() {
         .build()
         .unwrap();
 
-    //
-    //
     // Get addresses of nodes for whitelisting
     let internal_node_addr = network_controller
         .node_config(INTERNAL_NODE)
@@ -296,8 +282,6 @@ pub fn test_public_node_synced_with_internal() {
 
     println!("whitelist {:?}", whitelist);
 
-    //
-    //
     // add whitelists to nodes config
     let mut internal_node_config = network_controller.node_config(INTERNAL_NODE).unwrap();
 
@@ -315,8 +299,6 @@ pub fn test_public_node_synced_with_internal() {
 
     public_node_config.p2p.connection.whitelist = Some(whitelist.clone());
 
-    //
-    //
     // spin up internal nodes
     let params = SpawnParams::new(INTERNAL_NODE)
         .gossip_interval(Duration::new(1, 0))
@@ -336,8 +318,6 @@ pub fn test_public_node_synced_with_internal() {
 
     let _client_internal_2 = network_controller.spawn(params).unwrap();
 
-    //
-    //
     // node from internal network exposed to public
 
     let params = SpawnParams::new(GATEWAY)
@@ -349,8 +329,6 @@ pub fn test_public_node_synced_with_internal() {
 
     let _gateway = network_controller.spawn(params).unwrap();
 
-    //
-    //
     // simulate node in the wild
     let address: Multiaddr = "/ip4/80.9.12.3/tcp/0".parse().unwrap();
 
@@ -364,8 +342,6 @@ pub fn test_public_node_synced_with_internal() {
 
     let _client_public = network_controller.spawn(params).unwrap();
 
-    //
-    //
     // internal node sends fragments to network
     // fragments should be propagated to the publish node (which can consume but not publish)
     let mut alice = network_controller.controlled_wallet(ALICE).unwrap();
@@ -386,8 +362,6 @@ pub fn test_public_node_synced_with_internal() {
 
     utils::wait(10);
 
-    //
-    //
     // account states should be the same
 
     let public_state_a = _client_internal_2