clippy issues

Author: cameron1024

src/catalyst-toolbox/catalyst-toolbox/src/bin/cli/kedqr/decode/img.rs

@@ -11,7 +11,7 @@ use std::path::Path;
 use std::path::PathBuf;
 
 pub fn save_secret_from_qr(qr: PathBuf, output: Option<PathBuf>, pin: QrPin) -> Result<(), Report> {
-    let sk = secret_from_qr(&qr, pin)?;
+    let sk = secret_from_qr(qr, pin)?;
     let hrp = Ed25519Extended::SECRET_BECH32_HRP;
     let secret_key = bech32::encode(hrp, sk.leak_secret().to_base32(), Variant::Bech32)?;
 

src/catalyst-toolbox/catalyst-toolbox/src/bin/cli/kedqr/encode/img.rs

@@ -15,7 +15,7 @@ pub fn generate_qr(input: PathBuf, output: Option<PathBuf>, pin: QrPin) -> Resul
         .read(true)
         .write(false)
         .append(false)
-        .open(&input)
+        .open(input)
         .expect("Could not open input file.");
 
     let mut reader = BufReader::new(key_file);

src/catalyst-toolbox/catalyst-toolbox/src/bin/cli/kedqr/encode/payload.rs

@@ -18,7 +18,7 @@ pub fn generate_payload(input: PathBuf, output: Option<PathBuf>, pin: QrPin) ->
         .read(true)
         .write(false)
         .append(false)
-        .open(&input)
+        .open(input)
         .expect("Could not open input file.");
 
     let mut reader = BufReader::new(key_file);

src/catalyst-toolbox/catalyst-toolbox/src/bin/cli/stats/snapshot.rs

@@ -25,7 +25,7 @@ pub enum Command {
 
 impl SnapshotCommand {
     pub fn exec(&self) -> Result<(), Report> {
-        let initials: Vec<Initial> = read_initials(&jortestkit::file::read_file(&self.snapshot)?)?;
+        let initials: Vec<Initial> = read_initials(jortestkit::file::read_file(&self.snapshot)?)?;
 
         match self.command {
             Command::Count => calculate_wallet_distribution_from_initials(

src/catalyst-toolbox/snapshot-lib/src/registration.rs

@@ -173,7 +173,7 @@ mod serde_impl {
         use bech32::ToBase32;
         let bytes = hex::decode(String::deserialize(deserializer)?.trim_start_matches("0x"))
             .map_err(|e| D::Error::custom(format!("invalid hex string: {}", e)))?;
-        bech32::encode("stake", &bytes.to_base32(), bech32::Variant::Bech32)
+        bech32::encode("stake", bytes.to_base32(), bech32::Variant::Bech32)
             .map_err(|e| D::Error::custom(format!("bech32 encoding failed: {}", e)))
     }
 }
@@ -237,7 +237,7 @@ mod tests {
                 .prop_map(|((stake_key, rewards_addr, delegations), vp)| {
                     let stake_public_key = hex::encode(stake_key);
                     let reward_address =
-                        bech32::encode("stake", &rewards_addr.to_base32(), bech32::Variant::Bech32)
+                        bech32::encode("stake", rewards_addr.to_base32(), bech32::Variant::Bech32)
                             .unwrap();
                     let voting_power: Value = vp.into();
                     VotingRegistration {

src/chain-libs/chain-impl-mockchain/src/accounting/account/last_rewards.rs

@@ -15,18 +15,20 @@ pub struct LastRewards {
     pub reward: Value,
 }
 
-impl LastRewards {
+impl Default for LastRewards {
     /// Create an initial value of epoch=0 reward=0
     ///
     /// It is also safe as the "uninitialized" value, since
     /// epoch 0 doesn't have by construction any reward associated.
-    pub fn default() -> Self {
+    fn default() -> Self {
         LastRewards {
             epoch: 0,
             reward: Value::zero(),
         }
     }
+}
 
+impl LastRewards {
     /// Add some value to the last reward, if the epoch is the same, then the
     /// result is just added, however.account
     ///

src/chain-libs/chain-impl-mockchain/src/certificate/pool.rs

@@ -764,7 +764,7 @@ mod tests {
         let mut sigs = Vec::new();
         for (i, key) in pool_owner_with_sign.indexed_signatories_sks() {
             let sig = SingleAccountBindingSignature::new(&auth_data, |d| key.sign_slice(d.0));
-            sigs.push((i as u8, sig))
+            sigs.push((i, sig))
         }
         let pool_owner_signed = PoolOwnersSigned { signatures: sigs };
         let verification = if should_pass {

src/chain-libs/chain-impl-mockchain/src/header/test.rs

@@ -63,8 +63,8 @@ impl Arbitrary for GenesisPraosProof {
         let node_id = Arbitrary::arbitrary(g);
 
         let vrf_proof = {
-            let sk = RistrettoGroup2HashDh::generate(&mut tcg.get_rng(0));
-            RistrettoGroup2HashDh::evaluate_and_prove(&sk, &[0, 1, 2, 3], &mut tcg.get_rng(1))
+            let sk = RistrettoGroup2HashDh::generate(tcg.get_rng(0));
+            RistrettoGroup2HashDh::evaluate_and_prove(&sk, &[0, 1, 2, 3], tcg.get_rng(1))
         };
 
         let kes_proof = {

src/chain-libs/chain-impl-mockchain/src/key.rs

@@ -428,8 +428,8 @@ mod tests {
             }
 
             let tcg = testing::TestCryptoGen::arbitrary(g);
-            let mut rng = tcg.get_rng(0);
-            let vrf_sk: SecretKey<RistrettoGroup2HashDh> = SecretKey::generate(&mut rng);
+            let rng = tcg.get_rng(0);
+            let vrf_sk: SecretKey<RistrettoGroup2HashDh> = SecretKey::generate(rng);
             GenesisPraosLeader {
                 vrf_public_key: vrf_sk.to_public(),
                 kes_public_key: PK_KES.clone(),

src/chain-libs/chain-impl-mockchain/src/leadership/bft.rs

@@ -36,7 +36,7 @@ impl LeadershipData {
     #[inline]
     fn offset(&self, block_number: u64) -> BftRoundRobinIndex {
         let max = self.number_of_leaders() as u64;
-        BftRoundRobinIndex((block_number % max) as u64)
+        BftRoundRobinIndex(block_number % max)
     }
 
     pub(crate) fn verify(&self, block_header: &Header) -> Verification {