Skip to content

Conversation

kukkok3
Copy link
Contributor

@kukkok3 kukkok3 commented Jan 16, 2025

Description

Fixes input-output-hk/catalyst-voices#1525

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration: if applicable

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

List of new dependencies: if applicable

Provide a list of newly added dependencies in this PR, with the description of what are they doing and why do we need them.

  • Crate A: description
  • Crate B: description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kukkok3 kukkok3 self-assigned this Jan 16, 2025
@kukkok3 kukkok3 changed the title chore: migrate-ci-to-forge chore: Migrate-ci-to-forge | NPG-000 Jan 17, 2025
@kukkok3 kukkok3 requested a review from coire1 January 17, 2025 09:51
@kukkok3 kukkok3 marked this pull request as ready for review January 17, 2025 09:57
@kukkok3 kukkok3 enabled auto-merge (squash) January 17, 2025 09:58
Copy link
Collaborator

@coire1 coire1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Poetry version will be bumped in a subsequent PR

@kukkok3 kukkok3 merged commit 3c1c8cd into main Jan 17, 2025
35 of 37 checks passed
@kukkok3 kukkok3 deleted the chore/migrate-ci-to-forge branch January 17, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Migrate catalyst-core to forge
2 participants