update decoding test

Author: Mr-Leshiy

rust/catalyst-voting/src/txs/v1/decoding.rs

@@ -265,14 +265,70 @@ mod tests {
     }
 
     #[proptest]
-    #[allow(clippy::indexing_slicing)]
     fn tx_to_bytes_from_bytes_test(t1: Tx) {
         let bytes = t1.to_bytes();
 
-        // verify correctness serializing tx size field
-        let size = u32::from_be_bytes(bytes[0..4].try_into().unwrap());
+        let mut reader = bytes.as_slice();
+
+        let size = read_be_u32(&mut reader).unwrap();
         assert_eq!(size as usize, bytes.len() - 4);
 
+        let padding_tag = read_be_u8(&mut reader).unwrap();
+        assert_eq!(padding_tag, PADDING_TAG);
+
+        let fragment_tag = read_be_u8(&mut reader).unwrap();
+        assert_eq!(fragment_tag, FRAGMENT_TAG);
+
+        let vote_plan_id = read_array(&mut reader).unwrap();
+        assert_eq!(vote_plan_id, t1.vote_plan_id);
+
+        let proposal_index = read_be_u8(&mut reader).unwrap();
+        assert_eq!(proposal_index, t1.proposal_index);
+
+        let vote_tag = read_be_u8(&mut reader).unwrap();
+        assert!(vote_tag == PUBLIC_VOTE_TAG || vote_tag == PRIVATE_VOTE_TAG);
+        match vote_tag {
+            PUBLIC_VOTE_TAG => {
+                let vote = read_be_u8(&mut reader).unwrap();
+                assert_eq!(VotePayload::Public(vote), t1.vote);
+            },
+            PRIVATE_VOTE_TAG => {
+                let size = read_be_u8(&mut reader).unwrap();
+                let vote = EncryptedVote::from_bytes(&mut reader, size.into()).unwrap();
+                let size = read_be_u8(&mut reader).unwrap();
+                let proof = VoterProof::from_bytes(&mut reader, size.into()).unwrap();
+                assert_eq!(VotePayload::Private(vote, proof), t1.vote);
+            },
+            _ => {},
+        }
+
+        let block_date = read_be_u64(&mut reader).unwrap();
+        assert_eq!(block_date, 0);
+
+        let inputs_amount = read_be_u8(&mut reader).unwrap();
+        assert_eq!(inputs_amount, NUMBER_OF_INPUTS);
+
+        let outputs_amount = read_be_u8(&mut reader).unwrap();
+        assert_eq!(outputs_amount, NUMBER_OF_OUTPUTS);
+
+        let input_tag = read_be_u8(&mut reader).unwrap();
+        assert_eq!(input_tag, INPUT_TAG);
+
+        let value = read_be_u64(&mut reader).unwrap();
+        assert_eq!(value, 0);
+
+        let public_key = read_array(&mut reader).unwrap();
+        assert_eq!(PublicKey::from_bytes(&public_key).unwrap(), t1.public_key);
+
+        let witness_tag = read_be_u8(&mut reader).unwrap();
+        assert_eq!(witness_tag, WITNESS_TAG);
+
+        let nonce = read_be_u32(&mut reader).unwrap();
+        assert_eq!(nonce, 0);
+
+        let signature = read_array(&mut reader).unwrap();
+        assert_eq!(Signature::from_bytes(&signature), t1.signature);
+
         let t2 = Tx::from_bytes(&mut bytes.as_slice()).unwrap();
         assert_eq!(t1, t2);
     }

rust/catalyst-voting/src/txs/v1/mod.rs

@@ -24,6 +24,7 @@
 //!     &users_private_key,
 //! )
 //! .unwrap();
+//! public_tx.verify_signature().unwrap();
 //!
 //! let private_tx = Tx::new_private_with_default_rng(
 //!     vote_plan_id,
@@ -34,6 +35,8 @@
 //!     &users_private_key,
 //! )
 //! .unwrap();
+//! private_tx.verify_signature().unwrap();
+//! private_tx.verify_proof(&election_public_key).unwrap();
 //! ```
 
 mod decoding;