fix(cardano-blockchain-types): remove validation from cip36 struct

Signed-off-by: bkioshn <[email protected]>

Author: bkioshn

rust/cardano-blockchain-types/src/metadata/cip36/mod.rs

@@ -11,7 +11,7 @@ use key_registration::Cip36KeyRegistration;
 use minicbor::{Decode, Decoder};
 use pallas::ledger::addresses::ShelleyAddress;
 use registration_witness::Cip36RegistrationWitness;
-use validation::{validate_cip36, Cip36Validation};
+use validation::validate_cip36;
 use voting_pk::VotingPubKey;
 
 use crate::{MetadatumLabel, MultiEraBlock, TxnIndex};
@@ -25,9 +25,6 @@ pub struct Cip36 {
     registration_witness: Cip36RegistrationWitness,
     /// Is this a Catalyst strict registration?
     is_catalyst_strict: bool,
-    /// CIP36 validation.
-    #[allow(dead_code)]
-    validation: Cip36Validation,
 }
 
 impl Cip36 {
@@ -101,14 +98,13 @@ impl Cip36 {
             key_registration,
             registration_witness,
             is_catalyst_strict,
-            validation,
         };
 
         if validation_report.is_empty() {
             Ok(cip36)
         } else {
             // If there are validation errors, the CIP36 is invalid
-            bail!("CIP-36 validation failed: {cip36:?}, Reports: {validation_report:?}")
+            bail!("CIP-36 validation failed: {cip36:?}, Validation: {validation:?}, Reports: {validation_report:?}")
         }
     }
 
@@ -172,10 +168,4 @@ impl Cip36 {
     pub fn is_strict_catalyst(&self) -> bool {
         self.is_catalyst_strict
     }
-
-    /// Get the CIP-36 validation.
-    #[must_use]
-    pub fn validation(&self) -> &Cip36Validation {
-        &self.validation
-    }
 }

rust/cardano-blockchain-types/src/metadata/cip36/validation.rs

@@ -15,7 +15,8 @@ pub const SIGNDATA_PREAMBLE: [u8; 4] = [0xA1, 0x19, 0xEF, 0x64];
 /// Validation value for CIP-36.
 #[allow(clippy::struct_excessive_bools, clippy::module_name_repetitions)]
 #[derive(Clone, Default, Debug)]
-pub struct Cip36Validation {
+#[allow(dead_code)]
+pub(crate) struct Cip36Validation {
     /// Is the signature valid? (signature in 61285)
     is_valid_signature: bool,
     /// Is the payment address on the correct network?
@@ -26,28 +27,6 @@ pub struct Cip36Validation {
     is_valid_purpose: bool,
 }
 
-impl Cip36Validation {
-    /// Is the signature from witness registration valid?
-    pub fn is_valid_signature(&self) -> bool {
-        self.is_valid_signature
-    }
-
-    /// Is the payment address network valid?
-    pub fn is_valid_payment_address_network(&self) -> bool {
-        self.is_valid_payment_address_network
-    }
-
-    /// Are the voting keys valid?
-    pub fn is_valid_voting_keys(&self) -> bool {
-        self.is_valid_voting_keys
-    }
-
-    /// Is the purpose valid?
-    pub fn is_valid_purpose(&self) -> bool {
-        self.is_valid_purpose
-    }
-}
-
 /// Validation for CIP-36
 /// The validation include the following:
 /// * Signature validation of the registration witness 61285 against the stake public key