fix(cardano-blockchain-types): fix type

Signed-off-by: bkioshn <[email protected]>

Author: bkioshn

rust/cardano-blockchain-types/src/cip36/mod.rs

@@ -13,7 +13,7 @@ use validation::{validate_payment_address_network, validate_signature, validate_
 use crate::{MetadatumValue, Network};
 
 /// CIP-36 Catalyst registration
-#[derive(Clone)]
+#[derive(Clone, Default)]
 pub struct Cip36 {
     /// Key registration - 61284
     pub key_registration: Cip36KeyRegistration,
@@ -24,7 +24,7 @@ pub struct Cip36 {
 }
 
 /// CIP36 Validation Report
-#[derive(Clone)]
+#[derive(Clone, Default)]
 pub struct Cip36Validation {
     /// Is the signature valid? (signature in 61285)
     pub is_valid_signature: bool,
@@ -65,7 +65,7 @@ impl Cip36 {
         self.key_registration.raw_nonce
     }
 
-    pub fn signature(&self) -> ed25519_dalek::Signature {
+    pub fn signature(&self) -> Option<ed25519_dalek::Signature> {
         self.registration_witness.signature.clone()
     }
     pub fn is_strict_catalyst(&self) -> bool {

rust/cardano-blockchain-types/src/cip36/registration_witness.rs

@@ -14,10 +14,10 @@ use crate::utils::decode_helper::{decode_bytes, decode_helper, decode_map_len};
 ///     1 : $stake_witness
 /// }
 /// ```
-#[derive(Clone)]
+#[derive(Clone, Default)]
 pub struct Cip36RegistrationWitness {
     /// Signature of the registration data.
-    pub signature: ed25519_dalek::Signature,
+    pub signature: Option<ed25519_dalek::Signature>,
 }
 
 impl Decode<'_, ()> for Cip36RegistrationWitness {
@@ -41,9 +41,7 @@ impl Decode<'_, ()> for Cip36RegistrationWitness {
         }
 
         let sig_bytes = decode_bytes(d, "CIP36 Registration Witness signature")?;
-        let signature = ed25519_dalek::Signature::from_slice(&sig_bytes).map_err(|e| {
-            decode::Error::message(format!("Invalid CIP36 Registration Witness Signature, {e}"))
-        })?;
+        let signature = ed25519_dalek::Signature::from_slice(&sig_bytes).ok();
 
         Ok(Cip36RegistrationWitness { signature })
     }

rust/cardano-blockchain-types/src/cip36/validation.rs

@@ -1,5 +1,5 @@
-use crate::{MetadatumValue, Network};
 use super::Cip36;
+use crate::{MetadatumValue, Network};
 
 /// Project Catalyst Purpose
 pub const PROJECT_CATALYST_PURPOSE: u64 = 0;
@@ -22,13 +22,18 @@ pub(crate) fn validate_signature(
         .update(metadata.as_ref())
         .finalize();
 
-    match cip36
-        .stake_pk()
-        .verify_strict(hash.as_bytes(), &cip36.signature())
-    {
+    let sig = match cip36.signature() {
+        Some(sig) => sig,
+        None => {
+            validation_report.push(format!("Validate CIP36 Signature, signature is invalid"));
+            return false;
+        },
+    };
+
+    match cip36.stake_pk().verify_strict(hash.as_bytes(), &sig) {
         Ok(_) => true,
         Err(_) => {
-            validation_report.push(format!("Validate CIP36 Signature, signature is invalid"));
+            validation_report.push(format!("Validate CIP36 Signature, cannot verify signature"));
             false
         },
     }