chore(rust/signed-doc): cleanup report messages

Author: saibatizoku

rust/signed_doc/src/validator/rules/ownership/mod.rs

@@ -9,15 +9,18 @@ use catalyst_types::catalyst_id::CatalystId;
 
 use crate::{providers::CatalystSignedDocumentProvider, CatalystSignedDocument};
 
+/// Context for the validation problem report.
+const REPORT_CONTEXT: &str = "Document ownership validation";
+
 /// Returns `true` if the document has a single author.
 ///
 /// If not, it adds to the document's problem report.
 fn single_author_check(doc: &CatalystSignedDocument) -> bool {
     let is_valid = doc.authors().len() == 1;
     if !is_valid {
         doc.report().functional_validation(
-            "New document must only be signed by a single author",
-            "Valid documents must only be signed by the original author",
+            "Document must only be signed by one author",
+            REPORT_CONTEXT,
         );
     }
     is_valid
@@ -80,8 +83,8 @@ impl DocumentOwnershipRule {
 
                 if !is_valid {
                     doc.report().functional_validation(
-                        "New document must only be signed by a single author or collaborators defined in the previous version",
-                        "Valid documents must only be signed by the original author or known collaborators",
+                        "Document must only be signed by original author and/or by collaborators defined in the previous version",
+                        REPORT_CONTEXT,
                     );
                 }
                 return Ok(is_valid);
@@ -97,8 +100,8 @@ impl DocumentOwnershipRule {
             let is_valid = first_doc.authors() == doc.authors();
             if !is_valid {
                 doc.report().functional_validation(
-                        &format!("New document authors must match the authors from the first version for Document ID {doc_id}"),
-                        "Valid documents must only be signed by the original author",
+                        "Document authors must match the author from the first version",
+                        REPORT_CONTEXT,
                     );
             }
             return Ok(is_valid);

rust/signed_doc/src/validator/rules/ownership/tests.rs

@@ -103,7 +103,7 @@ fn gen_original_doc_and_provider(
         let (doc_1, _, _, _, provider) = gen_original_doc_and_provider(ONE_AUTHOR,NO_COLLABS);
         (doc_1, provider)
     } => true ;
-    "First Version Catalyst Signed Document has the only one author"
+    "First Version Catalyst Signed Document has only one author"
 )]
 #[test_case(
     || {
@@ -188,7 +188,7 @@ async fn simple_author_rule_test(
         let doc= gen_next_ver_doc(doc_id, other_authors, collabs);
         (doc, provider)
     } => false ;
-    "Latest Catalyst Signed Document has the unexpected authors"
+    "Latest Catalyst Signed Document signed by unexpected author"
 )]
 #[tokio::test]
 async fn author_with_collaborators_rule_test(