Store devnet network configuration as string isntead of str(ref)

Author: stanislav-tkach

rust/cardano-blockchain-types/src/metadata/cip36/mod.rs

@@ -175,7 +175,7 @@ impl Cip36 {
         let mut cip36 = Cip36 {
             key_registration,
             registration_witness,
-            network,
+            network: network.clone(),
             slot: slot.into(),
             txn_idx,
             is_catalyst_strict,
@@ -298,8 +298,8 @@ impl Cip36 {
 
     /// Get the network of this CIP-36 registration.
     #[must_use]
-    pub fn network(&self) -> Network {
-        self.network
+    pub fn network(&self) -> &Network {
+        &self.network
     }
 
     /// Get the transaction index of this CIP-36 registration.
@@ -373,7 +373,7 @@ mod tests {
         let res = Cip36::new(&block_1(), 1.into(), true).unwrap().unwrap();
         assert!(!res.err_report().is_problematic());
         assert!(res.is_valid());
-        assert!(res.network() == Network::Preprod);
+        assert!(res.network() == &Network::Preprod);
         assert!(res.raw_nonce() == Some(55_076_993));
         assert!(res.nonce() == Some(55_076_993));
     }

rust/cardano-blockchain-types/src/multi_era_block_data.rs

@@ -236,8 +236,8 @@ impl MultiEraBlock {
     ///
     /// - The network that this block originated on.
     #[must_use]
-    pub fn network(&self) -> Network {
-        self.inner.network
+    pub fn network(&self) -> &Network {
+        &self.inner.network
     }
 
     /// Get The Metadata fora a transaction and known label from the block

rust/cardano-blockchain-types/src/network.rs

@@ -22,7 +22,7 @@ pub(crate) const ENVVAR_MITHRIL_EXE_NAME: &str = "MITHRIL_EXE_NAME";
 
 /// Enum of possible Cardano networks.
 #[derive(
-    Debug, Copy, Clone, PartialEq, Eq, Hash, PartialOrd, Ord, strum::VariantNames, strum::Display,
+    Debug, Clone, PartialEq, Eq, Hash, PartialOrd, Ord, strum::VariantNames, strum::Display,
 )]
 #[strum(serialize_all = "snake_case")]
 #[non_exhaustive]
@@ -36,7 +36,7 @@ pub enum Network {
     /// Cardano devnet network.
     Devnet {
         /// Mithril signature genesis key for a blockchain.
-        genesis_key: &'static str,
+        genesis_key: String,
         /// Cardano blockchain networking magic number genesis block setting
         magic: u64,
         /// Cardano blockchain network id genesis block setting
@@ -48,7 +48,7 @@ pub enum Network {
         /// Cardano byron known slot genesis block setting
         byron_known_slot: u64,
         /// Cardano byron known hash genesis block setting
-        byron_known_hash: &'static str,
+        byron_known_hash: String,
         /// Cardano byron known time genesis block setting
         byron_known_time: u64,
         /// Cardano shelley epoch length genesis block setting
@@ -58,7 +58,7 @@ pub enum Network {
         /// Cardano shelley known slot genesis block setting
         shelley_known_slot: u64,
         /// Cardano shelley known hash genesis block setting
-        shelley_known_hash: &'static str,
+        shelley_known_hash: String,
         /// Cardano shelley known time genesis block setting
         shelley_known_time: u64,
     },
@@ -311,18 +311,18 @@ mod tests {
         assert_eq!(Network::Preview.to_string(), "preview");
         assert_eq!(
             Network::Devnet {
-                genesis_key: "genesis_key",
+                genesis_key: "genesis_key".into(),
                 magic: 0,
                 network_id: 0,
                 byron_epoch_length: 0,
                 byron_slot_length: 0,
                 byron_known_slot: 0,
-                byron_known_hash: "byron_known_hash",
+                byron_known_hash: "byron_known_hash".into(),
                 byron_known_time: 0,
                 shelley_epoch_length: 0,
                 shelley_slot_length: 0,
                 shelley_known_slot: 0,
-                shelley_known_hash: "shelley_known_hash",
+                shelley_known_hash: "shelley_known_hash".into(),
                 shelley_known_time: 0
             }
             .to_string(),

rust/cardano-blockchain-types/src/stake_address.rs

@@ -160,7 +160,7 @@ mod tests {
         ];
 
         for (network, is_script, hash, expected_header) in test_data {
-            let stake_address = StakeAddress::new(network, is_script, hash.into());
+            let stake_address = StakeAddress::new(network.clone(), is_script, hash.into());
             assert_eq!(stake_address.is_script(), is_script);
 
             // Check that conversion to bytes includes the expected header value.