refactor proptest::Arbitrary impl

Author: Mr-Leshiy

rust/catalyst-voting/Cargo.toml

@@ -24,6 +24,7 @@ curve25519-dalek = { version = "4.1.3", features = ["digest", "rand_core"] }
 ed25519-dalek = { version = "2.1.1", features = ["rand_core"] }
 blake2b_simd = "1.0.2"
 rayon = "1.10.0"
+proptest = { version = "1.5.0", optional = true }
 
 [dev-dependencies]
 criterion = "0.5.1"
@@ -35,4 +36,4 @@ test-strategy = "0.4.0"
 [features]
 # Feature which makes publicly available
 # `proptest::prelude::Arbitrary` trait implementation for some types
-proptest-arbitrary = []
+proptest-arbitrary = ["dep:proptest"]

rust/catalyst-voting/src/crypto/ed25519/mod.rs

@@ -47,10 +47,11 @@ pub fn verify_signature(pk: &PublicKey, msg: &[u8], sig: &Signature) -> bool {
 }
 
 #[cfg(any(test, feature = "proptest-arbitrary"))]
+#[allow(missing_docs, clippy::missing_docs_in_private_items)]
 mod arbitrary_impl {
     use proptest::prelude::{any, Arbitrary, BoxedStrategy, Strategy};
 
-    use super::*;
+    use super::{PrivateKey, SigningKey};
 
     impl Arbitrary for PrivateKey {
         type Parameters = ();

rust/catalyst-voting/src/crypto/elgamal/mod.rs

@@ -67,13 +67,14 @@ impl Add<&Ciphertext> for &Ciphertext {
 }
 
 #[cfg(any(test, feature = "proptest-arbitrary"))]
+#[allow(missing_docs, clippy::missing_docs_in_private_items)]
 mod arbitrary_impl {
     use proptest::{
         arbitrary::any,
         prelude::{Arbitrary, BoxedStrategy, Strategy},
     };
 
-    use super::*;
+    use super::{Ciphertext, GroupElement};
 
     impl Arbitrary for Ciphertext {
         type Parameters = ();

rust/catalyst-voting/src/crypto/group/ristretto255/mod.rs

@@ -160,13 +160,14 @@ impl Sub<&GroupElement> for &GroupElement {
 }
 
 #[cfg(any(test, feature = "proptest-arbitrary"))]
+#[allow(missing_docs, clippy::missing_docs_in_private_items)]
 mod arbitrary_impl {
     use proptest::{
         arbitrary::any,
         prelude::{Arbitrary, BoxedStrategy, Strategy},
     };
 
-    use super::*;
+    use super::{GroupElement, Mul, Scalar};
 
     impl Arbitrary for Scalar {
         type Parameters = ();

rust/catalyst-voting/src/crypto/zk_unit_vector/mod.rs

@@ -236,13 +236,14 @@ fn check_2(
 }
 
 #[cfg(any(test, feature = "proptest-arbitrary"))]
+#[allow(missing_docs, clippy::missing_docs_in_private_items)]
 mod arbitrary_impl {
     use proptest::{
         prelude::{any_with, Arbitrary, BoxedStrategy, Strategy},
         sample::size_range,
     };
 
-    use super::*;
+    use super::{Announcement, Ciphertext, ResponseRandomness, Scalar, UnitVectorProof};
 
     impl Arbitrary for UnitVectorProof {
         type Parameters = usize;

rust/catalyst-voting/src/crypto/zk_unit_vector/randomness_announcements.rs

@@ -80,13 +80,14 @@ impl ResponseRandomness {
 }
 
 #[cfg(any(test, feature = "proptest-arbitrary"))]
+#[allow(missing_docs, clippy::missing_docs_in_private_items)]
 mod arbitrary_impl {
     use proptest::{
         arbitrary::any,
         prelude::{Arbitrary, BoxedStrategy, Strategy},
     };
 
-    use super::*;
+    use super::{Announcement, BlindingRandomness, GroupElement, ResponseRandomness, Scalar};
 
     impl Arbitrary for BlindingRandomness {
         type Parameters = ();

rust/catalyst-voting/src/vote_protocol/committee/mod.rs

@@ -37,10 +37,11 @@ impl ElectionSecretKey {
 pub struct ElectionPublicKey(pub(crate) GroupElement);
 
 #[cfg(any(test, feature = "proptest-arbitrary"))]
+#[allow(missing_docs, clippy::missing_docs_in_private_items)]
 mod arbitrary_impl {
     use proptest::prelude::{any, Arbitrary, BoxedStrategy, Strategy};
 
-    use super::*;
+    use super::{ElectionSecretKey, Scalar};
 
     impl Arbitrary for ElectionSecretKey {
         type Parameters = ();

rust/catalyst-voting/src/vote_protocol/voter/mod.rs

@@ -142,13 +142,14 @@ pub fn decrypt_vote(vote: &EncryptedVote, secret_key: &ElectionSecretKey) -> any
 }
 
 #[cfg(any(test, feature = "proptest-arbitrary"))]
+#[allow(missing_docs, clippy::missing_docs_in_private_items)]
 mod arbitrary_impl {
     use proptest::{
         prelude::{any_with, Arbitrary, BoxedStrategy, Strategy},
         sample::size_range,
     };
 
-    use super::*;
+    use super::{Ciphertext, EncryptedVote};
 
     impl Arbitrary for EncryptedVote {
         type Parameters = usize;

rust/catalyst-voting/src/vote_protocol/voter/proof.rs

@@ -108,10 +108,11 @@ pub fn verify_voter_proof(
 }
 
 #[cfg(any(test, feature = "proptest-arbitrary"))]
+#[allow(missing_docs, clippy::missing_docs_in_private_items)]
 mod arbitrary_impl {
     use proptest::prelude::{any_with, Arbitrary, BoxedStrategy, Strategy};
 
-    use super::*;
+    use super::{UnitVectorProof, VoterProof};
 
     impl Arbitrary for VoterProof {
         type Parameters = usize;

rust/jormungandr-vote-tx/Cargo.toml

@@ -14,7 +14,15 @@ workspace = true
 catalyst-voting = { path = "../catalyst-voting" }
 anyhow = "1.0.89"
 
+[dev-dependencies]
+catalyst-voting = { path = "../catalyst-voting", features = ["proptest-arbitrary"] }
+
 proptest = { version = "1.5.0" }
 # Potentially it could be replaced with using `proptest::property_test` attribute macro,
 # after this PR will be merged https://github.com/proptest-rs/proptest/pull/523
 test-strategy = "0.4.0"
+
+[features]
+# Feature which makes publicly available
+# `proptest::prelude::Arbitrary` trait implementation for some types
+proptest-arbitrary = ["catalyst-voting/proptest-arbitrary"]