fix clippy

Author: Mr-Leshiy

rust/cardano-chain-follower/src/chain_sync_config.rs

@@ -133,12 +133,9 @@ impl ChainSyncConfig {
         stats::sync_started(self.chain);
 
         // Start the Chain Sync - IFF its not already running.
-        let lock_entry = match SYNC_JOIN_HANDLE_MAP.get(&self.chain) {
-            None => {
-                error!("Join Map improperly initialized: Missing {}!!", self.chain);
-                return Err(Error::Internal); // Should not get here.
-            },
-            Some(entry) => entry,
+        let Some(lock_entry) = SYNC_JOIN_HANDLE_MAP.get(&self.chain) else {
+            error!("Join Map improperly initialized: Missing {}!!", self.chain);
+            return Err(Error::Internal); // Should not get here.
         };
         let mut locked_handle = lock_entry.value().lock().await;
 

rust/cardano-chain-follower/src/mithril_snapshot_config.rs

@@ -392,12 +392,9 @@ impl MithrilSnapshotConfig {
         );
 
         // Start the Mithril Sync - IFF its not already running.
-        let lock_entry = match SYNC_JOIN_HANDLE_MAP.get(&self.chain) {
-            None => {
-                error!("Join Map improperly initialized: Missing {}!!", self.chain);
-                return Err(Error::Internal); // Should not get here.
-            },
-            Some(entry) => entry,
+        let Some(lock_entry) = SYNC_JOIN_HANDLE_MAP.get(&self.chain) else {
+            error!("Join Map improperly initialized: Missing {}!!", self.chain);
+            return Err(Error::Internal); // Should not get here.
         };
         let mut locked_handle = lock_entry.value().lock().await;
 
@@ -448,9 +445,8 @@ fn check_writable(path: &Path) -> bool {
     }
 
     // Can't read the directory for any reason, so can't write to the directory.
-    let path_iterator = match path.read_dir() {
-        Err(_) => return false,
-        Ok(entries) => entries,
+    let Ok(path_iterator) = path.read_dir() else {
+        return false;
     };
 
     // Recursively check the contents of the directory

rust/catalyst-voting/benches/vote_protocol.rs

@@ -8,7 +8,8 @@
     missing_docs,
     clippy::missing_docs_in_private_items,
     clippy::unwrap_used,
-    clippy::similar_names
+    clippy::similar_names,
+    clippy::explicit_deref_methods
 )]
 
 use catalyst_voting::{

rust/catalyst-voting/src/crypto/babystep_giantstep.rs

@@ -95,6 +95,7 @@ impl BabyStepGiantStep {
 }
 
 #[cfg(test)]
+#[allow(clippy::explicit_deref_methods)]
 mod tests {
     use std::ops::Mul;
 

rust/catalyst-voting/src/crypto/zk_unit_vector/decoding.rs

@@ -152,6 +152,7 @@ impl ResponseRandomness {
 }
 
 #[cfg(test)]
+#[allow(clippy::explicit_deref_methods)]
 mod tests {
     use test_strategy::proptest;
 

rust/catalyst-voting/src/crypto/zk_unit_vector/mod.rs

@@ -264,6 +264,7 @@ mod arbitrary_impl {
 }
 
 #[cfg(test)]
+#[allow(clippy::explicit_deref_methods)]
 mod tests {
     use proptest::sample::size_range;
     use rand_core::OsRng;

rust/catalyst-voting/src/vote_protocol/voter/decoding.rs

@@ -78,6 +78,7 @@ impl VoterProof {
 }
 
 #[cfg(test)]
+#[allow(clippy::explicit_deref_methods)]
 mod tests {
     use std::io::Cursor;
 

rust/catalyst-voting/tests/voting_test.rs

@@ -1,5 +1,7 @@
 //! A general voting integration test, which performs a full voting procedure.
 
+#![allow(clippy::explicit_deref_methods)]
+
 use catalyst_voting::vote_protocol::{
     committee::ElectionSecretKey,
     tally::{

rust/rbac-registration/src/cardano/cip509/validation.rs

@@ -119,7 +119,7 @@ pub fn validate_stake_public_key(
     let context = "Cip509 stake public key validation";
 
     let transaction = MultiEraTx::Conway(Box::new(Cow::Borrowed(transaction)));
-    let witness = match TxnWitness::new(&[transaction.clone()]) {
+    let witness = match TxnWitness::new(std::slice::from_ref(&transaction)) {
         Ok(w) => w,
         Err(e) => {
             report.other(&format!("Failed to create TxWitness: {e:?}"), context);

rust/vote-tx-v1/src/decoding.rs

@@ -216,6 +216,7 @@ impl Tx {
 }
 
 #[cfg(test)]
+#[allow(clippy::explicit_deref_methods)]
 mod tests {
     use catalyst_voting::{
         crypto::{ed25519::PrivateKey, rng::rand_core::OsRng},