wip

Author: Mr-Leshiy

rust/signed_doc/src/doc_types/proposal_document.rs

@@ -18,7 +18,8 @@ pub struct ProposalDocument {
 }
 
 impl ProposalDocument {
-    /// Try to build `ProposalDocument` from `CatalystSignedDoc` collecting report
+    /// Try to build `ProposalDocument` from `CatalystSignedDoc` doing all necessary
+    /// stateless verifications,
     #[allow(dead_code)]
     pub(crate) fn from_signed_doc(
         doc: &CatalystSignedDocument, error_report: &ProblemReport,
@@ -46,6 +47,13 @@ impl ProposalDocument {
         let content = doc.doc_content().decoded_bytes().to_vec();
         Ok(Self { content })
     }
+
+    /// A comprehensive validation of the `ProposalDocument` content.
+    #[allow(clippy::unused_self)]
+    pub(crate) fn validate_with_report<F>(&self, _doc_getter: F, _error_report: &ProblemReport)
+    where F: FnMut() -> Option<CatalystSignedDocument> {
+        // TODO: implement the rest of the validation
+    }
 }
 
 impl TryFrom<CatalystSignedDocument> for ProposalDocument {

rust/signed_doc/src/validator/mod.rs

@@ -15,7 +15,7 @@ use crate::{
 ///
 /// Returns a report of validation failures and the source error.
 pub fn validate<F>(
-    doc: &CatalystSignedDocument, _doc_getter: F,
+    doc: &CatalystSignedDocument, doc_getter: F,
 ) -> Result<(), CatalystSignedDocError>
 where F: FnMut() -> Option<CatalystSignedDocument> {
     let error_report = ProblemReport::new("Catalyst Signed Document Validation");
@@ -39,7 +39,9 @@ where F: FnMut() -> Option<CatalystSignedDocument> {
     #[allow(clippy::match_same_arms)]
     match doc_type {
         DocumentType::ProposalDocument => {
-            drop(ProposalDocument::from_signed_doc(doc, &error_report));
+            if let Ok(proposal_doc) = ProposalDocument::from_signed_doc(doc, &error_report) {
+                proposal_doc.validate_with_report(doc_getter, &error_report);
+            }
         },
         DocumentType::ProposalTemplate => {},
         DocumentType::CommentDocument => {},