Implement role_0_stake_addresses for both registration chain and cip509 (#305)

Author: stanislav-tkach

rust/rbac-registration/src/cardano/cip509/cip509.rs

@@ -5,7 +5,9 @@
 use std::{borrow::Cow, collections::HashMap};
 
 use anyhow::{anyhow, Context};
-use cardano_blockchain_types::{MetadatumLabel, MultiEraBlock, TransactionId, TxnIndex};
+use cardano_blockchain_types::{
+    MetadatumLabel, MultiEraBlock, StakeAddress, TransactionId, TxnIndex,
+};
 use catalyst_types::{
     cbor_utils::{report_duplicated_key, report_missing_keys},
     hashes::{Blake2b256Hash, BLAKE_2B256_SIZE},
@@ -257,6 +259,15 @@ impl Cip509 {
         self.catalyst_id.as_ref()
     }
 
+    /// Returns a list of role 0 stake addresses.
+    #[must_use]
+    pub fn role_0_stake_addresses(&self) -> Vec<StakeAddress> {
+        self.metadata
+            .as_ref()
+            .map(|m| m.certificate_uris.stake_addresses(0))
+            .unwrap_or_default()
+    }
+
     /// Returns `Cip509` fields consuming the structure if it was successfully decoded and
     /// validated otherwise return the problem report that contains all the encountered
     /// issues.

rust/rbac-registration/src/cardano/cip509/utils/cip134_uri_set.rs

@@ -7,9 +7,10 @@ use c509_certificate::{
     general_names::general_name::{GeneralNameTypeRegistry, GeneralNameValue},
     C509ExtensionType,
 };
-use cardano_blockchain_types::Cip0134Uri;
+use cardano_blockchain_types::{Cip0134Uri, StakeAddress};
 use catalyst_types::problem_report::ProblemReport;
 use der_parser::der::parse_der_sequence;
+use pallas::ledger::addresses::Address;
 use tracing::debug;
 use x509_cert::der::oid::db::rfc5912::ID_CE_SUBJECT_ALT_NAME;
 
@@ -67,10 +68,25 @@ impl Cip0134UriSet {
         self.x_uris().is_empty() && self.c_uris().is_empty()
     }
 
+    /// Returns a list of stake addresses by the given index.
+    #[must_use]
+    pub fn stake_addresses(&self, index: usize) -> Vec<StakeAddress> {
+        let mut result = Vec::new();
+
+        if let Some(uris) = self.x_uris().get(&index) {
+            result.extend(convert_stake_addresses(uris));
+        }
+        if let Some(uris) = self.c_uris().get(&index) {
+            result.extend(convert_stake_addresses(uris));
+        }
+
+        result
+    }
+
     /// Return the updated URIs set.
     ///
     /// The resulting set includes all the data from both the original and a new one. In
-    /// the following example for brevity we only consider ony type of uris:
+    /// the following example for brevity we only consider one type of uris:
     /// ```text
     /// // Original data:
     /// 0: [uri_1]
@@ -259,6 +275,18 @@ fn extract_c509_uris(certificates: &[C509Cert], report: &ProblemReport) -> UrisM
     result
 }
 
+/// Converts a list of `Cip0134Uri` to a list of stake addresses.
+fn convert_stake_addresses(uris: &[Cip0134Uri]) -> Vec<StakeAddress> {
+    uris.iter()
+        .filter_map(|uri| {
+            match uri.address() {
+                Address::Stake(a) => Some(a.clone().into()),
+                _ => None,
+            }
+        })
+        .collect()
+}
+
 #[cfg(test)]
 mod tests {
     use pallas::ledger::addresses::{Address, Network};

rust/rbac-registration/src/registration/cardano/mod.rs

@@ -6,13 +6,12 @@ use std::{collections::HashMap, sync::Arc};
 
 use anyhow::bail;
 use c509_certificate::c509::C509;
-use cardano_blockchain_types::{Cip0134Uri, StakeAddress, TransactionId};
+use cardano_blockchain_types::{StakeAddress, TransactionId};
 use catalyst_types::{
     id_uri::{key_rotation::KeyRotation, IdUri},
     uuid::UuidV4,
 };
 use ed25519_dalek::VerifyingKey;
-use pallas::ledger::addresses::Address;
 use tracing::error;
 use update_rbac::{
     revocations_list, update_c509_certs, update_public_keys, update_role_data, update_x509_certs,
@@ -212,16 +211,7 @@ impl RegistrationChain {
     /// Returns a list of role 0 stake addresses.
     #[must_use]
     pub fn role_0_stake_addresses(&self) -> Vec<StakeAddress> {
-        let mut result = Vec::new();
-
-        if let Some(uris) = self.inner.certificate_uris.x_uris().get(&0) {
-            result.extend(convert_stake_addresses(uris));
-        }
-        if let Some(uris) = self.inner.certificate_uris.c_uris().get(&0) {
-            result.extend(convert_stake_addresses(uris));
-        }
-
-        result
+        self.inner.certificate_uris.stake_addresses(0)
     }
 }
 
@@ -410,18 +400,6 @@ impl RegistrationChainInner {
     }
 }
 
-/// Converts a list of `Cip0134Uri` to a list of stake addresses.
-fn convert_stake_addresses(uris: &[Cip0134Uri]) -> Vec<StakeAddress> {
-    uris.iter()
-        .filter_map(|uri| {
-            match uri.address() {
-                Address::Stake(a) => Some(a.clone().into()),
-                _ => None,
-            }
-        })
-        .collect()
-}
-
 #[cfg(test)]
 mod test {
     use super::*;