fix(rust/signed-doc): Compare KIDs in the same form

Author: saibatizoku

rust/signed_doc/src/validator/rules/ownership/mod.rs

@@ -51,15 +51,30 @@ impl DocumentOwnershipRule {
                         "A latest version of the document must exist if a first version exists"
                     );
                 };
+
+                // Create sets of authors for comparison, ensure that they are in the same form
+                // (e.g. each `kid` is in `URI form`).
+                //
                 // Allowed authors for this document are the original author, and collaborators
                 // defined in the last published version of the Document ID.
                 let mut allowed_authors = first_doc
                     .authors()
                     .into_iter()
+                    .map(CatalystId::as_uri)
                     .collect::<HashSet<CatalystId>>();
-                allowed_authors.extend(last_doc.doc_meta().collaborators().iter().cloned());
-
-                let doc_authors = doc.authors().into_iter().collect::<HashSet<CatalystId>>();
+                allowed_authors.extend(
+                    last_doc
+                        .doc_meta()
+                        .collaborators()
+                        .iter()
+                        .cloned()
+                        .map(CatalystId::as_uri),
+                );
+                let doc_authors = doc
+                    .authors()
+                    .into_iter()
+                    .map(CatalystId::as_uri)
+                    .collect::<HashSet<_>>();
 
                 let is_valid = allowed_authors.intersection(&doc_authors).count() > 0;
 

rust/signed_doc/src/validator/rules/ownership/tests.rs

@@ -49,17 +49,21 @@ fn doc_builder(
     authors: Authors,
     collabs: Collabs,
 ) -> (UuidV7, Authors, CatalystSignedDocument) {
-    let _collaborators = collabs
-        .into_iter()
-        .map(|c| c.kid)
-        .collect::<Vec<CatalystId>>();
     let mut doc_builder = Builder::new()
         .with_metadata_field(SupportedField::Id(doc_id))
         .with_metadata_field(SupportedField::Ver(doc_ver))
         .with_metadata_field(SupportedField::Type(UuidV4::new().into()))
-        .with_metadata_field(SupportedField::ContentType(ContentType::Json))
-        //.with_metadata_field(SupportedField::Collaborators(collaborators.into()))
-        .with_content(vec![1, 2, 3]);
+        .with_metadata_field(SupportedField::ContentType(ContentType::Json));
+
+    if !collabs.is_empty() {
+        let collaborators = collabs
+            .into_iter()
+            .map(|c| c.kid)
+            .collect::<Vec<CatalystId>>();
+        doc_builder =
+            doc_builder.with_metadata_field(SupportedField::Collaborators(collaborators.into()));
+    }
+
     for author in &authors {
         doc_builder = doc_builder
             .add_signature(|m| author.sk.sign(&m).to_vec(), author.kid.clone())