fix(rust): Fail correctly if converting from &[u8] and the data isn't valid UTF8.

Author: stevenj

rust/catalyst-types/src/id_uri/errors.rs

@@ -32,4 +32,6 @@ pub enum IdUriError {
     InvalidRotationValue(#[from] KeyRotationError),
     /// Encryption key Identifier Fragment is not valid
     InvalidEncryptionKeyFragment,
+    /// Invalid Text encoding
+    InvalidTextEncoding(#[from] std::string::FromUtf8Error),
 }

rust/catalyst-types/src/id_uri/mod.rs

@@ -395,7 +395,7 @@ impl FromStr for IdUri {
             let mut cat_id = Self::new(network, subnet, role0_pk)
                 .with_role(role_index)
                 .with_rotation(rotation);
-            
+
             if uri.has_fragment() {
                 if uri.fragment() == Some(Self::ENCRYPTION_FRAGMENT) {
                     cat_id = cat_id.with_encryption();
@@ -476,7 +476,7 @@ impl TryFrom<&[u8]> for IdUri {
     type Error = errors::IdUriError;
 
     fn try_from(value: &[u8]) -> Result<Self, Self::Error> {
-        let kid_str = String::from_utf8_lossy(value);
+        let kid_str = String::from_utf8(value.to_vec())?;
         IdUri::from_str(&kid_str)
     }
 }