fix(rust/cardano-chain-follower): explicit condition for block roll forward

saibatizoku · saibatizoku · commit c6e912ea8f9e · 2024-10-09T10:21:10.000-07:00
diff --git a/rust/cardano-chain-follower/src/follow.rs b/rust/cardano-chain-follower/src/follow.rs
@@ -109,9 +109,11 @@ impl ChainFollower {
             }
         }
 
-        if (self.mithril_tip.is_none() || current_mithril_tip > self.mithril_tip)
-            && self.current < self.mithril_tip
-        {
+        let rollforward_condition = if let Some(mithril_tip) = &self.mithril_tip {
+            current_mithril_tip > *mithril_tip && *mithril_tip > self.current
+        } else { true };
+
+        if rollforward_condition {
             let snapshot = MithrilSnapshot::new(self.chain);
             if let Some(block) = snapshot.read_block_at(&current_mithril_tip).await {
                 // The Mithril Tip has moved forwards.

Original file line number	Diff line number	Diff line change
`@@ -109,9 +109,11 @@ impl ChainFollower {`
`109`	`109`	`}`
`110`	`110`	`}`
`111`	`111`
`112`		`- if (self.mithril_tip.is_none() \|\| current_mithril_tip > self.mithril_tip)`
`113`		`- && self.current < self.mithril_tip`
`114`		`- {`
	`112`	`+ let rollforward_condition = if let Some(mithril_tip) = &self.mithril_tip {`
	`113`	`+ current_mithril_tip > mithril_tip && mithril_tip > self.current`
	`114`	`+ } else { true };`
	`115`	`+`
	`116`	`+ if rollforward_condition {`
`115`	`117`	`let snapshot = MithrilSnapshot::new(self.chain);`
`116`	`118`	`if let Some(block) = snapshot.read_block_at(&current_mithril_tip).await {`
`117`	`119`	`// The Mithril Tip has moved forwards.`