comments fixes

Author: Mr-Leshiy

rust/rbac-registration/src/cardano/cip509/cip509.rs

@@ -349,7 +349,7 @@ impl Cip509 {
     #[must_use]
     pub fn stake_addresses(&self) -> HashSet<StakeAddress> {
         self.certificate_uris()
-            .map(Cip0134UriSet::stake_addresses)
+            .map(Cip0134UriSet::active_stake_addresses)
             .unwrap_or_default()
     }
 

rust/rbac-registration/src/cardano/cip509/utils/cip134_uri_set.rs

@@ -120,7 +120,7 @@ impl Cip0134UriSet {
 
     /// Returns a set of all active (without taken) stake addresses.
     #[must_use]
-    pub fn stake_addresses(&self) -> HashSet<StakeAddress> {
+    pub fn active_stake_addresses(&self) -> HashSet<StakeAddress> {
         self.values()
             .filter_map(|uri| {
                 match uri.address() {
@@ -203,7 +203,7 @@ impl Cip0134UriSet {
 
         metadata
             .certificate_uris
-            .stake_addresses()
+            .active_stake_addresses()
             .iter()
             .for_each(|v| {
                 taken_stake_addresses.remove(v);
@@ -225,10 +225,10 @@ impl Cip0134UriSet {
         self,
         reg: &Cip509RbacMetadata,
     ) -> Self {
-        let current_stake_addresses = self.stake_addresses();
+        let current_stake_addresses = self.active_stake_addresses();
         let latest_taken_stake_addresses = reg
             .certificate_uris
-            .stake_addresses()
+            .active_stake_addresses()
             .into_iter()
             .filter(|v| current_stake_addresses.contains(v));
 
@@ -399,7 +399,7 @@ mod tests {
         assert!(set.c_uris().is_empty());
         assert_eq!(set.role_uris(0).count(), 1);
         assert_eq!(set.role_stake_addresses(0).len(), 1);
-        assert_eq!(set.stake_addresses().len(), 1);
+        assert_eq!(set.active_stake_addresses().len(), 1);
 
         let x_uris = set.x_uris();
         assert_eq!(x_uris.len(), 1);

rust/rbac-registration/src/cardano/state.rs

@@ -29,14 +29,14 @@ pub trait RbacChainsState {
         addr: &StakeAddress,
     ) -> impl Future<Output = anyhow::Result<bool>> + Send;
 
-    /// Returns a corresponding to the RBAC chain's Catalyst ID corresponding by the given
+    /// Returns the Catalyst ID associated with the RBAC chain for the given signing public key
     /// signing public key.
     fn chain_catalyst_id_from_signing_public_key(
         &self,
         key: &VerifyingKey,
     ) -> impl Future<Output = anyhow::Result<Option<CatalystId>>> + Send;
 
-    /// Update the chain by "taking" the given `StakeAddress` for the corresponding
+    /// Update currently assosiated with the stake addresses chains by "taking" the given `StakeAddress` for the corresponding
     /// RBAC chain's by the given `CatalystId`.
     fn take_stake_address_from_chains<I>(
         &mut self,

rust/rbac-registration/src/registration/cardano/mod.rs

@@ -121,10 +121,10 @@ impl RegistrationChain {
         };
 
         // Check that addresses from the new registration aren't used in other chains.
-        let previous_addresses = self.stake_addresses();
-        let reg_addresses = cip509.stake_addresses();
-        let new_addresses: Vec<_> = reg_addresses.difference(&previous_addresses).collect();
-        for address in &new_addresses {
+        let previous_stake_addresses = self.stake_addresses();
+        let reg_stake_addresses = cip509.stake_addresses();
+        let new_stake_addresses: Vec<_> = reg_stake_addresses.difference(&previous_stake_addresses).collect();
+        for address in &new_stake_addresses {
             if state.is_stake_address_used(address).await? {
                 cip509.report().functional_validation(
                         &format!("{address} stake address is already used"),
@@ -257,7 +257,7 @@ impl RegistrationChain {
     /// Get the latest encryption public key for a role.
     /// Returns the public key and the rotation, `None` if not found.
     #[must_use]
-    pub fn get_latest_encryption_pk_for_role(
+    pub fn get_latest_encryption_public_key_for_role(
         &self,
         role: RoleId,
     ) -> Option<(VerifyingKey, KeyRotation)> {
@@ -329,7 +329,7 @@ impl RegistrationChain {
     /// Returns all stake addresses associated to this chain.
     #[must_use]
     pub fn stake_addresses(&self) -> HashSet<StakeAddress> {
-        self.inner.certificate_uris.stake_addresses()
+        self.inner.certificate_uris.active_stake_addresses()
     }
 
     /// Returns the latest know applied registration's `PointTxnIdx`.
@@ -748,7 +748,7 @@ where
         {
             cip509.report().functional_validation(
                     &format!("An update to {cat_id} registration chain uses the same public key ({key:?}) as {previous} chain"),
-                    "It isn't allowed to use role 0 signing (certificate subject public) key in different chains",
+                    "It isn't allowed to use signing (certificate subject public) key in different chains",
                     );
         }
     }