Skip to content

fix(rust/rbac-registration): Fix extraction of Cardano Addresses from a cardano address URI string #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 13, 2024
Merged

fix(rust/rbac-registration): Fix extraction of Cardano Addresses from a cardano address URI string #102

merged 3 commits into from
Dec 13, 2024

Conversation

@stanislav-tkach
Copy link
Member

@stanislav-tkach stanislav-tkach commented Dec 10, 2024 •
edited
Loading

Description

  • The Cip0134Uri type has been added.
  • The extract_cip19_hash was removed (Cip0134Uri::parse can be used instead).

Related Issue(s)

Closes #103.

Breaking Changes

  • The extract_cip19_hash function was removed.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@stanislav-tkach stanislav-tkach self-assigned this Dec 10, 2024
stevenj
stevenj requested changes Dec 11, 2024
View reviewed changes
@stanislav-tkach stanislav-tkach changed the title fix(rbac-registration): Fix extraction of Cardano Addresses from a cardano address URI string fix(rust/rbac-registration): Fix extraction of Cardano Addresses from a cardano address URI string Dec 11, 2024
@stanislav-tkach stanislav-tkach force-pushed the fix-extraction-of-cardano-addresses-from-cardano-address-uri branch 2 times, most recently from f768c1e to 48dbf9d Compare December 11, 2024 13:18
This was referenced Dec 11, 2024
Closed
Merged
@stanislav-tkach stanislav-tkach force-pushed the fix-extraction-of-cardano-addresses-from-cardano-address-uri branch from 48dbf9d to ca89c66 Compare December 11, 2024 18:43
@stanislav-tkach
Copy link
Member Author

stanislav-tkach commented Dec 11, 2024 •
edited
Loading

Test should pass after the input-output-hk/catalyst-ci#360 pull request is accepted. I will mark this pull request as "ready for review" after this is fixed.

@stanislav-tkach stanislav-tkach force-pushed the fix-extraction-of-cardano-addresses-from-cardano-address-uri branch from c5910fe to 041b3c7 Compare December 12, 2024 11:02
@stanislav-tkach stanislav-tkach added the do not merge yet PR is not ready to be merged yet label Dec 12, 2024
@stanislav-tkach stanislav-tkach force-pushed the fix-extraction-of-cardano-addresses-from-cardano-address-uri branch from 041b3c7 to caceaa5 Compare December 12, 2024 16:56
@stanislav-tkach stanislav-tkach added review me PR is ready for review and removed do not merge yet PR is not ready to be merged yet labels Dec 12, 2024
@stanislav-tkach stanislav-tkach force-pushed the fix-extraction-of-cardano-addresses-from-cardano-address-uri branch from caceaa5 to 5537445 Compare December 12, 2024 17:11
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024

✅ Test Report | ${\color{lightgreen}Pass: 228/228}$ | ${\color{red}Fail: 0/228}$ |

@stanislav-tkach stanislav-tkach marked this pull request as ready for review December 12, 2024 17:31
stevenj
stevenj approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 0aeadb9 into main Dec 13, 2024
24 checks passed
@stevenj stevenj deleted the fix-extraction-of-cardano-addresses-from-cardano-address-uri branch December 13, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenj stevenj stevenj approved these changes

@Mr-Leshiy Mr-Leshiy Awaiting requested review from Mr-Leshiy

@bkioshn bkioshn Awaiting requested review from bkioshn

Assignees

@stanislav-tkach stanislav-tkach

Labels

review me PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Introduce Cip0134Uri type

3 participants

@stanislav-tkach @stevenj