Skip to content

feat(rust/catalyst-types): Add a new Rust crate catalyst-types #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Jan 7, 2025
Merged

feat(rust/catalyst-types): Add a new Rust crate catalyst-types #138

merged 35 commits into from
Jan 7, 2025

Conversation

@apskhem
Copy link
Collaborator

@apskhem apskhem commented Jan 3, 2025 •
edited
Loading

Description

This new crate is to better fix the dependency tree and maximize reusability of our code using inside this repo.

Related Issue(s)

Closes #136

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem added the do not merge yet PR is not ready to be merged yet label Jan 3, 2025
@apskhem apskhem self-assigned this Jan 3, 2025
@apskhem apskhem linked an issue Jan 3, 2025 that may be closed by this pull request
🛠️ [TASK] : Create a catalyst-types crate for our types which are not specific to any particular subsystem #136
Closed
@apskhem apskhem marked this pull request as draft January 3, 2025 14:36
stevenj and others added 2 commits January 6, 2025 11:23
@stevenj
feat(rust): Add uniform problem report type (#140)
4995282 
* feat(rust): Add uniform problem report type

* fix(docs): spelling

* fix(rust): catalyst-types ci build
@stevenj
fix(rust): doc tests
009063a
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

✅ Test Report | ${\color{lightgreen}Pass: 254/254}$ | ${\color{red}Fail: 0/254}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

✅ Test Report | ${\color{lightgreen}Pass: 254/254}$ | ${\color{red}Fail: 0/254}$ |

@apskhem apskhem added review me PR is ready for review and removed do not merge yet PR is not ready to be merged yet labels Jan 6, 2025
@apskhem apskhem marked this pull request as ready for review January 6, 2025 07:05
@apskhem apskhem added the do not merge yet PR is not ready to be merged yet label Jan 6, 2025
@apskhem apskhem removed the review me PR is ready for review label Jan 6, 2025
apskhem and others added 3 commits January 6, 2025 14:29
@apskhem
fix: uuid type
01f7d6c
@bkioshn @stevenj
feat(rust/catalyst-types): Add duplicate data error report (#141)
bfa2fc3 
* feat(catalyst-types): add duplicate data error report

Signed-off-by: bkioshn <[email protected]>

* fix(catalyst-types): format

Signed-off-by: bkioshn <[email protected]>

* fix(catalyst-types): add duplicate field description and change name

Signed-off-by: bkioshn <[email protected]>

* Update rust/catalyst-types/src/problem_report.rs

---------

Signed-off-by: bkioshn <[email protected]>
Co-authored-by: Steven Johnson <[email protected]>
@apskhem
chore: fmtfix
4971048
@apskhem apskhem added review me PR is ready for review and removed do not merge yet PR is not ready to be merged yet labels Jan 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

✅ Test Report | ${\color{lightgreen}Pass: 269/269}$ | ${\color{red}Fail: 0/269}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

✅ Test Report | ${\color{lightgreen}Pass: 269/269}$ | ${\color{red}Fail: 0/269}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

✅ Test Report | ${\color{lightgreen}Pass: 269/269}$ | ${\color{red}Fail: 0/269}$ |

bkioshn
bkioshn reviewed Jan 6, 2025
View reviewed changes
@apskhem apskhem requested a review from bkioshn January 6, 2025 14:20
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

✅ Test Report | ${\color{lightgreen}Pass: 269/269}$ | ${\color{red}Fail: 0/269}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

✅ Test Report | ${\color{lightgreen}Pass: 269/269}$ | ${\color{red}Fail: 0/269}$ |

bkioshn
bkioshn reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💫

@apskhem apskhem added the do not merge yet PR is not ready to be merged yet label Jan 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

✅ Test Report | ${\color{lightgreen}Pass: 269/269}$ | ${\color{red}Fail: 0/269}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

✅ Test Report | ${\color{lightgreen}Pass: 269/269}$ | ${\color{red}Fail: 0/269}$ |

@apskhem apskhem requested a review from bkioshn January 7, 2025 08:58
@apskhem apskhem removed the do not merge yet PR is not ready to be merged yet label Jan 7, 2025
stevenj
stevenj approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 768ecd5 into main Jan 7, 2025
21 checks passed
@stevenj stevenj deleted the feat/catalyst-types branch January 7, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenj stevenj stevenj approved these changes

@stanislav-tkach stanislav-tkach stanislav-tkach approved these changes

@Mr-Leshiy Mr-Leshiy Awaiting requested review from Mr-Leshiy

@bkioshn bkioshn Awaiting requested review from bkioshn

Assignees

@apskhem apskhem

Labels

enhancement New feature or request review me PR is ready for review

Projects

Catalyst
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Create a catalyst-types crate for our types which are not specific to any particular subsystem

5 participants

@apskhem @stevenj @stanislav-tkach @bkioshn