Skip to content

Conversation

@bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jan 24, 2025

Description

Add ProblemReport to Catalyst sign document

Related Issue(s)

Closes #164

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 281/281}$ | ${\color{red}Fail: 0/281}$ |

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 281/281}$ | ${\color{red}Fail: 0/281}$ |

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 281/281}$ | ${\color{red}Fail: 0/281}$ |

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

@bkioshn bkioshn added enhancement New feature or request review me PR is ready for review labels Jan 27, 2025
@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

@bkioshn bkioshn requested a review from Mr-Leshiy January 27, 2025 10:21
@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit c777f93 into main Jan 27, 2025
20 of 22 checks passed
@Mr-Leshiy Mr-Leshiy deleted the fix/sign-doc-err-report branch January 27, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request review me PR is ready for review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Adding ProblemReport to the CatalystSignedDocument

4 participants