Skip to content

Conversation

@cong-or
Copy link
Contributor

@cong-or cong-or commented Jan 27, 2025

The following produces an ELF binary in the target after a release build.

@cong-or cong-or requested a review from Mr-Leshiy January 27, 2025 12:15
@cong-or cong-or self-assigned this Jan 27, 2025
@cong-or cong-or added the F14 label Jan 27, 2025
@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

@cong-or cong-or merged commit 367b812 into main Jan 27, 2025
22 checks passed
@cong-or cong-or deleted the feat/signed-doc-binary branch January 27, 2025 12:33
@stanislav-tkach
Copy link
Member

stanislav-tkach commented Jan 27, 2025

I don't think it is an issue, but now I'm getting the following warning:

warning: .../catalyst-libs/rust/signed_doc/Cargo.toml: file .../catalyst-libs/rust/signed_doc/examples/mk_signed_doc.rs found to be present in multiple build targets:

  • bin target signed-docs
  • example target mk_signed_doc

Maybe we should remove it from the examples if this binary is generally usable?..
@Mr-Leshiy

@cong-or
Copy link
Contributor Author

cong-or commented Jan 27, 2025

I don't think it is an issue, but now I'm getting the following warning:

warning: .../catalyst-libs/rust/signed_doc/Cargo.toml: file .../catalyst-libs/rust/signed_doc/examples/mk_signed_doc.rs found to be present in multiple build targets:

  • bin target signed-docs
  • example target mk_signed_doc

Maybe we should remove it from the examples if this binary is generally usable?.. @Mr-Leshiy

@stanislav-tkach we need the binary for the load tester which is written in python. We could revert it and I can use a branch instead.

@stanislav-tkach
Copy link
Member

@cong-or It is just a warning, so we can ignore it. I think that more convenient testing is more important, but I would like to hear other opinions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants