feat(general): Small assorted improvements #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

stanislav-tkach merged 23 commits into main from cip509-purpose-getter

Jan 28, 2025

Member

stanislav-tkach commented Jan 27, 2025 •

edited

Loading

Description

Add the purpose getter to Cip509.
Export the Cip509RbacMetadata type.
Add the define_hashes macro.

Please confirm the following checks

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream module


          Add the purpose getter function to Cip509

6eb47b4

Contributor

github-actions bot commented Jan 27, 2025

✅ Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

stanislav-tkach added 4 commits

January 27, 2025 14:00


          Implement SerializeValue and DeserializeValue for UUIDs

b477fd5


          Merge branch 'main' into cip509-purpose-getter


          Export Cip509RbacMetadata type

4fa68e7


          Merge remote-tracking branch 'origin/cip509-purpose-getter' into cip5…

5fb0602

…09-purpose-getter

Contributor

github-actions bot commented Jan 27, 2025

✅ Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |


          Implement SerializeValue and DeserializeValue for Blake2bHash

35b42e5

stanislav-tkach changed the title ~~feat(rust/rbac-registration): Add the purpose getter function to Cip509~~ feat(general): Add the purpose getter function to Cip509

stanislav-tkach changed the title ~~feat(general): Add the purpose getter function to Cip509~~ feat(general): Some improvements

stanislav-tkach changed the title ~~feat(general): Some improvements~~ feat(general): Small assorted improvements

stanislav-tkach added 2 commits

January 27, 2025 15:46


          Fix Clippy

26d8a74


          Merge branch 'main' into cip509-purpose-getter

84a3e02

Contributor

github-actions bot commented Jan 27, 2025

✅ Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

stanislav-tkach added 8 commits

January 27, 2025 19:02


          Add TransactionHash and PubKeyHash types

328733c


          Merge remote-tracking branch 'origin/cip509-purpose-getter' into cip5…

33ba72a

…09-purpose-getter


          Merge branch 'main' into cip509-purpose-getter

4f7cae2


          Fix spellcheck

6c26210


          Merge remote-tracking branch 'origin/cip509-purpose-getter' into cip5…

d74e1bb

…09-purpose-getter


          Fix spellcheck 2

d0f4924


          Remove unused dependencies

344f3dc


          Document the macro

5ed07ab

Contributor

github-actions bot commented Jan 27, 2025

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

stanislav-tkach requested review from Mr-Leshiy, bkioshn and stevenj and removed request for Mr-Leshiy and bkioshn

January 27, 2025 18:54


          Use 'meta' instead of 'tt' for docs

b697f71

Contributor

github-actions bot commented Jan 27, 2025

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

Mr-Leshiy requested changes

View reviewed changes

rust/cardano-blockchain-types/src/hashes.rs Outdated Show resolved Hide resolved

rust/cardano-blockchain-types/src/hashes.rs Outdated Show resolved Hide resolved

rust/catalyst-types/src/hashes.rs Outdated Show resolved Hide resolved

rust/catalyst-types/src/uuid/uuid_v4.rs Outdated Show resolved Hide resolved

rust/catalyst-types/src/uuid/uuid_v7.rs Outdated Show resolved Hide resolved


          Remove cspell exception

eab11ac

Contributor

github-actions bot commented Jan 28, 2025

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

stanislav-tkach added 2 commits

January 28, 2025 13:37


          Remove -scylla dependency

c853ce7


          Merge branch 'main' into cip509-purpose-getter

20c169d

Contributor

github-actions bot commented Jan 28, 2025

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |


          Move define_hashes to catalyst-types

stanislav-tkach requested a review from Mr-Leshiy

January 28, 2025 13:10

stanislav-tkach added 2 commits

January 28, 2025 14:11


          Remove import

b6bed0e


          cleanup

0b832b3

Contributor

github-actions bot commented Jan 28, 2025

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

Contributor

github-actions bot commented Jan 28, 2025

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

Mr-Leshiy approved these changes

View reviewed changes

Contributor

Mr-Leshiy left a comment

LGTM

stanislav-tkach merged commit e251dea into main

20 of 22 checks passed

stanislav-tkach deleted the cip509-purpose-getter branch

January 28, 2025 13:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet