fix(cat-voices): handle unknown account with better error message (#2675)

Author: damian-molinski

catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/registration/cubits/recover_cubit.dart

@@ -77,9 +77,9 @@ final class RecoverCubit extends Cubit<RecoverStateData>
         return false;
       }
 
-      final account = await _registrationService.recoverAccount(
-        seedPhrase: seedPhrase,
-      );
+      final account = await _registrationService
+          .recoverAccount(seedPhrase: seedPhrase)
+          .onError<NotFoundException>((_, __) => throw const LocalizedRecoverAccountNotFound());
 
       final address = account.address!;
       final balance = await _registrationService.getWalletBalance(

catalyst_voices/packages/internal/catalyst_voices_localization/lib/l10n/intl_en.arb

@@ -644,6 +644,10 @@
   "@registrationWalletNotFound": {
     "description": "Error message shown when connect wallet but matching was not found"
   },
+  "registrationAccountNotFound": "Account not found. Make sure seed phrase is correct.",
+  "@registrationAccountNotFound": {
+    "description": "Error message shown when recovering account with invalid seed phrase."
+  },
   "walletLinkRoleChooserTitle": "How do you want to participate in Catalyst?",
   "@walletLinkRoleChooserTitle": {
     "description": "A title on the role chooser screen in registration."

catalyst_voices/packages/internal/catalyst_voices_repositories/lib/src/user/user_repository.dart

@@ -1,7 +1,6 @@
 import 'package:catalyst_cardano_serialization/catalyst_cardano_serialization.dart';
 import 'package:catalyst_voices_models/catalyst_voices_models.dart';
 import 'package:catalyst_voices_repositories/catalyst_voices_repositories.dart';
-import 'package:catalyst_voices_repositories/generated/api/cat_gateway.swagger.dart';
 import 'package:catalyst_voices_repositories/generated/api/cat_reviews.models.swagger.dart';
 import 'package:catalyst_voices_repositories/src/common/rbac_token_ext.dart';
 import 'package:catalyst_voices_repositories/src/common/response_mapper.dart';
@@ -111,10 +110,10 @@ final class UserRepositoryImpl implements UserRepository {
     required CatalystId catalystId,
     required RbacToken rbacToken,
   }) async {
-    final rbacRegistration = await _recoverRbacRegistration(
-      catalystId,
-      rbacToken,
-    );
+    final rbacRegistration = await _apiServices.gateway
+        .apiV1RbacRegistrationGet(lookup: catalystId.toUri().toStringWithoutScheme())
+        .successBodyOrThrow();
+
     final publicId = await _getReviewsCatalystIDPublic(token: rbacToken);
     final username = (publicId?.username as String?) ??
         await _lookupUsernameFromDocuments(
@@ -163,16 +162,4 @@ final class UserRepositoryImpl implements UserRepository {
       },
     ).then((value) => value?.username);
   }
-
-  Future<RbacRegistrationChain> _recoverRbacRegistration(
-    CatalystId catalystId,
-    RbacToken token,
-  ) {
-    return _apiServices.gateway
-        .apiV1RbacRegistrationGet(
-          lookup: catalystId.toUri().toStringWithoutScheme(),
-          authorization: token.authHeader(),
-        )
-        .successBodyOrThrow();
-  }
 }

catalyst_voices/packages/internal/catalyst_voices_view_models/lib/src/registration/exception/localized_registration_exception.dart

@@ -5,6 +5,13 @@ import 'package:catalyst_voices_models/catalyst_voices_models.dart';
 import 'package:catalyst_voices_view_models/catalyst_voices_view_models.dart';
 import 'package:flutter/widgets.dart';
 
+final class LocalizedRecoverAccountNotFound extends LocalizedRegistrationException {
+  const LocalizedRecoverAccountNotFound();
+
+  @override
+  String message(BuildContext context) => context.l10n.registrationAccountNotFound;
+}
+
 /// A [LocalizedException] describing an error during a user registration.
 sealed class LocalizedRegistrationException extends LocalizedException {
   const LocalizedRegistrationException();