feat(cat-voices): proposal builder view/edit adjustments (#2142)

* feat: update document property section buttons

* feat: update title widget

* feat: add property read widget

* feat: document property viewer widget

* feat: distinguish between answered and not answered

* feat: handle overriden widgets in document builder viewer

* fix: submit proposal for review

* feat: cleanup colors, update save button

* chore: cleanup

* chore: cleanup

* feat: update rich text widget

* style: spelling

Author: dt-iohk

catalyst_voices/apps/voices/integration_test/pageobject/profile_page.dart

@@ -9,7 +9,7 @@ class ProfilePage {
   late PatrolTester $;
   final displayNameTile = const Key('AccountDisplayNameTile');
   final accountEmailTile = const Key('AccountEmailTile');
-  final editBtn = const Key('EditableTileEditSaveButton');
+  final editBtn = const Key('EditableTileEditCancelButton');
   final accountRolesTile = const Key('AddRoleTile');
   final addRole = const Key('EditRolesButton');
   final removeKeychain = const Key('RemoveKeychainButton');

catalyst_voices/apps/voices/lib/pages/proposal_builder/appbar/proposal_builder_status_action.dart

@@ -269,10 +269,19 @@ class _PopupMenuButtonState extends State<_PopupMenuButton> {
 
     final nextIteration = latestVersion.number;
 
-    // if it's local draft and the first version then
-    // it should be shown as local which corresponds to null
-    final currentIteration =
-        _isLocal(state.metadata.publish, nextIteration) ? null : nextIteration;
+    final int? currentIteration;
+    if (_isLocal(state.metadata.publish, nextIteration)) {
+      // if it's local draft and the first version then
+      // it should be shown as local which corresponds to null
+      currentIteration = null;
+    } else if (state.metadata.publish == ProposalPublish.localDraft) {
+      // current iteration is a local draft
+      // so next iteration must increment the version
+      currentIteration = nextIteration - 1;
+    } else {
+      // only changing status of the iteration, no need to increment the version
+      currentIteration = nextIteration;
+    }
 
     final shouldSubmit = await SubmitProposalForReviewDialog.show(
           context: context,

catalyst_voices/apps/voices/lib/widgets/buttons/voices_buttons.dart

@@ -270,41 +270,70 @@ class VoicesBackButton extends StatelessWidget {
   }
 }
 
-class VoicesEditSaveButton extends StatelessWidget {
+class VoicesEditCancelButton extends StatelessWidget {
+  final VoicesEditCancelButtonStyle style;
   final VoidCallback? onTap;
   final bool isEditing;
   final bool hasError;
 
-  const VoicesEditSaveButton({
+  const VoicesEditCancelButton({
     super.key,
+    this.style = VoicesEditCancelButtonStyle.text,
     this.onTap,
     required this.isEditing,
     this.hasError = false,
   });
 
   @override
   Widget build(BuildContext context) {
+    final theme = Theme.of(context);
     final text =
         isEditing ? context.l10n.cancelButtonText : context.l10n.editButtonText;
+    final textStyle = theme.textTheme.labelSmall!;
 
     if (hasError) {
       return VoicesFilledButton(
-        backgroundColor: Theme.of(context).colorScheme.error,
+        backgroundColor: theme.colorScheme.error,
         onTap: onTap,
-        child: Text(text),
+        child: Text(
+          text,
+          style: textStyle.copyWith(color: theme.colorScheme.onError),
+        ),
       );
-    } else {
+    }
+
+    if (isEditing) {
       return VoicesTextButton(
         onTap: onTap,
         child: Text(
           text,
-          style: Theme.of(context).textTheme.labelSmall,
+          style: textStyle.copyWith(color: theme.colorScheme.error),
         ),
       );
     }
+
+    return switch (style) {
+      VoicesEditCancelButtonStyle.text => VoicesTextButton(
+          onTap: onTap,
+          child: Text(text, style: textStyle),
+        ),
+      VoicesEditCancelButtonStyle.outlinedWithIcon => VoicesOutlinedButton(
+          onTap: onTap,
+          leading: VoicesAssets.icons.pencilAlt.buildIcon(),
+          child: Text(
+            text,
+            style: textStyle.copyWith(color: theme.colorScheme.primary),
+          ),
+        ),
+    };
   }
 }
 
+enum VoicesEditCancelButtonStyle {
+  text,
+  outlinedWithIcon,
+}
+
 /// A "Learn More" button that redirects usually to an external content.
 class VoicesLearnMoreButton extends StatelessWidget {
   final VoidCallback onTap;

catalyst_voices/apps/voices/lib/widgets/document_builder/value/document_error_text.dart renamed to catalyst_voices/apps/voices/lib/widgets/document_builder/common/document_error_text.dart

@@ -0,0 +1,28 @@
+import 'package:catalyst_voices_brands/catalyst_voices_brands.dart';
+import 'package:catalyst_voices_shared/catalyst_voices_shared.dart';
+import 'package:flutter/material.dart';
+
+class DocumentPropertyBuilderTitle extends StatelessWidget {
+  final String title;
+  final bool isRequired;
+  final Color? color;
+
+  const DocumentPropertyBuilderTitle({
+    super.key,
+    required this.title,
+    required this.isRequired,
+    this.color,
+  });
+
+  @override
+  Widget build(BuildContext context) {
+    return Text(
+      title.starred(isEnabled: isRequired),
+      maxLines: 1,
+      overflow: TextOverflow.ellipsis,
+      style: Theme.of(context).textTheme.bodySmall?.copyWith(
+            color: color ?? Theme.of(context).colors.textOnPrimaryLevel1,
+          ),
+    );
+  }
+}

catalyst_voices/apps/voices/lib/widgets/document_builder/common/document_property_builder_title.dart

@@ -1,3 +1,4 @@
+import 'package:catalyst_voices/widgets/document_builder/common/document_error_text.dart';
 import 'package:catalyst_voices/widgets/document_builder/value/document_builder_value_widget.dart';
 import 'package:catalyst_voices/widgets/widgets.dart';
 import 'package:catalyst_voices_models/catalyst_voices_models.dart'

catalyst_voices/apps/voices/lib/widgets/document_builder/document_list_property_builder.dart

@@ -1,3 +1,5 @@
+import 'package:catalyst_voices/widgets/document_builder/common/document_error_text.dart';
+import 'package:catalyst_voices/widgets/document_builder/common/document_property_builder_title.dart';
 import 'package:catalyst_voices/widgets/document_builder/value/document_builder_value_widget.dart';
 import 'package:catalyst_voices/widgets/widgets.dart';
 import 'package:catalyst_voices_models/catalyst_voices_models.dart'
@@ -85,9 +87,9 @@ class _FormField extends VoicesFormField<DocumentObjectProperty> {
                 crossAxisAlignment: CrossAxisAlignment.start,
                 children: [
                   if (title.isNotEmpty && !schema.isSectionOrSubsection) ...[
-                    Text(
-                      title,
-                      style: Theme.of(context).textTheme.titleSmall,
+                    DocumentPropertyBuilderTitle(
+                      title: title,
+                      isRequired: false,
                     ),
                     const SizedBox(height: 8),
                   ],

catalyst_voices/apps/voices/lib/widgets/document_builder/document_object_property_builder.dart

@@ -1,4 +1,4 @@
-import 'package:catalyst_voices/widgets/document_builder/value/document_error_text.dart';
+import 'package:catalyst_voices/widgets/document_builder/common/document_error_text.dart';
 import 'package:catalyst_voices/widgets/widgets.dart';
 import 'package:catalyst_voices_brands/catalyst_voices_brands.dart';
 import 'package:catalyst_voices_localization/catalyst_voices_localization.dart';

catalyst_voices/apps/voices/lib/widgets/document_builder/value/agreement_confirmation_widget.dart

@@ -1,5 +1,4 @@
 export 'agreement_confirmation_widget.dart';
-export 'document_error_text.dart';
 export 'document_token_value_widget.dart';
 export 'duration_in_months_widget.dart';
 export 'language_code_widget.dart';

catalyst_voices/apps/voices/lib/widgets/document_builder/value/document_builder_value_widget.dart

@@ -1,6 +1,6 @@
+import 'package:catalyst_voices/widgets/document_builder/common/document_property_builder_title.dart';
 import 'package:catalyst_voices/widgets/dropdown/voices_dropdown.dart';
 import 'package:catalyst_voices_models/catalyst_voices_models.dart';
-import 'package:catalyst_voices_shared/catalyst_voices_shared.dart';
 import 'package:catalyst_voices_view_models/catalyst_voices_view_models.dart';
 import 'package:flutter/material.dart';
 
@@ -23,12 +23,12 @@ class DurationInMonthsWidget extends StatefulWidget {
 }
 
 class _DurationInMonthsWidgetState extends State<DurationInMonthsWidget> {
-  int? get _value => widget.property.value ?? widget.schema.defaultValue;
-  String get _title => widget.schema.title;
   bool get _isRequired => widget.schema.isRequired;
-  String? get _placeholder => widget.schema.placeholder;
-  int get _min => widget.schema.numRange?.min ?? 0;
   int get _max => widget.schema.numRange?.max ?? 0;
+  int get _min => widget.schema.numRange?.min ?? 0;
+  String? get _placeholder => widget.schema.placeholder;
+  String get _title => widget.schema.title;
+  int? get _value => widget.property.value ?? widget.schema.defaultValue;
 
   @override
   Widget build(BuildContext context) {
@@ -37,9 +37,9 @@ class _DurationInMonthsWidgetState extends State<DurationInMonthsWidget> {
       mainAxisSize: MainAxisSize.min,
       children: [
         if (_title.isNotEmpty) ...[
-          Text(
-            _title.starred(isEnabled: _isRequired),
-            style: Theme.of(context).textTheme.titleSmall,
+          DocumentPropertyBuilderTitle(
+            title: _title,
+            isRequired: _isRequired,
           ),
           const SizedBox(height: 8),
           SingleSelectDropdown(