chore: typeNotIn -> excludeTypes

Author: damian-molinski

catalyst_voices/packages/internal/catalyst_voices_repositories/lib/src/database/dao/documents_v2_dao.dart

@@ -23,15 +23,15 @@ abstract interface class DocumentsV2Dao {
     DocumentRef? referencing,
   });
 
-  /// Deletes documents from the database, preserving those with types in [typeNotIn].
+  /// Deletes documents from the database, preserving those with types in [excludeTypes].
   ///
-  /// If [typeNotIn] is null or empty, this may delete *all* documents (implementation dependent).
+  /// If [excludeTypes] is null or empty, this may delete *all* documents (implementation dependent).
   /// Typically used for cache invalidation or cleaning up old data while keeping
   /// certain important types (e.g. keeping local drafts or templates).
   ///
   /// Returns the number of deleted rows.
   Future<int> deleteWhere({
-    List<DocumentType>? typeNotIn,
+    List<DocumentType>? excludeTypes,
   });
 
   /// Checks if a document exists in the database.
@@ -164,12 +164,12 @@ class DriftDocumentsV2Dao extends DatabaseAccessor<DriftCatalystDatabase>
 
   @override
   Future<int> deleteWhere({
-    List<DocumentType>? typeNotIn,
+    List<DocumentType>? excludeTypes,
   }) {
     final query = delete(documentsV2);
 
-    if (typeNotIn != null) {
-      query.where((tbl) => tbl.type.isNotInValues(typeNotIn));
+    if (excludeTypes != null) {
+      query.where((tbl) => tbl.type.isNotInValues(excludeTypes));
     }
 
     return query.go();

catalyst_voices/packages/internal/catalyst_voices_repositories/lib/src/database/dao/local_draft_documents_v2_dao.dart

@@ -32,12 +32,12 @@ class DriftLocalDraftDocumentsV2Dao extends DatabaseAccessor<DriftCatalystDataba
   @override
   Future<int> deleteWhere({
     DocumentRef? ref,
-    List<DocumentType>? typeNotIn,
+    List<DocumentType>? excludeTypes,
   }) {
     final query = delete(localDocumentsDrafts);
 
-    if (typeNotIn != null) {
-      query.where((tbl) => tbl.type.isNotInValues(typeNotIn));
+    if (excludeTypes != null) {
+      query.where((tbl) => tbl.type.isNotInValues(excludeTypes));
     }
 
     return query.go();
@@ -346,7 +346,7 @@ abstract interface class LocalDraftDocumentsV2Dao {
 
   Future<int> deleteWhere({
     DocumentRef? ref,
-    List<DocumentType>? typeNotIn,
+    List<DocumentType>? excludeTypes,
   });
 
   Future<bool> exists(DocumentRef ref);

catalyst_voices/packages/internal/catalyst_voices_repositories/lib/src/document/document_repository.dart

@@ -410,8 +410,8 @@ final class DocumentRepositoryImpl implements DocumentRepository {
     bool keepLocalDrafts = false,
   }) async {
     final deletedDrafts = keepLocalDrafts ? 0 : await _drafts.delete();
-    final typeNotIn = keepLocalDrafts ? [DocumentType.proposalTemplate] : null;
-    final deletedDocuments = await _localDocuments.delete(typeNotIn: typeNotIn);
+    final excludeTypes = keepLocalDrafts ? [DocumentType.proposalTemplate] : null;
+    final deletedDocuments = await _localDocuments.delete(excludeTypes: excludeTypes);
 
     return deletedDrafts + deletedDocuments;
   }

catalyst_voices/packages/internal/catalyst_voices_repositories/lib/src/document/source/database_documents_data_source.dart

@@ -34,9 +34,9 @@ final class DatabaseDocumentsDataSource
 
   @override
   Future<int> delete({
-    List<DocumentType>? typeNotIn,
+    List<DocumentType>? excludeTypes,
   }) {
-    return _database.documentsV2Dao.deleteWhere(typeNotIn: typeNotIn);
+    return _database.documentsV2Dao.deleteWhere(excludeTypes: excludeTypes);
   }
 
   @override

catalyst_voices/packages/internal/catalyst_voices_repositories/lib/src/document/source/database_drafts_data_source.dart

@@ -24,9 +24,9 @@ final class DatabaseDraftsDataSource implements DraftDataSource {
   @override
   Future<int> delete({
     DocumentRef? ref,
-    List<DocumentType>? typeNotIn,
+    List<DocumentType>? excludeTypes,
   }) {
-    return _database.localDocumentsV2Dao.deleteWhere(ref: ref, typeNotIn: typeNotIn);
+    return _database.localDocumentsV2Dao.deleteWhere(ref: ref, excludeTypes: excludeTypes);
   }
 
   @override

catalyst_voices/packages/internal/catalyst_voices_repositories/lib/src/document/source/document_data_local_source.dart

@@ -20,12 +20,12 @@ abstract interface class DocumentDataLocalSource implements DocumentDataSource {
 
   /// Deletes documents matching the provided filters.
   ///
-  /// * [typeNotIn]: If provided, deletes all documents *except* those
+  /// * [excludeTypes]: If provided, deletes all documents *except* those
   ///   matching the types in this list.
   ///
   /// Returns the number of records deleted.
   Future<int> delete({
-    List<DocumentType>? typeNotIn,
+    List<DocumentType>? excludeTypes,
   });
 
   /// Checks if a specific document exists in local storage.

catalyst_voices/packages/internal/catalyst_voices_repositories/lib/src/document/source/local_document_data_local_source.dart

@@ -9,11 +9,11 @@ abstract interface class DraftDataSource implements DocumentDataLocalSource {
   /// Deletes drafts matching the criteria.
   ///
   /// * [ref]: If provided, deletes the specific draft.
-  /// * [typeNotIn]: Deletes all drafts NOT matching these types (often used for cleanup).
+  /// * [excludeTypes]: Deletes all drafts NOT matching these types (often used for cleanup).
   @override
   Future<int> delete({
     DocumentRef? ref,
-    List<DocumentType>? typeNotIn,
+    List<DocumentType>? excludeTypes,
   });
 
   /// Updates the content of an existing draft identified by [ref].

catalyst_voices/packages/internal/catalyst_voices_repositories/test/src/database/dao/documents_v2_dao_test.dart

@@ -1699,7 +1699,7 @@ void main() {
 
         // When
         final result = await dao.deleteWhere(
-          typeNotIn: [DocumentType.proposalDocument],
+          excludeTypes: [DocumentType.proposalDocument],
         );
 
         // Then
@@ -1739,7 +1739,7 @@ void main() {
 
         // When
         final result = await dao.deleteWhere(
-          typeNotIn: [
+          excludeTypes: [
             DocumentType.proposalDocument,
             DocumentType.proposalTemplate,
           ],
@@ -1785,7 +1785,7 @@ void main() {
         await dao.saveAll(entities);
 
         // When
-        final result = await dao.deleteWhere(typeNotIn: []);
+        final result = await dao.deleteWhere(excludeTypes: []);
 
         // Then
         expect(result, 2);
@@ -1810,7 +1810,7 @@ void main() {
 
         // When
         final result = await dao.deleteWhere(
-          typeNotIn: [DocumentType.proposalDocument],
+          excludeTypes: [DocumentType.proposalDocument],
         );
 
         // Then
@@ -1839,7 +1839,7 @@ void main() {
 
         // When
         final result = await dao.deleteWhere(
-          typeNotIn: [DocumentType.proposalDocument],
+          excludeTypes: [DocumentType.proposalDocument],
         );
 
         // Then
@@ -1880,7 +1880,7 @@ void main() {
 
         // When
         final result = await dao.deleteWhere(
-          typeNotIn: [
+          excludeTypes: [
             DocumentType.proposalDocument,
             DocumentType.proposalTemplate,
             DocumentType.proposalActionDocument,
@@ -1906,7 +1906,7 @@ void main() {
 
         // When
         final result = await dao.deleteWhere(
-          typeNotIn: [DocumentType.proposalDocument],
+          excludeTypes: [DocumentType.proposalDocument],
         );
 
         // Then