fix(cat-gateway): Return EventDBConnectionError to be handled by caller (#3680)

* fix(cat-gateway): Handle non-EventDB connection error

* fix(cat-gateway): Return error to be handled by caller

---------

Co-authored-by: Alex Pozhylenkov <[email protected]>

Author: saibatizoku

catalyst-gateway/bin/src/db/event/signed_docs/full_signed_doc.rs

@@ -1,8 +1,10 @@
 //! `FullSignedDoc` struct implementation.
 
+use anyhow::Context;
+
 use super::SignedDocBody;
 use crate::{
-    db::event::EventDB,
+    db::event::{EventDB, EventDBConnectionError},
     jinja::{get_template, JinjaTemplateSource},
 };
 
@@ -90,17 +92,16 @@ impl FullSignedDoc {
         match EventDB::modify(INSERT_SIGNED_DOCS, &self.postgres_db_fields()).await {
             // Able to insert, no conflict
             Ok(()) => Ok(true),
-            Err(_) => {
+            Err(e) if !e.is::<EventDBConnectionError>() => {
                 // Attempt to retrieve the document now that we failed to insert
-                match Self::retrieve(self.id(), Some(self.ver())).await {
-                    Ok(res_doc) => {
-                        anyhow::ensure!(&res_doc == self, StoreError);
-                        // Document already exists and matches, return false
-                        Ok(false)
-                    },
-                    Err(e) => Err(e),
-                }
+                let doc = Self::retrieve(self.id(), Some(self.ver()))
+                    .await
+                    .context("Cannot retrieve the document which has failed")?;
+                anyhow::ensure!(&doc == self, StoreError);
+                // Document already exists and matches, return false
+                Ok(false)
             },
+            Err(e) => Err(e),
         }
     }
 

catalyst-gateway/bin/src/service/api/documents/put_document/mod.rs

@@ -174,7 +174,7 @@ async fn validate_against_original_doc(doc: &CatalystSignedDocument) -> anyhow::
     let original_doc = match FullSignedDoc::retrieve(&doc.doc_id()?.uuid(), None).await {
         Ok(doc) => doc,
         Err(e) if e.is::<error::NotFoundError>() => return Ok(true),
-        Err(e) => anyhow::bail!("Database error: {e}"),
+        Err(e) => return Err(e),
     };
 
     let original_authors = original_doc