feat(cat-voices): editable username (#2096)

* feat: more CatalystId comparing tools

* feat: expose update account in user service

* feat: updating username

* feat: make CatalystIdText display only significant part

* fix: handling whitespaces in CatalystId username

* chore: rollback log level

* refactor: rename DisplayName -> Username to unify with CatalystId

* fix: document and drafts dao author query

* chore: hide setup roles menu item

* refactor: remove un used methods

Author: damian-molinski

catalyst_voices/apps/voices/lib/pages/account/account_page.dart

@@ -1,13 +1,13 @@
 import 'dart:async';
 
 import 'package:catalyst_voices/pages/account/widgets/account_action_tile.dart';
-import 'package:catalyst_voices/pages/account/widgets/account_display_name_tile.dart';
 import 'package:catalyst_voices/pages/account/widgets/account_email_tile.dart';
 import 'package:catalyst_voices/pages/account/widgets/account_header_tile.dart';
 import 'package:catalyst_voices/pages/account/widgets/account_keychain_tile.dart';
 import 'package:catalyst_voices/pages/account/widgets/account_page_title.dart';
 import 'package:catalyst_voices/pages/account/widgets/account_roles_tile.dart';
 import 'package:catalyst_voices/pages/account/widgets/account_status_banner.dart';
+import 'package:catalyst_voices/pages/account/widgets/account_username_tile.dart';
 import 'package:catalyst_voices/pages/spaces/appbar/account_popup/session_account_avatar.dart';
 import 'package:catalyst_voices/pages/spaces/appbar/session_action_header.dart';
 import 'package:catalyst_voices/widgets/widgets.dart';
@@ -72,7 +72,7 @@ class _AccountPageState extends State<AccountPage> {
                       child: Column(
                         mainAxisSize: MainAxisSize.min,
                         children: const <Widget>[
-                          AccountDisplayNameTile(),
+                          AccountUsernameTile(),
                           AccountEmailTile(),
                         ].separatedBy(const SizedBox(height: 20)).toList(),
                       ),

catalyst_voices/apps/voices/lib/pages/account/widgets/account_display_name_tile.dart renamed to catalyst_voices/apps/voices/lib/pages/account/widgets/account_username_tile.dart

@@ -8,22 +8,22 @@ import 'package:catalyst_voices_view_models/catalyst_voices_view_models.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 
-class AccountDisplayNameTile extends StatefulWidget {
-  const AccountDisplayNameTile({
+class AccountUsernameTile extends StatefulWidget {
+  const AccountUsernameTile({
     super.key,
   });
 
   @override
-  State<AccountDisplayNameTile> createState() => _AccountDisplayNameTileState();
+  State<AccountUsernameTile> createState() => _AccountUsernameTileState();
 }
 
-class _AccountDisplayNameTileState extends State<AccountDisplayNameTile> {
+class _AccountUsernameTileState extends State<AccountUsernameTile> {
   late final TextEditingController _controller;
   late final FocusNode _focusNode;
 
   bool _isEditMode = false;
-  DisplayName _displayName = const DisplayName.pure();
-  StreamSubscription<DisplayName>? _sub;
+  Username _username = const Username.pure();
+  StreamSubscription<Username>? _sub;
 
   @override
   Widget build(BuildContext context) {
@@ -32,19 +32,19 @@ class _AccountDisplayNameTileState extends State<AccountDisplayNameTile> {
       title: context.l10n.displayName,
       onChanged: _onEditModeChange,
       isEditMode: _isEditMode,
-      isSaveEnabled: _displayName.isValid,
-      isEditEnabled: false,
-      child: VoicesDisplayNameTextField(
+      isSaveEnabled: _username.isValid,
+      isEditEnabled: true,
+      child: VoicesUsernameTextField(
         key: const Key('AccountDisplayNameTextField'),
         controller: _controller,
         focusNode: _focusNode,
         decoration: VoicesTextFieldDecoration(
           hintText: context.l10n.displayName,
-          errorText: _displayName.displayError?.message(context),
+          errorText: _username.displayError?.message(context),
         ),
         onFieldSubmitted: null,
         readOnly: !_isEditMode,
-        maxLength: _isEditMode ? DisplayName.lengthRange.max : null,
+        maxLength: _isEditMode ? Username.lengthRange.max : null,
       ),
     );
   }
@@ -64,27 +64,27 @@ class _AccountDisplayNameTileState extends State<AccountDisplayNameTile> {
     super.initState();
 
     final bloc = context.read<AccountCubit>();
-    final text = bloc.state.displayName.value;
+    final text = bloc.state.username.value;
     final value = TextEditingValueExt.collapsedAtEndOf(text);
     _controller = TextEditingController.fromValue(value);
     _controller.addListener(_handleControllerChange);
-    _displayName = bloc.state.displayName;
+    _username = bloc.state.username;
 
     _focusNode = FocusNode();
 
     _sub = bloc.stream
-        .map((event) => event.displayName)
+        .map((event) => event.username)
         .distinct()
-        .listen(_handleDisplayNameChange);
+        .listen(_handleUsernameChange);
   }
 
   void _handleControllerChange() {
     setState(() {
-      _displayName = DisplayName.dirty(_controller.text);
+      _username = Username.dirty(_controller.text);
     });
   }
 
-  void _handleDisplayNameChange(DisplayName displayName) {
+  void _handleUsernameChange(Username displayName) {
     if (_isEditMode) {
       return;
     }
@@ -93,7 +93,7 @@ class _AccountDisplayNameTileState extends State<AccountDisplayNameTile> {
   }
 
   void _onCancel() {
-    final displayName = context.read<AccountCubit>().state.displayName;
+    final displayName = context.read<AccountCubit>().state.username;
     _controller.textWithSelection = displayName.value;
   }
 
@@ -118,7 +118,6 @@ class _AccountDisplayNameTileState extends State<AccountDisplayNameTile> {
   }
 
   void _onSave() {
-    // Note. not supported atm.
-    // unawaited(context.read<AccountCubit>().updateDisplayName(_displayName));
+    unawaited(context.read<AccountCubit>().updateUsername(_username));
   }
 }

catalyst_voices/apps/voices/lib/pages/proposal/widget/proposal_header.dart

@@ -155,7 +155,7 @@ class _ProposalMetadataSelector extends StatelessWidget {
       builder: (context, state) {
         return _ProposalMetadata(
           title: state.title,
-          author: state.authorDisplayName,
+          author: state.authorName,
           createdAt: state.createdAt,
           commentsCount: state.commentsCount,
         );

catalyst_voices/apps/voices/lib/pages/registration/create_base_profile/stage/setup_panel.dart

@@ -64,15 +64,15 @@ class _DisplayNameSelector extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    return BlocBaseProfileSelector<DisplayName>(
-      selector: (state) => state.displayName,
+    return BlocBaseProfileSelector<Username>(
+      selector: (state) => state.username,
       builder: (context, state) => _DisplayNameTextField(displayName: state),
     );
   }
 }
 
 class _DisplayNameTextField extends StatelessWidget {
-  final DisplayName displayName;
+  final Username displayName;
 
   const _DisplayNameTextField({
     required this.displayName,
@@ -82,13 +82,13 @@ class _DisplayNameTextField extends StatelessWidget {
   Widget build(BuildContext context) {
     final l10n = context.l10n;
 
-    return VoicesDisplayNameTextField(
+    return VoicesUsernameTextField(
       key: const Key('DisplayNameTextField'),
       initialText: displayName.value,
       onChanged: (value) {
         RegistrationCubit.of(context)
             .baseProfile
-            .updateDisplayName(DisplayName.dirty(value ?? ''));
+            .updateUsername(Username.dirty(value ?? ''));
       },
       onFieldSubmitted: null,
       decoration: VoicesTextFieldDecoration(
@@ -97,7 +97,7 @@ class _DisplayNameTextField extends StatelessWidget {
         helperText: l10n.createBaseProfileSetupDisplayNameHelper,
         errorText: displayName.displayError?.message(context),
       ),
-      maxLength: DisplayName.lengthRange.max,
+      maxLength: Username.lengthRange.max,
     );
   }
 }