fix(cat-voices): Generate fresh document version before publishing (#2295)

* fix: generate fresh document version

* fix: version count

* fix: latest version

Author: dt-iohk

catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/proposal_builder/proposal_builder_bloc.dart

@@ -557,15 +557,28 @@ final class ProposalBuilderBloc
   Future<void> _publishAndSubmitProposalForReview(
     Emitter<ProposalBuilderState> emit,
   ) async {
+    final currentRef = state.metadata.documentRef!;
     final updatedRef = await _proposalService.publishProposal(
       document: _buildDocumentData(),
     );
 
+    List<DocumentVersion>? updatedVersions;
+    if (updatedRef != currentRef) {
+      // if a new ref has been created we need to recreate
+      // the version history to reflect it, drop the old one
+      // because the new one overrode it
+      updatedVersions = _recreateDocumentVersionsWithNewRef(
+        newRef: updatedRef,
+        removedRef: currentRef,
+      );
+    }
+
     _updateMetadata(
       emit,
       documentRef: updatedRef,
       originalDocumentRef: updatedRef,
       publish: ProposalPublish.publishedDraft,
+      versions: updatedVersions,
     );
 
     await _proposalService.submitProposalForReview(
@@ -589,15 +602,28 @@ final class ProposalBuilderBloc
       _logger.info('Publishing proposal');
       emit(state.copyWith(isChanging: true));
 
+      final currentRef = state.metadata.documentRef!;
       final updatedRef = await _proposalService.publishProposal(
         document: _buildDocumentData(),
       );
 
+      List<DocumentVersion>? updatedVersions;
+      if (updatedRef != currentRef) {
+        // if a new ref has been created we need to recreate
+        // the version history to reflect it, drop the old one
+        // because the new one overrode it
+        updatedVersions = _recreateDocumentVersionsWithNewRef(
+          newRef: updatedRef,
+          removedRef: currentRef,
+        );
+      }
+
       _updateMetadata(
         emit,
         documentRef: updatedRef,
         originalDocumentRef: updatedRef,
         publish: ProposalPublish.publishedDraft,
+        versions: updatedVersions,
       );
       emitSignal(const PublishedProposalBuilderSignal());
     } catch (error, stackTrace) {
@@ -654,24 +680,28 @@ final class ProposalBuilderBloc
     );
   }
 
-  List<DocumentVersion> _recreateDocumentVersionsWithNewRef(
-    DocumentRef newRef,
-  ) {
-    final current = state.metadata.versions;
+  List<DocumentVersion> _recreateDocumentVersionsWithNewRef({
+    DocumentRef? newRef,
+    DocumentRef? removedRef,
+  }) {
+    final current =
+        state.metadata.versions.whereNot((e) => e.id == removedRef?.version);
+    final currentId = newRef?.version ?? current.last.id;
 
     return [
-      ...current.map(
-        (e) => e.copyWith(
-          isCurrent: false,
-          isLatest: false,
+      for (final (index, ver) in current.indexed)
+        ver.copyWith(
+          number: index + 1,
+          isCurrent: ver.id == currentId,
+          isLatest: ver.id == currentId,
+        ),
+      if (newRef != null)
+        DocumentVersion(
+          id: newRef.version!,
+          number: current.length + 1,
+          isCurrent: newRef.version == currentId,
+          isLatest: newRef.version == currentId,
         ),
-      ),
-      DocumentVersion(
-        id: newRef.version!,
-        number: current.length + 1,
-        isCurrent: true,
-        isLatest: true,
-      ),
     ];
   }
 
@@ -688,7 +718,7 @@ final class ProposalBuilderBloc
     if (updatedRef != currentRef) {
       // if a new ref has been created we need to recreate
       // the version history to reflect it
-      updatedVersions = _recreateDocumentVersionsWithNewRef(updatedRef);
+      updatedVersions = _recreateDocumentVersionsWithNewRef(newRef: updatedRef);
     }
 
     _updateMetadata(

catalyst_voices/packages/internal/catalyst_voices_models/lib/src/campaign/campaign_base.dart

@@ -27,7 +27,10 @@ base class CampaignBase extends Equatable {
 
   // TODO(damian-molinski): this should come from api
   SignedDocumentRef get proposalTemplateRef {
-    return const SignedDocumentRef(id: '0194d492-1daa-75b5-b4a4-5cf331cd8d1a');
+    return const SignedDocumentRef(
+      id: '0194d492-1daa-75b5-b4a4-5cf331cd8d1a',
+      version: '0194d492-1daa-75b5-b4a4-5cf331cd8d1a',
+    );
   }
 
   @override

catalyst_voices/packages/internal/catalyst_voices_models/lib/src/document/data/document_data.dart

@@ -28,4 +28,12 @@ final class DocumentData extends Equatable {
 
   /// Syntax sugar. Should use [DocumentDataMetadata.selfRef].
   DocumentRef get ref => metadata.selfRef;
+
+  /// Update document data with a new [ref].
+  DocumentData copyWithSelfRef({required DocumentRef selfRef}) {
+    return DocumentData(
+      metadata: metadata.copyWith(selfRef: selfRef),
+      content: content,
+    );
+  }
 }