feat(cat-voices): comment error dialog (#2147)

* feat: update document property section buttons

* feat: update title widget

* feat: add property read widget

* feat: document property viewer widget

* feat: distinguish between answered and not answered

* feat: handle overriden widgets in document builder viewer

* fix: submit proposal for review

* feat: cleanup colors, update save button

* chore: cleanup

* chore: cleanup

* feat: update rich text widget

* style: spelling

* feat: submit comment error dialog

* chore: fix dialog positioning

* feat: add comment error dialog in proposal page

Author: dt-iohk

catalyst_voices/apps/voices/lib/pages/proposal/proposal_page.dart

@@ -10,6 +10,7 @@ import 'package:catalyst_voices/pages/proposal/widget/proposal_header.dart';
 import 'package:catalyst_voices/pages/proposal/widget/proposal_navigation_panel.dart';
 import 'package:catalyst_voices/pages/proposal/widget/proposal_sidebars.dart';
 import 'package:catalyst_voices/routes/routes.dart';
+import 'package:catalyst_voices/widgets/modals/comment/submit_comment_error_dialog.dart';
 import 'package:catalyst_voices/widgets/snackbar/voices_snackbar.dart';
 import 'package:catalyst_voices/widgets/widgets.dart';
 import 'package:catalyst_voices_blocs/catalyst_voices_blocs.dart';
@@ -83,6 +84,16 @@ class _ProposalPageState extends State<ProposalPage>
     super.dispose();
   }
 
+  @override
+  void handleError(Object error) {
+    switch (error) {
+      case LocalizedUnknownPublishCommentException():
+        unawaited(_showCommentException(error));
+      default:
+        super.handleError(error);
+    }
+  }
+
   @override
   void handleSignal(ProposalSignal signal) {
     switch (signal) {
@@ -124,6 +135,15 @@ class _ProposalPageState extends State<ProposalPage>
 
   void _handleSegmentsControllerChange() {}
 
+  Future<void> _showCommentException(
+    LocalizedUnknownPublishCommentException error,
+  ) {
+    return SubmitCommentErrorDialog.show(
+      context: context,
+      exception: error,
+    );
+  }
+
   void _updateSegments(List<Segment> data) {
     final state = _segmentsController.value;
 

catalyst_voices/apps/voices/lib/pages/proposal_builder/proposal_builder_page.dart

@@ -13,6 +13,7 @@ import 'package:catalyst_voices/pages/proposal_builder/proposal_builder_setup_pa
 import 'package:catalyst_voices/pages/spaces/appbar/session_state_header.dart';
 import 'package:catalyst_voices/routes/routing/proposal_builder_route.dart';
 import 'package:catalyst_voices/routes/routing/spaces_route.dart';
+import 'package:catalyst_voices/widgets/modals/comment/submit_comment_error_dialog.dart';
 import 'package:catalyst_voices/widgets/modals/proposals/publish_proposal_error_dialog.dart';
 import 'package:catalyst_voices/widgets/modals/proposals/submit_proposal_error_dialog.dart';
 import 'package:catalyst_voices/widgets/snackbar/voices_snackbar.dart';
@@ -138,6 +139,8 @@ class _ProposalBuilderPageState extends State<ProposalBuilderPage>
         unawaited(_showPublishException(error));
       case ProposalBuilderSubmitException():
         unawaited(_showSubmitException(error));
+      case LocalizedUnknownPublishCommentException():
+        unawaited(_showCommentException(error));
       default:
         super.handleError(error);
     }
@@ -231,6 +234,15 @@ class _ProposalBuilderPageState extends State<ProposalBuilderPage>
     }
   }
 
+  Future<void> _showCommentException(
+    LocalizedUnknownPublishCommentException error,
+  ) {
+    return SubmitCommentErrorDialog.show(
+      context: context,
+      exception: error,
+    );
+  }
+
   Future<void> _showPublishException(ProposalBuilderPublishException error) {
     return PublishProposalErrorDialog.show(
       context: context,

catalyst_voices/apps/voices/lib/widgets/modals/comment/submit_comment_error_dialog.dart

@@ -0,0 +1,36 @@
+import 'package:catalyst_voices/widgets/buttons/voices_filled_button.dart';
+import 'package:catalyst_voices/widgets/modals/voices_dialog.dart';
+import 'package:catalyst_voices/widgets/modals/voices_info_dialog.dart';
+import 'package:catalyst_voices_assets/catalyst_voices_assets.dart';
+import 'package:catalyst_voices_brands/catalyst_voices_brands.dart';
+import 'package:catalyst_voices_localization/catalyst_voices_localization.dart';
+import 'package:catalyst_voices_view_models/catalyst_voices_view_models.dart';
+import 'package:flutter/material.dart';
+
+/// Error dialog when submitting comment fails.
+class SubmitCommentErrorDialog {
+  static Future<void> show({
+    required BuildContext context,
+    required LocalizedException exception,
+  }) {
+    return VoicesDialog.show(
+      context: context,
+      routeSettings: const RouteSettings(
+        name: '/comments/submit-error',
+      ),
+      builder: (context) {
+        return VoicesDesktopInfoDialog(
+          icon: VoicesAssets.icons.exclamation.buildIcon(
+            color: Theme.of(context).colors.iconsWarning,
+          ),
+          title: Text(context.l10n.submitCommentErrorDialogTitle),
+          message: Text(exception.message(context)),
+          action: VoicesFilledButton(
+            onTap: () => Navigator.of(context).pop(),
+            child: Text(context.l10n.okay),
+          ),
+        );
+      },
+    );
+  }
+}

catalyst_voices/apps/voices/lib/widgets/modals/proposals/submit_proposal_error_dialog.dart

@@ -7,7 +7,7 @@ import 'package:catalyst_voices_localization/catalyst_voices_localization.dart';
 import 'package:catalyst_voices_view_models/catalyst_voices_view_models.dart';
 import 'package:flutter/material.dart';
 
-/// Error dialog when submitting proposal for review fails..
+/// Error dialog when submitting proposal for review fails.
 class SubmitProposalErrorDialog {
   static Future<void> show({
     required BuildContext context,

catalyst_voices/apps/voices/lib/widgets/modals/voices_desktop_dialog.dart

@@ -39,7 +39,7 @@ class VoicesSinglePaneDialog extends StatelessWidget {
       child: Stack(
         alignment: closeAlignment,
         children: [
-          child,
+          Positioned.fill(child: child),
           Offstage(
             offstage: !showClose,
             child: const _CloseButton(),
@@ -105,6 +105,27 @@ class VoicesTwoPaneDialog extends StatelessWidget {
   }
 }
 
+class _CloseButton extends StatelessWidget {
+  const _CloseButton();
+
+  @override
+  Widget build(BuildContext context) {
+    const buttonStyle = ButtonStyle(
+      fixedSize: WidgetStatePropertyAll(Size.square(48)),
+    );
+
+    return IconButtonTheme(
+      data: const IconButtonThemeData(style: buttonStyle),
+      child: XButton(
+        key: const Key('DialogCloseButton'),
+        onTap: () {
+          unawaited(Navigator.of(context).maybePop());
+        },
+      ),
+    );
+  }
+}
+
 class _VoicesDesktopDialog extends StatelessWidget {
   final BoxConstraints constraints;
   final Color? backgroundColor;
@@ -139,24 +160,3 @@ class _VoicesDesktopDialog extends StatelessWidget {
     );
   }
 }
-
-class _CloseButton extends StatelessWidget {
-  const _CloseButton();
-
-  @override
-  Widget build(BuildContext context) {
-    const buttonStyle = ButtonStyle(
-      fixedSize: WidgetStatePropertyAll(Size.square(48)),
-    );
-
-    return IconButtonTheme(
-      data: const IconButtonThemeData(style: buttonStyle),
-      child: XButton(
-        key: const Key('DialogCloseButton'),
-        onTap: () {
-          unawaited(Navigator.of(context).maybePop());
-        },
-      ),
-    );
-  }
-}

catalyst_voices/packages/internal/catalyst_voices_localization/lib/l10n/intl_en.arb

@@ -2284,5 +2284,9 @@
   "insertNewImageFailedToLoad": "Image failed to load",
   "@insertNewImageFailedToLoad": {
     "description": "Text for the image failed to load"
+  },
+  "submitCommentErrorDialogTitle": "Unable to add Comment",
+  "@submitCommentErrorDialogTitle": {
+    "description": "Title for the error dialog when submitting a comment fails"
   }
 }