fix(cat-voices): Proposal builder UI fixes (#2320)

* chore: rename files

* fix: make sure guidance for subsection is not shown under parent section

* fix: guidance title

* fix: jump scroll to top when guidance changes

Author: dt-iohk

catalyst_voices/apps/voices/lib/pages/proposal_builder/proposal_builder_setup_panel.dart

@@ -1,39 +1,54 @@
+import 'dart:async';
+
 import 'package:catalyst_voices/pages/proposal_builder/proposal_builder_guidance.dart';
 import 'package:catalyst_voices/widgets/widgets.dart';
+import 'package:catalyst_voices_blocs/catalyst_voices_blocs.dart';
 import 'package:catalyst_voices_localization/catalyst_voices_localization.dart';
 import 'package:flutter/material.dart';
+import 'package:flutter_bloc/flutter_bloc.dart';
 
-class ProposalBuilderSetupPanel extends StatelessWidget {
+class ProposalBuilderSetupPanel extends StatefulWidget {
   const ProposalBuilderSetupPanel({super.key});
 
+  @override
+  State<ProposalBuilderSetupPanel> createState() =>
+      _ProposalBuilderSetupPanelState();
+}
+
+class _ProposalBuilderSetupPanelState extends State<ProposalBuilderSetupPanel> {
+  final ScrollController _scrollController = ScrollController();
+  StreamSubscription<dynamic>? _guidanceSub;
+
   @override
   Widget build(BuildContext context) {
     return SpaceSidePanel(
       isLeft: false,
+      scrollController: _scrollController,
       onCollapseTap: () {},
       tabs: [
         SpaceSidePanelTab(
           name: context.l10n.guidance,
           body: const ProposalBuilderGuidanceSelector(),
         ),
-        // TODO(damian-molinski): uncomment and implement when builder
-        // collaboration is ready.
-        /*SpaceSidePanelTab(
-          name: 'Comments',
-          body: CommentCard(
-            comment: Comment(
-              text: 'Lacks clarity on key objectives and measurable outcomes.',
-              date: DateTime.now(),
-              userName: 'Community Member',
-            ),
-          ),
-        ),*/
-        //No actions for now
-        // SpaceSidePanelTab(
-        //   name: 'Actions',
-        //   body: const Offstage(),
-        // ),
       ],
     );
   }
+
+  @override
+  void dispose() {
+    _scrollController.dispose();
+    unawaited(_guidanceSub?.cancel());
+    super.dispose();
+  }
+
+  @override
+  void initState() {
+    super.initState();
+    final bloc = context.read<ProposalBuilderBloc>();
+
+    _guidanceSub = bloc.stream
+        .map((state) => state.guidance)
+        .distinct()
+        .listen((_) => _scrollController.jumpTo(0));
+  }
 }

catalyst_voices/apps/voices/lib/pages/proposals/widgets/proposals_pagination.dart

@@ -1,7 +1,7 @@
 import 'package:catalyst_voices/pages/proposals/widgets/proposals_pagination_empty_state.dart';
 import 'package:catalyst_voices/pages/proposals/widgets/proposals_pagination_tile.dart';
 import 'package:catalyst_voices/widgets/pagination/builders/paged_wrap_child_builder.dart';
-import 'package:catalyst_voices/widgets/pagination/layouts/paginated_grid_view.dart.dart';
+import 'package:catalyst_voices/widgets/pagination/layouts/paginated_grid_view.dart';
 import 'package:catalyst_voices/widgets/pagination/paging_controller.dart';
 import 'package:catalyst_voices_view_models/catalyst_voices_view_models.dart';
 import 'package:flutter/material.dart';

catalyst_voices/apps/voices/lib/widgets/containers/sidebar/space_side_panel.dart

@@ -13,6 +13,7 @@ class SpaceSidePanel extends StatefulWidget {
   final bool isLeft;
   final VoidCallback? onCollapseTap;
   final TabController? tabController;
+  final ScrollController? scrollController;
   final List<SpaceSidePanelTab> tabs;
   final EdgeInsetsGeometry margin;
 
@@ -21,6 +22,7 @@ class SpaceSidePanel extends StatefulWidget {
     required this.isLeft,
     this.onCollapseTap,
     this.tabController,
+    this.scrollController,
     required this.tabs,
     this.margin = const EdgeInsets.only(
       top: 12,
@@ -153,6 +155,7 @@ class _SpaceSidePanelState extends State<SpaceSidePanel>
                     const SizedBox(height: 12),
                     Flexible(
                       child: SingleChildScrollView(
+                        controller: widget.scrollController,
                         padding: const EdgeInsets.only(bottom: 12),
                         child: TabBarStackView(
                           controller: widget.tabController,

catalyst_voices/apps/voices/lib/widgets/document_builder/value/document_builder_value_widget.dart

@@ -8,5 +8,5 @@ export 'radio_button_selection_widget.dart';
 export 'simple_text_entry_widget.dart';
 export 'single_dropdown_selection_widget.dart';
 export 'single_grouped_tag_selector_widget.dart';
-export 'single_line_https_url_widget.dart.dart';
+export 'single_line_https_url_widget.dart';
 export 'yes_no_choice_widget.dart';

catalyst_voices/apps/voices/lib/widgets/document_builder/value/single_line_https_url_widget.dart.dart renamed to catalyst_voices/apps/voices/lib/widgets/document_builder/value/single_line_https_url_widget.dart

@@ -244,11 +244,17 @@ final class ProposalBuilderBloc
     DocumentSection section,
     DocumentProperty property,
   ) sync* {
+    if (property.schema.isSubsection && section.id != property.nodeId) {
+      // Since the property is a standalone subsection we cannot
+      // lookup guidance items for it in a context of given section.
+      return;
+    }
+
     final guidance = property.schema.guidance;
     if (guidance != null) {
       yield ProposalGuidanceItem(
         segmentTitle: segment.schema.title,
-        sectionTitle: section.schema.title,
+        sectionTitle: property.schema.title,
         description: guidance,
       );
     }