Skip to content

Commit fa42a67

Browse files
chore(cat-voices): cherry-pick f15/cat-app changes (#3542)
* disable auto deploy on merge (#3540) * chore(cat-voices): update registration acknowledgements (#3539) * chore: remove drep checkbox * chore: wording * fix: failing test
1 parent 8785fe4 commit fa42a67

File tree

8 files changed

+4
-157
lines changed

8 files changed

+4
-157
lines changed

catalyst_voices/apps/voices/lib/pages/registration/create_base_profile/stage/widgets/drep_approval_contingency_checkbox.dart

Lines changed: 0 additions & 36 deletions
This file was deleted.

catalyst_voices/apps/voices/lib/pages/registration/create_base_profile/stage/widgets/drep_approval_contingency_rich_text.dart

Lines changed: 0 additions & 61 deletions
This file was deleted.

catalyst_voices/apps/voices/lib/pages/registration/create_base_profile/stage/widgets/instructions_acknowledgements.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import 'package:catalyst_voices/common/ext/build_context_ext.dart';
2-
import 'package:catalyst_voices/pages/registration/create_base_profile/stage/widgets/drep_approval_contingency_checkbox.dart';
32
import 'package:catalyst_voices/pages/registration/create_base_profile/stage/widgets/registration_conditions_checkbox.dart';
43
import 'package:catalyst_voices/pages/registration/create_base_profile/stage/widgets/tos_and_privacy_policy_checkbox.dart';
54
import 'package:catalyst_voices_localization/catalyst_voices_localization.dart';
@@ -18,7 +17,6 @@ class InstructionsAcknowledgements extends StatelessWidget {
1817
_TitleText(),
1918
RegistrationConditionsCheckbox(),
2019
TosAndPrivacyPolicyCheckbox(),
21-
DrepApprovalContingencyCheckbox(),
2220
],
2321
);
2422
}

catalyst_voices/blueprint.cue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ project: {
2626
}
2727
deployment: {
2828
on: {
29-
merge: {}
3029
tag: {}
3130
}
3231

@@ -136,7 +135,6 @@ project: {
136135
release: {
137136
docker: {
138137
on: {
139-
merge: {}
140138
tag: {}
141139
}
142140
config: {

catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/registration/cubits/base_profile_cubit.dart

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ final class BaseProfileCubit extends Cubit<BaseProfileStateData>
1616
username: Username.dirty('Dev'),
1717
conditionsAccepted: true,
1818
tosAndPrivacyPolicyAccepted: true,
19-
drepApprovalContingencyAccepted: true,
2019
)
2120
: const BaseProfileStateData(),
2221
);
@@ -35,13 +34,6 @@ final class BaseProfileCubit extends Cubit<BaseProfileStateData>
3534
emit(state.copyWith(conditionsAccepted: accepted));
3635
}
3736

38-
@override
39-
void updateDrepApprovalContingency({
40-
required bool accepted,
41-
}) {
42-
emit(state.copyWith(drepApprovalContingencyAccepted: accepted));
43-
}
44-
4537
@override
4638
void updateEmail(Email value) {
4739
final receiveEmails = state.receiveEmails.copyWith(
@@ -74,8 +66,6 @@ final class BaseProfileCubit extends Cubit<BaseProfileStateData>
7466
abstract interface class BaseProfileManager {
7567
void updateConditions({required bool accepted});
7668

77-
void updateDrepApprovalContingency({required bool accepted});
78-
7969
void updateEmail(Email value);
8070

8171
void updateReceiveEmails({required bool isAccepted});

catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/registration/state_data/base_profile_state_data.dart

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,16 @@ final class BaseProfileStateData extends Equatable {
77
final Username username;
88
final bool conditionsAccepted;
99
final bool tosAndPrivacyPolicyAccepted;
10-
final bool drepApprovalContingencyAccepted;
1110

1211
const BaseProfileStateData({
1312
this.email = const Email.pure(),
1413
this.receiveEmails = const ReceiveEmails(),
1514
this.username = const Username.pure(),
1615
this.conditionsAccepted = false,
1716
this.tosAndPrivacyPolicyAccepted = false,
18-
this.drepApprovalContingencyAccepted = false,
1917
});
2018

21-
bool get arAcknowledgementsAccepted =>
22-
conditionsAccepted && tosAndPrivacyPolicyAccepted && drepApprovalContingencyAccepted;
19+
bool get arAcknowledgementsAccepted => conditionsAccepted && tosAndPrivacyPolicyAccepted;
2320

2421
bool get isBaseProfileDataValid {
2522
if (!email.isValid || !username.isValid) {
@@ -42,7 +39,6 @@ final class BaseProfileStateData extends Equatable {
4239
receiveEmails,
4340
conditionsAccepted,
4441
tosAndPrivacyPolicyAccepted,
45-
drepApprovalContingencyAccepted,
4642
];
4743

4844
BaseProfileStateData copyWith({
@@ -51,16 +47,13 @@ final class BaseProfileStateData extends Equatable {
5147
Username? username,
5248
bool? conditionsAccepted,
5349
bool? tosAndPrivacyPolicyAccepted,
54-
bool? drepApprovalContingencyAccepted,
5550
}) {
5651
return BaseProfileStateData(
5752
email: email ?? this.email,
5853
receiveEmails: receiveEmails ?? this.receiveEmails,
5954
username: username ?? this.username,
6055
conditionsAccepted: conditionsAccepted ?? this.conditionsAccepted,
6156
tosAndPrivacyPolicyAccepted: tosAndPrivacyPolicyAccepted ?? this.tosAndPrivacyPolicyAccepted,
62-
drepApprovalContingencyAccepted:
63-
drepApprovalContingencyAccepted ?? this.drepApprovalContingencyAccepted,
6457
);
6558
}
6659
}

catalyst_voices/packages/internal/catalyst_voices_blocs/test/registration/cubits/base_profile_cubit_test.dart

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -49,32 +49,6 @@ void main() {
4949
],
5050
);
5151

52-
blocTest<BaseProfileCubit, BaseProfileStateData>(
53-
'emits updated drepApprovalContingencyAccepted when updateDrepApprovalContingency is called with true',
54-
build: () => baseProfileCubit,
55-
act: (cubit) => cubit.updateDrepApprovalContingency(accepted: true),
56-
expect: () => [
57-
isA<BaseProfileStateData>().having(
58-
(e) => e.drepApprovalContingencyAccepted,
59-
'drepApprovalContingencyAccepted',
60-
true,
61-
),
62-
],
63-
);
64-
65-
blocTest<BaseProfileCubit, BaseProfileStateData>(
66-
'emits updated drepApprovalContingencyAccepted when updateDrepApprovalContingency is called with false',
67-
build: () => baseProfileCubit,
68-
act: (cubit) => cubit.updateDrepApprovalContingency(accepted: false),
69-
expect: () => [
70-
isA<BaseProfileStateData>().having(
71-
(e) => e.drepApprovalContingencyAccepted,
72-
'drepApprovalContingencyAccepted',
73-
false,
74-
),
75-
],
76-
);
77-
7852
blocTest<BaseProfileCubit, BaseProfileStateData>(
7953
'emits updated email when updateEmail is called with valid email',
8054
build: () => baseProfileCubit,

catalyst_voices/packages/internal/catalyst_voices_localization/lib/l10n/intl_en.arb

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -414,11 +414,11 @@
414414
"@catalystKnowledgeBase": {
415415
"description": "Menu item text for accessing knowledge base"
416416
},
417-
"catalystPrivacyPolicy": "Catalyst FC's Privacy Policy",
417+
"catalystPrivacyPolicy": "Project Catalyst Platform Privacy Policy",
418418
"@catalystPrivacyPolicy": {
419-
"description": "Link to the Catalyst FC's Privacy Policy"
419+
"description": "Link to the Catalyst Privacy Policy"
420420
},
421-
"catalystTos": "Project Catalyst Terms and Conditions",
421+
"catalystTos": "Project Catalyst Platform Terms of Use",
422422
"@catalystTos": {
423423
"description": "Link to the Catalyst FC's Terms and Conditions"
424424
},
@@ -708,15 +708,6 @@
708708
"@createProfileCreatedTitle": {
709709
"description": "Title for the profile created"
710710
},
711-
"createProfileDrepApprovalContingency": "I understand that for my proposal to move to Community Review and/or Voting and be eligible for funding, the Project Catalyst budget proposal must first be approved by the Cardano DReps, as detailed in the {fundProposalSubmissionNotice}. If the budget is not approved, my proposal will not move forward and no funding will be provided.",
712-
"@createProfileDrepApprovalContingency": {
713-
"description": "Text acknowledging that the user is aware of the Drep Approval Contingency",
714-
"placeholders": {
715-
"fundProposalSubmissionNotice": {
716-
"type": "String"
717-
}
718-
}
719-
},
720711
"createProfileInstructionsEmailRequest": "Email request",
721712
"@createProfileInstructionsEmailRequest": {
722713
"description": "Request to provide email address"

0 commit comments

Comments
 (0)