-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Labels
squad: faceFrontend Catalyst Experience TeamFrontend Catalyst Experience Team
Description
Summary
Upgrade melos to latest stable version and resolve dependency cycles
Description
https://github.com/input-output-hk/catalyst-voices/actions/runs/21388421862/job/61569679681?pr=4068
Recent melos upgrade changed the behavior of the --order-dependents flag which now checks cycles between dependencies before filtering is done and before the changes it checked the cycles after filtering was done.
This change causes cycles issues:
./catalyst_voices+code-generator | π¨ 3 cycles in dependencies found:
./catalyst_voices+code-generator | [ catalyst_cardano_serialization -> catalyst_key_derivation ]
./catalyst_voices+code-generator | [ catalyst_voices_models -> catalyst_voices_shared ]
./catalyst_voices+code-generator | [ catalyst_voices_blocs -> catalyst_voices_view_models -> catalyst_voices_shared -> catalyst_voices_models ]
Possible solutions:
- stop using
--order-dependentsbut make sure that code can be generated correctly (watch out for generating code which depends on not yet generated code) - remove cycles from dependencies
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
squad: faceFrontend Catalyst Experience TeamFrontend Catalyst Experience Team
Type
Projects
Status
New