-
Notifications
You must be signed in to change notification settings - Fork 9
feat(cat-voices): proposals query filtering #3641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cat-voices): proposals query filtering #3641
Conversation
…pository. Index is only available in DocumentDataRemoteSource
…ments_indexing_3528
…zation_3528_part2
…put-output-hk/catalyst-voices into feat/database_optimization_3528_part2
…se_optimization_3528_part3
LynxLynxx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a few nit picks or questions
catalyst_voices/apps/voices/lib/pages/proposals/proposals_page.dart
Outdated
Show resolved
Hide resolved
catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/proposals/proposals_cubit.dart
Outdated
Show resolved
Hide resolved
catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/proposals/proposals_cubit.dart
Show resolved
Hide resolved
LynxLynxx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side LGTM
catalyst_voices/apps/voices/lib/pages/proposals/widgets/proposals_tabs.dart
Outdated
Show resolved
Hide resolved
catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/proposals/proposals_cubit.dart
Show resolved
Hide resolved
...es/packages/internal/catalyst_voices_repositories/lib/src/database/dao/proposals_v2_dao.dart
Outdated
Show resolved
Hide resolved
...es/packages/internal/catalyst_voices_repositories/lib/src/database/dao/proposals_v2_dao.dart
Outdated
Show resolved
Hide resolved
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: https://docs.dev.projectcatalyst.io/voices/feat/database_optimization_3528_part3 |
2a8547a
into
feat/database_optimization_3528
Description
Proposals query filtering options.
Related Issue(s)
Part of #3528
Description of Changes
ProposalsCubit, build and close, locally byProposalsPageto fee up resourcesProposalsFiltersV2and integration queries withProposalsPagePlan for following PRs
VotingPageCampaignfounds requested + categories funds requests queryDemo
proposals_page.mov
Related Pull Requests
Must be merged after #3614
Please confirm the following checks